From: Joe Perches <joe@perches.com>
To: Andreas Theodosiou <andreasabu@gmail.com>
Cc: thomas.petazzoni@free-electrons.com, noralf@tronnes.org,
gregkh@linuxfoundation.org, devel@driverdev.osuosl.org,
linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org
Subject: Re: [PATCH] staging: fbtft: 80 characters per line in fb_ili9163.c
Date: Sat, 04 Apr 2015 00:32:40 +0000 [thread overview]
Message-ID: <1428107560.2775.2.camel@perches.com> (raw)
In-Reply-To: <1428106999-10067-1-git-send-email-andreasabu@gmail.com>
On Sat, 2015-04-04 at 03:23 +0300, Andreas Theodosiou wrote:
> This is a patch to the fb_ili9163.c file that inserts a line break in
> line #92 to make the line fit into the 80 character limit.
[]
> diff --git a/drivers/staging/fbtft/fb_ili9163.c b/drivers/staging/fbtft/fb_ili9163.c
[]
> @@ -89,7 +89,8 @@
>
> /*
> This display:
> -http://www.ebay.com/itm/Replace-Nokia-5110-LCD-1-44-Red-Serial-128X128-SPI-Color-TFT-LCD-Display-Module-/271422122271
> +http://www.ebay.com/itm/Replace-Nokia-5110-LCD-1-44-Red-Serial-128X128-SPI-
> +Color-TFT-LCD-Display-Module-/271422122271
Please don't do this to links.
There are many real defects to fix and other code to improve.
This isn't one of those.
I doubt though that an ebay link is very long lasting.
WARNING: multiple messages have this Message-ID (diff)
From: Joe Perches <joe@perches.com>
To: Andreas Theodosiou <andreasabu@gmail.com>
Cc: thomas.petazzoni@free-electrons.com, noralf@tronnes.org,
gregkh@linuxfoundation.org, devel@driverdev.osuosl.org,
linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org
Subject: Re: [PATCH] staging: fbtft: 80 characters per line in fb_ili9163.c
Date: Fri, 03 Apr 2015 17:32:40 -0700 [thread overview]
Message-ID: <1428107560.2775.2.camel@perches.com> (raw)
In-Reply-To: <1428106999-10067-1-git-send-email-andreasabu@gmail.com>
On Sat, 2015-04-04 at 03:23 +0300, Andreas Theodosiou wrote:
> This is a patch to the fb_ili9163.c file that inserts a line break in
> line #92 to make the line fit into the 80 character limit.
[]
> diff --git a/drivers/staging/fbtft/fb_ili9163.c b/drivers/staging/fbtft/fb_ili9163.c
[]
> @@ -89,7 +89,8 @@
>
> /*
> This display:
> -http://www.ebay.com/itm/Replace-Nokia-5110-LCD-1-44-Red-Serial-128X128-SPI-Color-TFT-LCD-Display-Module-/271422122271
> +http://www.ebay.com/itm/Replace-Nokia-5110-LCD-1-44-Red-Serial-128X128-SPI-
> +Color-TFT-LCD-Display-Module-/271422122271
Please don't do this to links.
There are many real defects to fix and other code to improve.
This isn't one of those.
I doubt though that an ebay link is very long lasting.
next prev parent reply other threads:[~2015-04-04 0:32 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-04-04 0:23 [PATCH] staging: fbtft: 80 characters per line in fb_ili9163.c Andreas Theodosiou
2015-04-04 0:23 ` Andreas Theodosiou
2015-04-04 0:32 ` Joe Perches [this message]
2015-04-04 0:32 ` Joe Perches
2015-04-04 1:12 ` Giedrius Statkevičius
2015-04-04 1:12 ` Giedrius Statkevičius
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1428107560.2775.2.camel@perches.com \
--to=joe@perches.com \
--cc=andreasabu@gmail.com \
--cc=devel@driverdev.osuosl.org \
--cc=gregkh@linuxfoundation.org \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=noralf@tronnes.org \
--cc=thomas.petazzoni@free-electrons.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.