From: Ming Lin <mlin@kernel.org>
To: linux-kernel@vger.kernel.org
Cc: Christoph Hellwig <hch@lst.de>, Jens Axboe <axboe@kernel.dk>,
Kent Overstreet <kent.overstreet@gmail.com>,
Dongsu Park <dpark@posteo.net>, Ming Lin <mlin@kernel.org>,
Christoph Hellwig <hch@infradead.org>,
Jonathan Corbet <corbet@lwn.net>,
linux-doc@vger.kernel.org
Subject: [PATCH v3 11/11] Documentation: update notes in biovecs about arbitrarily sized bios
Date: Wed, 6 May 2015 23:34:21 -0700 [thread overview]
Message-ID: <1430980461-5235-12-git-send-email-mlin@kernel.org> (raw)
In-Reply-To: <1430980461-5235-1-git-send-email-mlin@kernel.org>
From: Dongsu Park <dpark@posteo.net>
Update block/biovecs.txt so that it includes a note on what kind of
effects arbitrarily sized bios would bring to the block layer.
Also fix a trivial typo, bio_iter_iovec.
Cc: Christoph Hellwig <hch@infradead.org>
Cc: Kent Overstreet <kent.overstreet@gmail.com>
Cc: Jonathan Corbet <corbet@lwn.net>
Cc: linux-doc@vger.kernel.org
Signed-off-by: Dongsu Park <dpark@posteo.net>
Signed-off-by: Ming Lin <mlin@kernel.org>
---
Documentation/block/biovecs.txt | 10 +++++++++-
1 file changed, 9 insertions(+), 1 deletion(-)
diff --git a/Documentation/block/biovecs.txt b/Documentation/block/biovecs.txt
index 74a32ad..2568958 100644
--- a/Documentation/block/biovecs.txt
+++ b/Documentation/block/biovecs.txt
@@ -24,7 +24,7 @@ particular, presenting the illusion of partially completed biovecs so that
normal code doesn't have to deal with bi_bvec_done.
* Driver code should no longer refer to biovecs directly; we now have
- bio_iovec() and bio_iovec_iter() macros that return literal struct biovecs,
+ bio_iovec() and bio_iter_iovec() macros that return literal struct biovecs,
constructed from the raw biovecs but taking into account bi_bvec_done and
bi_size.
@@ -109,3 +109,11 @@ Other implications:
over all the biovecs in the new bio - which is silly as it's not needed.
So, don't use bi_vcnt anymore.
+
+ * The current interface allows the block layer to split bios as needed, so we
+ could eliminate a lot of complexity particularly in stacked drivers. Code
+ that creates bios can then create whatever size bios are convenient, and
+ more importantly stacked drivers don't have to deal with both their own bio
+ size limitations and the limitations of the underlying devices. Thus
+ there's no need to define ->merge_bvec_fn() callbacks for individual block
+ drivers.
--
1.9.1
next prev parent reply other threads:[~2015-05-07 6:35 UTC|newest]
Thread overview: 44+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-05-07 6:34 [PATCH v3 00/11] simplify block layer based on immutable biovecs Ming Lin
[not found] ` <1430980461-5235-1-git-send-email-mlin-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
2015-05-07 6:34 ` [PATCH v3 01/11] block: make generic_make_request handle arbitrarily sized bios Ming Lin
2015-05-07 6:34 ` Ming Lin
2015-05-07 6:34 ` [Drbd-dev] " Ming Lin
2015-05-18 16:52 ` Jeff Moyer
2015-05-18 16:52 ` [Drbd-dev] " Jeff Moyer
2015-05-18 17:22 ` Christoph Hellwig
2015-05-18 17:22 ` [Drbd-dev] " Christoph Hellwig
2015-05-22 7:51 ` Ming Lin
2015-05-22 7:51 ` Ming Lin
2015-05-22 7:51 ` [Drbd-dev] " Ming Lin
2015-05-20 18:30 ` Ming Lin
2015-05-20 18:30 ` [Drbd-dev] " Ming Lin
2015-05-20 18:58 ` Jeff Moyer
2015-05-20 18:58 ` [Drbd-dev] " Jeff Moyer
2015-05-20 20:18 ` Ming Lin
2015-05-20 20:18 ` [Drbd-dev] " Ming Lin
2015-05-22 17:49 ` Ming Lin
2015-05-22 17:49 ` [Drbd-dev] " Ming Lin
2015-05-20 12:44 ` Christoph Hellwig
2015-05-20 12:44 ` [Drbd-dev] " Christoph Hellwig
2015-05-20 18:16 ` Ming Lin
2015-05-20 18:16 ` [Drbd-dev] " Ming Lin
2015-05-07 6:34 ` [PATCH v3 02/11] block: simplify bio_add_page() Ming Lin
2015-05-07 6:34 ` [PATCH v3 03/11] block: allow __blk_queue_bounce() to handle bios larger than BIO_MAX_PAGES Ming Lin
2015-05-19 8:44 ` Christoph Hellwig
2015-05-20 18:17 ` Ming Lin
2015-05-07 6:34 ` [PATCH v3 04/11] bcache: remove driver private bio splitting code Ming Lin
2015-05-07 6:34 ` [PATCH v3 05/11] btrfs: remove bio splitting and merge_bvec_fn() calls Ming Lin
2015-05-07 6:34 ` [PATCH v3 06/11] md/raid5: get rid of bio_fits_rdev() Ming Lin
2015-05-07 6:34 ` [PATCH v3 07/11] md/raid5: split bio for chunk_aligned_read Ming Lin
2015-05-08 4:14 ` NeilBrown
2015-05-08 5:57 ` Ming Lin
2015-05-08 5:57 ` Ming Lin
2015-05-07 6:34 ` [PATCH v3 08/11] block: kill merge_bvec_fn() completely Ming Lin
2015-05-07 6:34 ` [Drbd-dev] " Ming Lin
2015-05-07 6:34 ` [PATCH v3 09/11] fs: use helper bio_add_page() instead of open coding on bi_io_vec Ming Lin
2015-05-07 6:34 ` [PATCH v3 10/11] md/raid10: make sync_request_write() call bio_copy_data() Ming Lin
2015-05-19 8:45 ` Christoph Hellwig
2015-05-20 3:09 ` NeilBrown
2015-05-07 6:34 ` Ming Lin [this message]
2015-05-18 16:13 ` [PATCH v3 00/11] simplify block layer based on immutable biovecs Christoph Hellwig
2015-05-20 12:48 ` Christoph Hellwig
2015-05-20 18:10 ` Ming Lin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1430980461-5235-12-git-send-email-mlin@kernel.org \
--to=mlin@kernel.org \
--cc=axboe@kernel.dk \
--cc=corbet@lwn.net \
--cc=dpark@posteo.net \
--cc=hch@infradead.org \
--cc=hch@lst.de \
--cc=kent.overstreet@gmail.com \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.