All of lore.kernel.org
 help / color / mirror / Atom feed
From: Ming Lin <mlin@kernel.org>
To: linux-kernel@vger.kernel.org
Cc: Christoph Hellwig <hch@lst.de>, Jens Axboe <axboe@kernel.dk>,
	Kent Overstreet <kent.overstreet@gmail.com>,
	Dongsu Park <dpark@posteo.net>, Ming Lin <mlin@kernel.org>,
	Neil Brown <neilb@suse.de>,
	linux-raid@vger.kernel.org
Subject: [PATCH v3 06/11] md/raid5: get rid of bio_fits_rdev()
Date: Wed,  6 May 2015 23:34:16 -0700	[thread overview]
Message-ID: <1430980461-5235-7-git-send-email-mlin@kernel.org> (raw)
In-Reply-To: <1430980461-5235-1-git-send-email-mlin@kernel.org>

From: Kent Overstreet <kent.overstreet@gmail.com>

Remove bio_fits_rdev() completely, because ->merge_bvec_fn() has now
gone. There's no point in calling bio_fits_rdev() only for ensuring
aligned read from rdev.

Cc: Neil Brown <neilb@suse.de>
Cc: linux-raid@vger.kernel.org
Signed-off-by: Kent Overstreet <kent.overstreet@gmail.com>
[dpark: add more description in commit message]
Signed-off-by: Dongsu Park <dpark@posteo.net>
Signed-off-by: Ming Lin <mlin@kernel.org>
---
 drivers/md/raid5.c | 23 +----------------------
 1 file changed, 1 insertion(+), 22 deletions(-)

diff --git a/drivers/md/raid5.c b/drivers/md/raid5.c
index 77dfd72..7f4a717 100644
--- a/drivers/md/raid5.c
+++ b/drivers/md/raid5.c
@@ -4738,25 +4738,6 @@ static void raid5_align_endio(struct bio *bi, int error)
 	add_bio_to_retry(raid_bi, conf);
 }
 
-static int bio_fits_rdev(struct bio *bi)
-{
-	struct request_queue *q = bdev_get_queue(bi->bi_bdev);
-
-	if (bio_sectors(bi) > queue_max_sectors(q))
-		return 0;
-	blk_recount_segments(q, bi);
-	if (bi->bi_phys_segments > queue_max_segments(q))
-		return 0;
-
-	if (q->merge_bvec_fn)
-		/* it's too hard to apply the merge_bvec_fn at this stage,
-		 * just just give up
-		 */
-		return 0;
-
-	return 1;
-}
-
 static int chunk_aligned_read(struct mddev *mddev, struct bio * raid_bio)
 {
 	struct r5conf *conf = mddev->private;
@@ -4810,11 +4791,9 @@ static int chunk_aligned_read(struct mddev *mddev, struct bio * raid_bio)
 		align_bi->bi_bdev =  rdev->bdev;
 		__clear_bit(BIO_SEG_VALID, &align_bi->bi_flags);
 
-		if (!bio_fits_rdev(align_bi) ||
-		    is_badblock(rdev, align_bi->bi_iter.bi_sector,
+		if (is_badblock(rdev, align_bi->bi_iter.bi_sector,
 				bio_sectors(align_bi),
 				&first_bad, &bad_sectors)) {
-			/* too big in some way, or has a known bad block */
 			bio_put(align_bi);
 			rdev_dec_pending(rdev, mddev);
 			return 0;
-- 
1.9.1

  parent reply	other threads:[~2015-05-07  6:34 UTC|newest]

Thread overview: 44+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-05-07  6:34 [PATCH v3 00/11] simplify block layer based on immutable biovecs Ming Lin
     [not found] ` <1430980461-5235-1-git-send-email-mlin-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
2015-05-07  6:34   ` [PATCH v3 01/11] block: make generic_make_request handle arbitrarily sized bios Ming Lin
2015-05-07  6:34     ` Ming Lin
2015-05-07  6:34     ` [Drbd-dev] " Ming Lin
2015-05-18 16:52     ` Jeff Moyer
2015-05-18 16:52       ` [Drbd-dev] " Jeff Moyer
2015-05-18 17:22       ` Christoph Hellwig
2015-05-18 17:22         ` [Drbd-dev] " Christoph Hellwig
2015-05-22  7:51         ` Ming Lin
2015-05-22  7:51           ` Ming Lin
2015-05-22  7:51           ` [Drbd-dev] " Ming Lin
2015-05-20 18:30       ` Ming Lin
2015-05-20 18:30         ` [Drbd-dev] " Ming Lin
2015-05-20 18:58         ` Jeff Moyer
2015-05-20 18:58           ` [Drbd-dev] " Jeff Moyer
2015-05-20 20:18           ` Ming Lin
2015-05-20 20:18             ` [Drbd-dev] " Ming Lin
2015-05-22 17:49       ` Ming Lin
2015-05-22 17:49         ` [Drbd-dev] " Ming Lin
2015-05-20 12:44     ` Christoph Hellwig
2015-05-20 12:44       ` [Drbd-dev] " Christoph Hellwig
2015-05-20 18:16       ` Ming Lin
2015-05-20 18:16         ` [Drbd-dev] " Ming Lin
2015-05-07  6:34 ` [PATCH v3 02/11] block: simplify bio_add_page() Ming Lin
2015-05-07  6:34 ` [PATCH v3 03/11] block: allow __blk_queue_bounce() to handle bios larger than BIO_MAX_PAGES Ming Lin
2015-05-19  8:44   ` Christoph Hellwig
2015-05-20 18:17     ` Ming Lin
2015-05-07  6:34 ` [PATCH v3 04/11] bcache: remove driver private bio splitting code Ming Lin
2015-05-07  6:34 ` [PATCH v3 05/11] btrfs: remove bio splitting and merge_bvec_fn() calls Ming Lin
2015-05-07  6:34 ` Ming Lin [this message]
2015-05-07  6:34 ` [PATCH v3 07/11] md/raid5: split bio for chunk_aligned_read Ming Lin
2015-05-08  4:14   ` NeilBrown
2015-05-08  5:57     ` Ming Lin
2015-05-08  5:57       ` Ming Lin
2015-05-07  6:34 ` [PATCH v3 08/11] block: kill merge_bvec_fn() completely Ming Lin
2015-05-07  6:34   ` [Drbd-dev] " Ming Lin
2015-05-07  6:34 ` [PATCH v3 09/11] fs: use helper bio_add_page() instead of open coding on bi_io_vec Ming Lin
2015-05-07  6:34 ` [PATCH v3 10/11] md/raid10: make sync_request_write() call bio_copy_data() Ming Lin
2015-05-19  8:45   ` Christoph Hellwig
2015-05-20  3:09     ` NeilBrown
2015-05-07  6:34 ` [PATCH v3 11/11] Documentation: update notes in biovecs about arbitrarily sized bios Ming Lin
2015-05-18 16:13 ` [PATCH v3 00/11] simplify block layer based on immutable biovecs Christoph Hellwig
2015-05-20 12:48 ` Christoph Hellwig
2015-05-20 18:10   ` Ming Lin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1430980461-5235-7-git-send-email-mlin@kernel.org \
    --to=mlin@kernel.org \
    --cc=axboe@kernel.dk \
    --cc=dpark@posteo.net \
    --cc=hch@lst.de \
    --cc=kent.overstreet@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-raid@vger.kernel.org \
    --cc=neilb@suse.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.