All of lore.kernel.org
 help / color / mirror / Atom feed
From: Christoph Hellwig <hch@lst.de>
To: Ming Lin <mlin@kernel.org>
Cc: linux-kernel@vger.kernel.org, Christoph Hellwig <hch@lst.de>,
	Jens Axboe <axboe@kernel.dk>,
	Kent Overstreet <kent.overstreet@gmail.com>,
	Dongsu Park <dpark@posteo.net>,
	Christoph Hellwig <hch@infradead.org>,
	Al Viro <viro@zeniv.linux.org.uk>,
	Ming Lei <ming.lei@canonical.com>, Neil Brown <neilb@suse.de>,
	Alasdair Kergon <agk@redhat.com>,
	Mike Snitzer <snitzer@redhat.com>,
	dm-devel@redhat.com, Lars Ellenberg <drbd-dev@lists.linbit.com>,
	drbd-user@lists.linbit.com, Jiri Kosina <jkosina@suse.cz>,
	Geoff Levand <geoff@infradead.org>, Jim Paris <jim@jtan.com>,
	Joshua Morris <josh.h.morris@us.ibm.com>,
	Philip Kelleher <pjk1939@linux.vnet.ibm.com>,
	Minchan Kim <minchan@kernel.org>, Nitin Gupta <ngupta@vflare.org>,
	Oleg Drokin <oleg.drokin@intel.com>,
	Andreas Dilger <andreas.dilger@intel.com>
Subject: Re: [PATCH v3 01/11] block: make generic_make_request handle arbitrarily sized bios
Date: Wed, 20 May 2015 14:44:18 +0200	[thread overview]
Message-ID: <20150520124418.GA15594@lst.de> (raw)
In-Reply-To: <1430980461-5235-2-git-send-email-mlin@kernel.org>

This needs the patch below for the blk-mq case with multiple queues.

Also I wonder why we really want to push this below ->make_request.
Moving it just outside ->make_request would make the callchain more
obvious and avoid the recursion into the driver.


diff --git a/block/blk-mq.c b/block/blk-mq.c
index e9bbc04..e7fae76 100644
--- a/block/blk-mq.c
+++ b/block/blk-mq.c
@@ -1256,6 +1256,8 @@ static void blk_mq_make_request(struct request_queue *q, struct bio *bio)
 		return;
 	}
 
+	blk_queue_split(q, &bio, q->bio_split);
+
 	rq = blk_mq_map_request(q, bio, &data);
 	if (unlikely(!rq))
 		return;

WARNING: multiple messages have this Message-ID (diff)
From: Christoph Hellwig <hch@lst.de>
To: Ming Lin <mlin@kernel.org>
Cc: Mike Snitzer <snitzer@redhat.com>, Neil Brown <neilb@suse.de>,
	Ming Lei <ming.lei@canonical.com>,
	dm-devel@redhat.com, Christoph Hellwig <hch@lst.de>,
	Alasdair Kergon <agk@redhat.com>,
	Lars Ellenberg <drbd-dev@lists.linbit.com>,
	Philip Kelleher <pjk1939@linux.vnet.ibm.com>,
	Joshua Morris <josh.h.morris@us.ibm.com>,
	Christoph Hellwig <hch@infradead.org>,
	Kent Overstreet <kent.overstreet@gmail.com>,
	Nitin Gupta <ngupta@vflare.org>,
	Oleg Drokin <oleg.drokin@intel.com>,
	Al Viro <viro@zeniv.linux.org.uk>, Jens Axboe <axboe@kernel.dk>,
	Andreas Dilger <andreas.dilger@intel.com>,
	Geoff Levand <geoff@infradead.org>, Jiri Kosina <jkosina@suse.cz>,
	linux-kernel@vger.kernel.org, Jim Paris <jim@jtan.com>,
	Minchan Kim <minchan@kernel.org>, Dongsu Park <dpark@posteo.net>,
	drbd-user@lists.linbit.com
Subject: Re: [Drbd-dev] [PATCH v3 01/11] block: make generic_make_request handle	arbitrarily sized bios
Date: Wed, 20 May 2015 14:44:18 +0200	[thread overview]
Message-ID: <20150520124418.GA15594@lst.de> (raw)
In-Reply-To: <1430980461-5235-2-git-send-email-mlin@kernel.org>

This needs the patch below for the blk-mq case with multiple queues.

Also I wonder why we really want to push this below ->make_request.
Moving it just outside ->make_request would make the callchain more
obvious and avoid the recursion into the driver.


diff --git a/block/blk-mq.c b/block/blk-mq.c
index e9bbc04..e7fae76 100644
--- a/block/blk-mq.c
+++ b/block/blk-mq.c
@@ -1256,6 +1256,8 @@ static void blk_mq_make_request(struct request_queue *q, struct bio *bio)
 		return;
 	}
 
+	blk_queue_split(q, &bio, q->bio_split);
+
 	rq = blk_mq_map_request(q, bio, &data);
 	if (unlikely(!rq))
 		return;

  parent reply	other threads:[~2015-05-20 12:44 UTC|newest]

Thread overview: 44+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-05-07  6:34 [PATCH v3 00/11] simplify block layer based on immutable biovecs Ming Lin
     [not found] ` <1430980461-5235-1-git-send-email-mlin-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
2015-05-07  6:34   ` [PATCH v3 01/11] block: make generic_make_request handle arbitrarily sized bios Ming Lin
2015-05-07  6:34     ` Ming Lin
2015-05-07  6:34     ` [Drbd-dev] " Ming Lin
2015-05-18 16:52     ` Jeff Moyer
2015-05-18 16:52       ` [Drbd-dev] " Jeff Moyer
2015-05-18 17:22       ` Christoph Hellwig
2015-05-18 17:22         ` [Drbd-dev] " Christoph Hellwig
2015-05-22  7:51         ` Ming Lin
2015-05-22  7:51           ` Ming Lin
2015-05-22  7:51           ` [Drbd-dev] " Ming Lin
2015-05-20 18:30       ` Ming Lin
2015-05-20 18:30         ` [Drbd-dev] " Ming Lin
2015-05-20 18:58         ` Jeff Moyer
2015-05-20 18:58           ` [Drbd-dev] " Jeff Moyer
2015-05-20 20:18           ` Ming Lin
2015-05-20 20:18             ` [Drbd-dev] " Ming Lin
2015-05-22 17:49       ` Ming Lin
2015-05-22 17:49         ` [Drbd-dev] " Ming Lin
2015-05-20 12:44     ` Christoph Hellwig [this message]
2015-05-20 12:44       ` Christoph Hellwig
2015-05-20 18:16       ` Ming Lin
2015-05-20 18:16         ` [Drbd-dev] " Ming Lin
2015-05-07  6:34 ` [PATCH v3 02/11] block: simplify bio_add_page() Ming Lin
2015-05-07  6:34 ` [PATCH v3 03/11] block: allow __blk_queue_bounce() to handle bios larger than BIO_MAX_PAGES Ming Lin
2015-05-19  8:44   ` Christoph Hellwig
2015-05-20 18:17     ` Ming Lin
2015-05-07  6:34 ` [PATCH v3 04/11] bcache: remove driver private bio splitting code Ming Lin
2015-05-07  6:34 ` [PATCH v3 05/11] btrfs: remove bio splitting and merge_bvec_fn() calls Ming Lin
2015-05-07  6:34 ` [PATCH v3 06/11] md/raid5: get rid of bio_fits_rdev() Ming Lin
2015-05-07  6:34 ` [PATCH v3 07/11] md/raid5: split bio for chunk_aligned_read Ming Lin
2015-05-08  4:14   ` NeilBrown
2015-05-08  5:57     ` Ming Lin
2015-05-08  5:57       ` Ming Lin
2015-05-07  6:34 ` [PATCH v3 08/11] block: kill merge_bvec_fn() completely Ming Lin
2015-05-07  6:34   ` [Drbd-dev] " Ming Lin
2015-05-07  6:34 ` [PATCH v3 09/11] fs: use helper bio_add_page() instead of open coding on bi_io_vec Ming Lin
2015-05-07  6:34 ` [PATCH v3 10/11] md/raid10: make sync_request_write() call bio_copy_data() Ming Lin
2015-05-19  8:45   ` Christoph Hellwig
2015-05-20  3:09     ` NeilBrown
2015-05-07  6:34 ` [PATCH v3 11/11] Documentation: update notes in biovecs about arbitrarily sized bios Ming Lin
2015-05-18 16:13 ` [PATCH v3 00/11] simplify block layer based on immutable biovecs Christoph Hellwig
2015-05-20 12:48 ` Christoph Hellwig
2015-05-20 18:10   ` Ming Lin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20150520124418.GA15594@lst.de \
    --to=hch@lst.de \
    --cc=agk@redhat.com \
    --cc=andreas.dilger@intel.com \
    --cc=axboe@kernel.dk \
    --cc=dm-devel@redhat.com \
    --cc=dpark@posteo.net \
    --cc=drbd-dev@lists.linbit.com \
    --cc=drbd-user@lists.linbit.com \
    --cc=geoff@infradead.org \
    --cc=hch@infradead.org \
    --cc=jim@jtan.com \
    --cc=jkosina@suse.cz \
    --cc=josh.h.morris@us.ibm.com \
    --cc=kent.overstreet@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=minchan@kernel.org \
    --cc=ming.lei@canonical.com \
    --cc=mlin@kernel.org \
    --cc=neilb@suse.de \
    --cc=ngupta@vflare.org \
    --cc=oleg.drokin@intel.com \
    --cc=pjk1939@linux.vnet.ibm.com \
    --cc=snitzer@redhat.com \
    --cc=viro@zeniv.linux.org.uk \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.