* [PATCH] tools/libxc: Fix missing break from c/s b49a7517
@ 2015-05-08 20:59 Andrew Cooper
2015-05-09 18:19 ` Julien Grall
0 siblings, 1 reply; 3+ messages in thread
From: Andrew Cooper @ 2015-05-08 20:59 UTC (permalink / raw)
To: Xen-devel; +Cc: Julien Grall, Andrew Cooper, Ian Jackson, Ian Campbell, Wei Liu
Signed-off-by: Andrew Cooper <andrew.cooper3@citrix.com>
CC: Ian Campbell <Ian.Campbell@citrix.com>
CC: Ian Jackson <Ian.Jackson@eu.citrix.com>
CC: Wei Liu <wei.liu2@citrix.com>
CC: Julien Grall <julien.grall@citrix.com>
---
tools/libxc/xc_domain.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/tools/libxc/xc_domain.c b/tools/libxc/xc_domain.c
index 273e1fd..a7079a1 100644
--- a/tools/libxc/xc_domain.c
+++ b/tools/libxc/xc_domain.c
@@ -1978,6 +1978,7 @@ static int xc_domain_unbind_pt_irq_int(
break;
case PT_IRQ_TYPE_SPI:
bind->u.spi.spi = spi;
+ break;
default:
errno = EINVAL;
return -1;
--
1.7.10.4
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] tools/libxc: Fix missing break from c/s b49a7517
2015-05-08 20:59 [PATCH] tools/libxc: Fix missing break from c/s b49a7517 Andrew Cooper
@ 2015-05-09 18:19 ` Julien Grall
2015-05-11 10:48 ` Ian Campbell
0 siblings, 1 reply; 3+ messages in thread
From: Julien Grall @ 2015-05-09 18:19 UTC (permalink / raw)
To: Andrew Cooper, Xen-devel; +Cc: Julien Grall, Wei Liu, Ian Jackson, Ian Campbell
Hi Andrew,
On 08/05/2015 21:59, Andrew Cooper wrote:
> Signed-off-by: Andrew Cooper <andrew.cooper3@citrix.com>
> CC: Ian Campbell <Ian.Campbell@citrix.com>
> CC: Ian Jackson <Ian.Jackson@eu.citrix.com>
> CC: Wei Liu <wei.liu2@citrix.com>
> CC: Julien Grall <julien.grall@citrix.com>
> ---
> tools/libxc/xc_domain.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/tools/libxc/xc_domain.c b/tools/libxc/xc_domain.c
> index 273e1fd..a7079a1 100644
> --- a/tools/libxc/xc_domain.c
> +++ b/tools/libxc/xc_domain.c
> @@ -1978,6 +1978,7 @@ static int xc_domain_unbind_pt_irq_int(
> break;
> case PT_IRQ_TYPE_SPI:
> bind->u.spi.spi = spi;
> + break;
Sorry, I haven't spot this one because I didn't exercise this code path.
I did the same mistake in xc_domain_bint_pt_irq_int which I fixed during
testing.
Reviewed-by: Julien Grall <julien.grall@citrix.com>
Regards,
--
Julien Grall
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] tools/libxc: Fix missing break from c/s b49a7517
2015-05-09 18:19 ` Julien Grall
@ 2015-05-11 10:48 ` Ian Campbell
0 siblings, 0 replies; 3+ messages in thread
From: Ian Campbell @ 2015-05-11 10:48 UTC (permalink / raw)
To: Julien Grall; +Cc: Andrew Cooper, Ian Jackson, Wei Liu, Xen-devel
On Sat, 2015-05-09 at 19:19 +0100, Julien Grall wrote:
> Hi Andrew,
>
> On 08/05/2015 21:59, Andrew Cooper wrote:
> > Signed-off-by: Andrew Cooper <andrew.cooper3@citrix.com>
> > CC: Ian Campbell <Ian.Campbell@citrix.com>
> > CC: Ian Jackson <Ian.Jackson@eu.citrix.com>
> > CC: Wei Liu <wei.liu2@citrix.com>
> > CC: Julien Grall <julien.grall@citrix.com>
> > ---
> > tools/libxc/xc_domain.c | 1 +
> > 1 file changed, 1 insertion(+)
> >
> > diff --git a/tools/libxc/xc_domain.c b/tools/libxc/xc_domain.c
> > index 273e1fd..a7079a1 100644
> > --- a/tools/libxc/xc_domain.c
> > +++ b/tools/libxc/xc_domain.c
> > @@ -1978,6 +1978,7 @@ static int xc_domain_unbind_pt_irq_int(
> > break;
> > case PT_IRQ_TYPE_SPI:
> > bind->u.spi.spi = spi;
> > + break;
>
> Sorry, I haven't spot this one because I didn't exercise this code path.
>
> I did the same mistake in xc_domain_bint_pt_irq_int which I fixed during
> testing.
>
> Reviewed-by: Julien Grall <julien.grall@citrix.com>
Acked + applied, thanks.
Ian.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2015-05-11 10:48 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-05-08 20:59 [PATCH] tools/libxc: Fix missing break from c/s b49a7517 Andrew Cooper
2015-05-09 18:19 ` Julien Grall
2015-05-11 10:48 ` Ian Campbell
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.