From: pebolle@tiscali.nl (Paul Bolle)
To: linux-arm-kernel@lists.infradead.org
Subject: [RFC PATCH 1/5] livepatch: ftrace: arm64: Add support for DYNAMIC_FTRACE_WITH_REGS
Date: Fri, 29 May 2015 09:14:49 +0200 [thread overview]
Message-ID: <1432883689.3551.3.camel@x220> (raw)
In-Reply-To: <1432792265-24076-2-git-send-email-huawei.libin@huawei.com>
On Thu, 2015-05-28 at 13:51 +0800, Li Bin wrote:
> --- a/arch/arm64/Kconfig
> +++ b/arch/arm64/Kconfig
> select HAVE_DYNAMIC_FTRACE
> + select HAVE_DYNAMIC_FTRACE_WITH_REGS if HAVE_DYNAMIC_FTRACE
What's the point of "if HAVE_DYNAMIC_FTRACE" here? That test should
always evaluate to true, because HAVE_DYNAMIC_FTRACE is also selected.
Paul Bolle
WARNING: multiple messages have this Message-ID (diff)
From: Paul Bolle <pebolle@tiscali.nl>
To: Li Bin <huawei.libin@huawei.com>
Cc: rostedt@goodmis.org, mingo@kernel.org, jpoimboe@redhat.com,
sjenning@redhat.com, jkosina@suse.cz, vojtech@suse.cz,
catalin.marinas@arm.com, will.deacon@arm.com,
masami.hiramatsu.pt@hitachi.com, live-patching@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, lizefan@huawei.com,
felix.yang@huawei.com, guohanjun@huawei.com, xiexiuqi@huawei.com
Subject: Re: [RFC PATCH 1/5] livepatch: ftrace: arm64: Add support for DYNAMIC_FTRACE_WITH_REGS
Date: Fri, 29 May 2015 09:14:49 +0200 [thread overview]
Message-ID: <1432883689.3551.3.camel@x220> (raw)
In-Reply-To: <1432792265-24076-2-git-send-email-huawei.libin@huawei.com>
On Thu, 2015-05-28 at 13:51 +0800, Li Bin wrote:
> --- a/arch/arm64/Kconfig
> +++ b/arch/arm64/Kconfig
> select HAVE_DYNAMIC_FTRACE
> + select HAVE_DYNAMIC_FTRACE_WITH_REGS if HAVE_DYNAMIC_FTRACE
What's the point of "if HAVE_DYNAMIC_FTRACE" here? That test should
always evaluate to true, because HAVE_DYNAMIC_FTRACE is also selected.
Paul Bolle
next prev parent reply other threads:[~2015-05-29 7:14 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-05-28 5:51 [RFC PATCH 0/5] livepatch: add support on arm64 Li Bin
2015-05-28 5:51 ` Li Bin
2015-05-28 5:51 ` [RFC PATCH 1/5] livepatch: ftrace: arm64: Add support for DYNAMIC_FTRACE_WITH_REGS Li Bin
2015-05-28 5:51 ` Li Bin
2015-05-29 7:14 ` Paul Bolle [this message]
2015-05-29 7:14 ` Paul Bolle
2015-05-29 8:01 ` Li Bin
2015-05-29 8:01 ` Li Bin
2015-05-28 5:51 ` [RFC PATCH 2/5] livepatch: ftrace: add ftrace_function_stub_ip function Li Bin
2015-05-28 5:51 ` Li Bin
2015-05-28 5:51 ` [RFC PATCH 3/5] livepatch: ftrace: arm64: Add support for -mfentry on arm64 Li Bin
2015-05-28 5:51 ` Li Bin
2015-05-28 5:51 ` [RFC PATCH 4/5] livepatch: arm64: add support for livepatch " Li Bin
2015-05-28 5:51 ` Li Bin
2015-05-28 5:51 ` [RFC PATCH 5/5] livepatch: arm64: support relocation in a module Li Bin
2015-05-28 5:51 ` Li Bin
2015-05-29 11:52 ` [RFC PATCH 0/5] livepatch: add support on arm64 Jiri Kosina
2015-05-29 11:52 ` Jiri Kosina
2015-05-30 0:01 ` Masami Hiramatsu
2015-05-30 0:01 ` Masami Hiramatsu
2015-06-02 2:15 ` AKASHI Takahiro
2015-06-02 2:15 ` AKASHI Takahiro
2015-06-02 11:00 ` Li Bin
2015-06-02 11:00 ` Li Bin
2015-06-02 21:04 ` Masami Hiramatsu
2015-06-02 21:04 ` Masami Hiramatsu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1432883689.3551.3.camel@x220 \
--to=pebolle@tiscali.nl \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.