From: joe@perches.com (Joe Perches)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] fixup! dmaengine: pxa_dma: add debug information
Date: Fri, 29 May 2015 02:51:13 -0700 [thread overview]
Message-ID: <1432893073.29807.15.camel@perches.com> (raw)
In-Reply-To: <1617548760.717381111.1432891749082.JavaMail.root@zimbra1-e1.priv.proxad.net>
On Fri, 2015-05-29 at 11:29 +0200, robert.jarzmik at free.fr wrote:
> ----- Mail original -----
> De: "Vinod Koul" <vinod.koul@intel.com>
> On Wed, May 27, 2015 at 11:23:40PM +0200, Robert Jarzmik wrote:
> > This fixes the following error:
[]
> And with a a bit closer look check this commit, especially the date :
> commit 0bac33653b06a5f80a5c04e275eb33db9493b85a
> Author: Joe Perches <joe@perches.com>
> Date: Sat May 23 12:00:38 2015 +1000
>
> fs/seq_file: convert int seq_vprint/seq_printf/etc... returns to void
Hello Robert.
The return value of that dbg_show_requester_chan function
was incorrect and the increment of pos was an example of
why the seq_printf return value was changed to void.
It was a pretty common error and easy to understand given
the expectation that seq_printf should work like printf.
It's a pity it bit you. but this type of patch collision
should be a bit more difficult to reoccur in the future.
cheers, Joe
WARNING: multiple messages have this Message-ID (diff)
From: Joe Perches <joe@perches.com>
To: robert.jarzmik@free.fr
Cc: Vinod Koul <vinod.koul@intel.com>,
Daniel Mack <daniel@zonque.org>,
Haojian Zhuang <haojian.zhuang@gmail.com>,
linux-arm-kernel@lists.infradead.org, dmaengine@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] fixup! dmaengine: pxa_dma: add debug information
Date: Fri, 29 May 2015 02:51:13 -0700 [thread overview]
Message-ID: <1432893073.29807.15.camel@perches.com> (raw)
In-Reply-To: <1617548760.717381111.1432891749082.JavaMail.root@zimbra1-e1.priv.proxad.net>
On Fri, 2015-05-29 at 11:29 +0200, robert.jarzmik@free.fr wrote:
> ----- Mail original -----
> De: "Vinod Koul" <vinod.koul@intel.com>
> On Wed, May 27, 2015 at 11:23:40PM +0200, Robert Jarzmik wrote:
> > This fixes the following error:
[]
> And with a a bit closer look check this commit, especially the date :
> commit 0bac33653b06a5f80a5c04e275eb33db9493b85a
> Author: Joe Perches <joe@perches.com>
> Date: Sat May 23 12:00:38 2015 +1000
>
> fs/seq_file: convert int seq_vprint/seq_printf/etc... returns to void
Hello Robert.
The return value of that dbg_show_requester_chan function
was incorrect and the increment of pos was an example of
why the seq_printf return value was changed to void.
It was a pretty common error and easy to understand given
the expectation that seq_printf should work like printf.
It's a pity it bit you. but this type of patch collision
should be a bit more difficult to reoccur in the future.
cheers, Joe
next prev parent reply other threads:[~2015-05-29 9:51 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-05-27 21:23 [PATCH] fixup! dmaengine: pxa_dma: add debug information Robert Jarzmik
2015-05-27 21:23 ` Robert Jarzmik
2015-05-28 8:44 ` Arnd Bergmann
2015-05-28 8:44 ` Arnd Bergmann
2015-05-29 9:13 ` Vinod Koul
2015-05-29 9:13 ` Vinod Koul
2015-05-29 9:29 ` robert.jarzmik at free.fr
2015-05-29 9:29 ` robert.jarzmik
2015-05-29 9:51 ` Joe Perches [this message]
2015-05-29 9:51 ` Joe Perches
2015-06-01 21:31 ` Robert Jarzmik
2015-06-01 21:31 ` Robert Jarzmik
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1432893073.29807.15.camel@perches.com \
--to=joe@perches.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.