From: robert.jarzmik@free.fr (Robert Jarzmik)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] fixup! dmaengine: pxa_dma: add debug information
Date: Mon, 01 Jun 2015 23:31:48 +0200 [thread overview]
Message-ID: <87382bt8sb.fsf@belgarion.home> (raw)
In-Reply-To: <1432893073.29807.15.camel@perches.com> (Joe Perches's message of "Fri, 29 May 2015 02:51:13 -0700")
Joe Perches <joe@perches.com> writes:
> Hello Robert.
>
> The return value of that dbg_show_requester_chan function
> was incorrect and the increment of pos was an example of
> why the seq_printf return value was changed to void.
>
> It was a pretty common error and easy to understand given
> the expectation that seq_printf should work like printf.
Sure.
> It's a pity it bit you. but this type of patch collision
> should be a bit more difficult to reoccur in the future.
I got what I deserved. I knew it was coming, I've seen it in other drivers of
mine, but my left brain didn't tell the other half to crosscheck in this
patch. Anyway, it's not a big fixup, so everything is fine now.
Cheers.
--
Robert
WARNING: multiple messages have this Message-ID (diff)
From: Robert Jarzmik <robert.jarzmik@free.fr>
To: Joe Perches <joe@perches.com>
Cc: Vinod Koul <vinod.koul@intel.com>,
Daniel Mack <daniel@zonque.org>,
Haojian Zhuang <haojian.zhuang@gmail.com>,
linux-arm-kernel@lists.infradead.org, dmaengine@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] fixup! dmaengine: pxa_dma: add debug information
Date: Mon, 01 Jun 2015 23:31:48 +0200 [thread overview]
Message-ID: <87382bt8sb.fsf@belgarion.home> (raw)
In-Reply-To: <1432893073.29807.15.camel@perches.com> (Joe Perches's message of "Fri, 29 May 2015 02:51:13 -0700")
Joe Perches <joe@perches.com> writes:
> Hello Robert.
>
> The return value of that dbg_show_requester_chan function
> was incorrect and the increment of pos was an example of
> why the seq_printf return value was changed to void.
>
> It was a pretty common error and easy to understand given
> the expectation that seq_printf should work like printf.
Sure.
> It's a pity it bit you. but this type of patch collision
> should be a bit more difficult to reoccur in the future.
I got what I deserved. I knew it was coming, I've seen it in other drivers of
mine, but my left brain didn't tell the other half to crosscheck in this
patch. Anyway, it's not a big fixup, so everything is fine now.
Cheers.
--
Robert
next prev parent reply other threads:[~2015-06-01 21:31 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-05-27 21:23 [PATCH] fixup! dmaengine: pxa_dma: add debug information Robert Jarzmik
2015-05-27 21:23 ` Robert Jarzmik
2015-05-28 8:44 ` Arnd Bergmann
2015-05-28 8:44 ` Arnd Bergmann
2015-05-29 9:13 ` Vinod Koul
2015-05-29 9:13 ` Vinod Koul
2015-05-29 9:29 ` robert.jarzmik at free.fr
2015-05-29 9:29 ` robert.jarzmik
2015-05-29 9:51 ` Joe Perches
2015-05-29 9:51 ` Joe Perches
2015-06-01 21:31 ` Robert Jarzmik [this message]
2015-06-01 21:31 ` Robert Jarzmik
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87382bt8sb.fsf@belgarion.home \
--to=robert.jarzmik@free.fr \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.