* [PATCHv2 1/2] ARM: exynos_defconfig: Enable CONFIG_SND_SOC_ODROIDX2 for Odroid-XU3 @ 2015-06-07 17:03 ` Anand Moon 0 siblings, 0 replies; 20+ messages in thread From: Anand Moon @ 2015-06-07 17:03 UTC (permalink / raw) To: Russell King, Kukjin Kim, Krzysztof Kozlowski, Javier Martinez Canillas, Anand Moon, Lukasz Majewski, Andreas Faerber, Sachin Kamat, Sjoerd Simons Cc: linux-arm-kernel, linux-samsung-soc, linux-kernel Enable CONFIG_SND_SOC_ODROIDX2 and CONFIG_SND_SIMPLE_CARD to enable sound on Odroid-XU3 board. Below is the output of boot log. [ 6.021550] max98090 5-0010: MAX98090 REVID=0x43 [ 6.025506] random: nonblocking pool is initialized [ 6.047297] asoc-simple-card sound: HiFi <-> 3830000.i2s mapping ok [ 6.068392] s5m-rtc s2mps14-rtc: setting system clock to 2015-06-07 12:51:06 UTC (1433681466) [ 6.123650] ALSA device list: [ 6.135203] #0: Odroid-XU3 Signed-off-by: Anand Moon <linux.amoon@gmail.com> --- arch/arm/configs/exynos_defconfig | 2 ++ 1 file changed, 2 insertions(+) diff --git a/arch/arm/configs/exynos_defconfig b/arch/arm/configs/exynos_defconfig index 9504e77..1b7253b 100644 --- a/arch/arm/configs/exynos_defconfig +++ b/arch/arm/configs/exynos_defconfig @@ -144,6 +144,8 @@ CONFIG_SND=y CONFIG_SND_SOC=y CONFIG_SND_SOC_SAMSUNG=y CONFIG_SND_SOC_SNOW=y +CONFIG_SND_SOC_ODROIDX2=y +CONFIG_SND_SIMPLE_CARD=y CONFIG_USB=y CONFIG_USB_ANNOUNCE_NEW_DEVICES=y CONFIG_USB_XHCI_HCD=y -- 2.4.3 ^ permalink raw reply related [flat|nested] 20+ messages in thread
* [PATCHv2 1/2] ARM: exynos_defconfig: Enable CONFIG_SND_SOC_ODROIDX2 for Odroid-XU3 @ 2015-06-07 17:03 ` Anand Moon 0 siblings, 0 replies; 20+ messages in thread From: Anand Moon @ 2015-06-07 17:03 UTC (permalink / raw) To: linux-arm-kernel Enable CONFIG_SND_SOC_ODROIDX2 and CONFIG_SND_SIMPLE_CARD to enable sound on Odroid-XU3 board. Below is the output of boot log. [ 6.021550] max98090 5-0010: MAX98090 REVID=0x43 [ 6.025506] random: nonblocking pool is initialized [ 6.047297] asoc-simple-card sound: HiFi <-> 3830000.i2s mapping ok [ 6.068392] s5m-rtc s2mps14-rtc: setting system clock to 2015-06-07 12:51:06 UTC (1433681466) [ 6.123650] ALSA device list: [ 6.135203] #0: Odroid-XU3 Signed-off-by: Anand Moon <linux.amoon@gmail.com> --- arch/arm/configs/exynos_defconfig | 2 ++ 1 file changed, 2 insertions(+) diff --git a/arch/arm/configs/exynos_defconfig b/arch/arm/configs/exynos_defconfig index 9504e77..1b7253b 100644 --- a/arch/arm/configs/exynos_defconfig +++ b/arch/arm/configs/exynos_defconfig @@ -144,6 +144,8 @@ CONFIG_SND=y CONFIG_SND_SOC=y CONFIG_SND_SOC_SAMSUNG=y CONFIG_SND_SOC_SNOW=y +CONFIG_SND_SOC_ODROIDX2=y +CONFIG_SND_SIMPLE_CARD=y CONFIG_USB=y CONFIG_USB_ANNOUNCE_NEW_DEVICES=y CONFIG_USB_XHCI_HCD=y -- 2.4.3 ^ permalink raw reply related [flat|nested] 20+ messages in thread
* [PATCHv2 2/2] ARM: exynos_defconfig: Enable CONFIG_LEDS_PWM for Odroid-XU3 2015-06-07 17:03 ` Anand Moon @ 2015-06-07 17:03 ` Anand Moon -1 siblings, 0 replies; 20+ messages in thread From: Anand Moon @ 2015-06-07 17:03 UTC (permalink / raw) To: Russell King, Kukjin Kim, Krzysztof Kozlowski, Javier Martinez Canillas, Anand Moon, Lukasz Majewski, Andreas Faerber, Sachin Kamat, Sjoerd Simons Cc: linux-arm-kernel, linux-samsung-soc, linux-kernel Enable CONFIG_LEDS_PWM amd CONFIG_LEDS_TRIGGER_HEARTBEAT for Odroid-XU3 board. Signed-off-by: Anand Moon <linux.amoon@gmail.com> --- arch/arm/configs/exynos_defconfig | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/arch/arm/configs/exynos_defconfig b/arch/arm/configs/exynos_defconfig index 1b7253b..2bbdf80 100644 --- a/arch/arm/configs/exynos_defconfig +++ b/arch/arm/configs/exynos_defconfig @@ -165,6 +165,12 @@ CONFIG_MMC_SDHCI_S3C_DMA=y CONFIG_MMC_DW=y CONFIG_MMC_DW_IDMAC=y CONFIG_MMC_DW_EXYNOS=y +CONFIG_NEW_LEDS=y +CONFIG_LEDS_CLASS=m +CONFIG_LEDS_PWM=m +CONFIG_LEDS_TRIGGERS=y +CONFIG_LEDS_TRIGGER_TIMER=m +CONFIG_LEDS_TRIGGER_HEARTBEAT=m CONFIG_RTC_CLASS=y CONFIG_RTC_DRV_MAX77686=y CONFIG_RTC_DRV_MAX77802=y -- 2.4.3 ^ permalink raw reply related [flat|nested] 20+ messages in thread
* [PATCHv2 2/2] ARM: exynos_defconfig: Enable CONFIG_LEDS_PWM for Odroid-XU3 @ 2015-06-07 17:03 ` Anand Moon 0 siblings, 0 replies; 20+ messages in thread From: Anand Moon @ 2015-06-07 17:03 UTC (permalink / raw) To: linux-arm-kernel Enable CONFIG_LEDS_PWM amd CONFIG_LEDS_TRIGGER_HEARTBEAT for Odroid-XU3 board. Signed-off-by: Anand Moon <linux.amoon@gmail.com> --- arch/arm/configs/exynos_defconfig | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/arch/arm/configs/exynos_defconfig b/arch/arm/configs/exynos_defconfig index 1b7253b..2bbdf80 100644 --- a/arch/arm/configs/exynos_defconfig +++ b/arch/arm/configs/exynos_defconfig @@ -165,6 +165,12 @@ CONFIG_MMC_SDHCI_S3C_DMA=y CONFIG_MMC_DW=y CONFIG_MMC_DW_IDMAC=y CONFIG_MMC_DW_EXYNOS=y +CONFIG_NEW_LEDS=y +CONFIG_LEDS_CLASS=m +CONFIG_LEDS_PWM=m +CONFIG_LEDS_TRIGGERS=y +CONFIG_LEDS_TRIGGER_TIMER=m +CONFIG_LEDS_TRIGGER_HEARTBEAT=m CONFIG_RTC_CLASS=y CONFIG_RTC_DRV_MAX77686=y CONFIG_RTC_DRV_MAX77802=y -- 2.4.3 ^ permalink raw reply related [flat|nested] 20+ messages in thread
* Re: [PATCHv2 2/2] ARM: exynos_defconfig: Enable CONFIG_LEDS_PWM for Odroid-XU3 2015-06-07 17:03 ` Anand Moon @ 2015-06-08 15:11 ` Lukasz Majewski -1 siblings, 0 replies; 20+ messages in thread From: Lukasz Majewski @ 2015-06-08 15:11 UTC (permalink / raw) To: Anand Moon Cc: Russell King, Kukjin Kim, Krzysztof Kozlowski, Javier Martinez Canillas, Andreas Faerber, Sachin Kamat, Sjoerd Simons, linux-arm-kernel, linux-samsung-soc, linux-kernel Hi Anand, > Enable CONFIG_LEDS_PWM amd CONFIG_LEDS_TRIGGER_HEARTBEAT for > Odroid-XU3 board. > > Signed-off-by: Anand Moon <linux.amoon@gmail.com> > --- > arch/arm/configs/exynos_defconfig | 6 ++++++ > 1 file changed, 6 insertions(+) > > diff --git a/arch/arm/configs/exynos_defconfig > b/arch/arm/configs/exynos_defconfig index 1b7253b..2bbdf80 100644 > --- a/arch/arm/configs/exynos_defconfig > +++ b/arch/arm/configs/exynos_defconfig > @@ -165,6 +165,12 @@ CONFIG_MMC_SDHCI_S3C_DMA=y > CONFIG_MMC_DW=y > CONFIG_MMC_DW_IDMAC=y > CONFIG_MMC_DW_EXYNOS=y > +CONFIG_NEW_LEDS=y > +CONFIG_LEDS_CLASS=m > +CONFIG_LEDS_PWM=m > +CONFIG_LEDS_TRIGGERS=y > +CONFIG_LEDS_TRIGGER_TIMER=m > +CONFIG_LEDS_TRIGGER_HEARTBEAT=m > CONFIG_RTC_CLASS=y > CONFIG_RTC_DRV_MAX77686=y > CONFIG_RTC_DRV_MAX77802=y Reviewed-by: Lukasz Majewski <l.majewski@samsung.com> -- Best regards, Lukasz Majewski Samsung R&D Institute Poland (SRPOL) | Linux Platform Group ^ permalink raw reply [flat|nested] 20+ messages in thread
* [PATCHv2 2/2] ARM: exynos_defconfig: Enable CONFIG_LEDS_PWM for Odroid-XU3 @ 2015-06-08 15:11 ` Lukasz Majewski 0 siblings, 0 replies; 20+ messages in thread From: Lukasz Majewski @ 2015-06-08 15:11 UTC (permalink / raw) To: linux-arm-kernel Hi Anand, > Enable CONFIG_LEDS_PWM amd CONFIG_LEDS_TRIGGER_HEARTBEAT for > Odroid-XU3 board. > > Signed-off-by: Anand Moon <linux.amoon@gmail.com> > --- > arch/arm/configs/exynos_defconfig | 6 ++++++ > 1 file changed, 6 insertions(+) > > diff --git a/arch/arm/configs/exynos_defconfig > b/arch/arm/configs/exynos_defconfig index 1b7253b..2bbdf80 100644 > --- a/arch/arm/configs/exynos_defconfig > +++ b/arch/arm/configs/exynos_defconfig > @@ -165,6 +165,12 @@ CONFIG_MMC_SDHCI_S3C_DMA=y > CONFIG_MMC_DW=y > CONFIG_MMC_DW_IDMAC=y > CONFIG_MMC_DW_EXYNOS=y > +CONFIG_NEW_LEDS=y > +CONFIG_LEDS_CLASS=m > +CONFIG_LEDS_PWM=m > +CONFIG_LEDS_TRIGGERS=y > +CONFIG_LEDS_TRIGGER_TIMER=m > +CONFIG_LEDS_TRIGGER_HEARTBEAT=m > CONFIG_RTC_CLASS=y > CONFIG_RTC_DRV_MAX77686=y > CONFIG_RTC_DRV_MAX77802=y Reviewed-by: Lukasz Majewski <l.majewski@samsung.com> -- Best regards, Lukasz Majewski Samsung R&D Institute Poland (SRPOL) | Linux Platform Group ^ permalink raw reply [flat|nested] 20+ messages in thread
* Re: [PATCHv2 2/2] ARM: exynos_defconfig: Enable CONFIG_LEDS_PWM for Odroid-XU3 2015-06-07 17:03 ` Anand Moon @ 2015-06-08 23:56 ` Krzysztof Kozlowski -1 siblings, 0 replies; 20+ messages in thread From: Krzysztof Kozlowski @ 2015-06-08 23:56 UTC (permalink / raw) To: Anand Moon, Russell King, Kukjin Kim, Javier Martinez Canillas, Lukasz Majewski, Andreas Faerber, Sachin Kamat, Sjoerd Simons Cc: linux-arm-kernel, linux-samsung-soc, linux-kernel On 08.06.2015 02:03, Anand Moon wrote: > Enable CONFIG_LEDS_PWM amd CONFIG_LEDS_TRIGGER_HEARTBEAT for > Odroid-XU3 board. I am a little confused. This is v2. I found version 3, a little different: http://www.spinics.net/lists/linux-samsung-soc/msg44406.html (which Where is the changelog? Which one is newer? Should we drop the v3? While at it, can you add information WHY do you want to enable LEDS? Best regards, Krzysztof ^ permalink raw reply [flat|nested] 20+ messages in thread
* [PATCHv2 2/2] ARM: exynos_defconfig: Enable CONFIG_LEDS_PWM for Odroid-XU3 @ 2015-06-08 23:56 ` Krzysztof Kozlowski 0 siblings, 0 replies; 20+ messages in thread From: Krzysztof Kozlowski @ 2015-06-08 23:56 UTC (permalink / raw) To: linux-arm-kernel On 08.06.2015 02:03, Anand Moon wrote: > Enable CONFIG_LEDS_PWM amd CONFIG_LEDS_TRIGGER_HEARTBEAT for > Odroid-XU3 board. I am a little confused. This is v2. I found version 3, a little different: http://www.spinics.net/lists/linux-samsung-soc/msg44406.html (which Where is the changelog? Which one is newer? Should we drop the v3? While at it, can you add information WHY do you want to enable LEDS? Best regards, Krzysztof ^ permalink raw reply [flat|nested] 20+ messages in thread
* Re: [PATCHv2 2/2] ARM: exynos_defconfig: Enable CONFIG_LEDS_PWM for Odroid-XU3 2015-06-08 23:56 ` Krzysztof Kozlowski @ 2015-06-09 3:08 ` Anand Moon -1 siblings, 0 replies; 20+ messages in thread From: Anand Moon @ 2015-06-09 3:08 UTC (permalink / raw) To: Krzysztof Kozlowski Cc: Russell King, Kukjin Kim, Javier Martinez Canillas, Lukasz Majewski, Andreas Faerber, Sachin Kamat, Sjoerd Simons, linux-arm-kernel, linux-samsung-soc@vger.kernel.org, Linux Kernel Hi On 9 June 2015 at 05:26, Krzysztof Kozlowski <k.kozlowski@samsung.com> wrote: > On 08.06.2015 02:03, Anand Moon wrote: >> Enable CONFIG_LEDS_PWM amd CONFIG_LEDS_TRIGGER_HEARTBEAT for >> Odroid-XU3 board. > > I am a little confused. > > This is v2. > > I found version 3, a little different: > http://www.spinics.net/lists/linux-samsung-soc/msg44406.html > (which > > Where is the changelog? Which one is newer? Should we drop the v3? > While at it, can you add information WHY do you want to enable LEDS? > > Best regards, > Krzysztof > Look like I an doom to make mistake. With the introduction of this http://www.spinics.net/lists/linux-samsung-soc/msg44481.html We need to enable CONFIG_LEDS_PWM to make it working. So please drop the v3 patch. -Anand Moon ^ permalink raw reply [flat|nested] 20+ messages in thread
* [PATCHv2 2/2] ARM: exynos_defconfig: Enable CONFIG_LEDS_PWM for Odroid-XU3 @ 2015-06-09 3:08 ` Anand Moon 0 siblings, 0 replies; 20+ messages in thread From: Anand Moon @ 2015-06-09 3:08 UTC (permalink / raw) To: linux-arm-kernel Hi On 9 June 2015 at 05:26, Krzysztof Kozlowski <k.kozlowski@samsung.com> wrote: > On 08.06.2015 02:03, Anand Moon wrote: >> Enable CONFIG_LEDS_PWM amd CONFIG_LEDS_TRIGGER_HEARTBEAT for >> Odroid-XU3 board. > > I am a little confused. > > This is v2. > > I found version 3, a little different: > http://www.spinics.net/lists/linux-samsung-soc/msg44406.html > (which > > Where is the changelog? Which one is newer? Should we drop the v3? > While at it, can you add information WHY do you want to enable LEDS? > > Best regards, > Krzysztof > Look like I an doom to make mistake. With the introduction of this http://www.spinics.net/lists/linux-samsung-soc/msg44481.html We need to enable CONFIG_LEDS_PWM to make it working. So please drop the v3 patch. -Anand Moon ^ permalink raw reply [flat|nested] 20+ messages in thread
* Re: [PATCHv2 2/2] ARM: exynos_defconfig: Enable CONFIG_LEDS_PWM for Odroid-XU3 2015-06-07 17:03 ` Anand Moon @ 2015-09-02 14:12 ` Krzysztof Kozlowski -1 siblings, 0 replies; 20+ messages in thread From: Krzysztof Kozlowski @ 2015-09-02 14:12 UTC (permalink / raw) To: Anand Moon, Javier Martinez Canillas, Lukasz Majewski, Andreas Faerber, Sachin Kamat, Sjoerd Simons Cc: Russell King, Kukjin Kim, linux-samsung-soc, linux-kernel, linux-arm-kernel W dniu 08.06.2015 o 02:03, Anand Moon pisze: > Enable CONFIG_LEDS_PWM amd CONFIG_LEDS_TRIGGER_HEARTBEAT for > Odroid-XU3 board. > > Signed-off-by: Anand Moon <linux.amoon@gmail.com> Dear Anand, There was some confusion for this patch (mixed v3 and v2) so overall it slipped through fingers. Can you please: 1. Rebase and resend. 2. Enable them as built-ins, not modules. For exynos_defconfig everything is built-in which makes easier to test on various boards. 3. Enable LEDS_GPIO. I don't know why it disappeared... Best regards, Krzysztof > --- > arch/arm/configs/exynos_defconfig | 6 ++++++ > 1 file changed, 6 insertions(+) > > diff --git a/arch/arm/configs/exynos_defconfig b/arch/arm/configs/exynos_defconfig > index 1b7253b..2bbdf80 100644 > --- a/arch/arm/configs/exynos_defconfig > +++ b/arch/arm/configs/exynos_defconfig > @@ -165,6 +165,12 @@ CONFIG_MMC_SDHCI_S3C_DMA=y > CONFIG_MMC_DW=y > CONFIG_MMC_DW_IDMAC=y > CONFIG_MMC_DW_EXYNOS=y > +CONFIG_NEW_LEDS=y > +CONFIG_LEDS_CLASS=m > +CONFIG_LEDS_PWM=m > +CONFIG_LEDS_TRIGGERS=y > +CONFIG_LEDS_TRIGGER_TIMER=m > +CONFIG_LEDS_TRIGGER_HEARTBEAT=m > CONFIG_RTC_CLASS=y > CONFIG_RTC_DRV_MAX77686=y > CONFIG_RTC_DRV_MAX77802=y > ^ permalink raw reply [flat|nested] 20+ messages in thread
* [PATCHv2 2/2] ARM: exynos_defconfig: Enable CONFIG_LEDS_PWM for Odroid-XU3 @ 2015-09-02 14:12 ` Krzysztof Kozlowski 0 siblings, 0 replies; 20+ messages in thread From: Krzysztof Kozlowski @ 2015-09-02 14:12 UTC (permalink / raw) To: linux-arm-kernel W dniu 08.06.2015 o 02:03, Anand Moon pisze: > Enable CONFIG_LEDS_PWM amd CONFIG_LEDS_TRIGGER_HEARTBEAT for > Odroid-XU3 board. > > Signed-off-by: Anand Moon <linux.amoon@gmail.com> Dear Anand, There was some confusion for this patch (mixed v3 and v2) so overall it slipped through fingers. Can you please: 1. Rebase and resend. 2. Enable them as built-ins, not modules. For exynos_defconfig everything is built-in which makes easier to test on various boards. 3. Enable LEDS_GPIO. I don't know why it disappeared... Best regards, Krzysztof > --- > arch/arm/configs/exynos_defconfig | 6 ++++++ > 1 file changed, 6 insertions(+) > > diff --git a/arch/arm/configs/exynos_defconfig b/arch/arm/configs/exynos_defconfig > index 1b7253b..2bbdf80 100644 > --- a/arch/arm/configs/exynos_defconfig > +++ b/arch/arm/configs/exynos_defconfig > @@ -165,6 +165,12 @@ CONFIG_MMC_SDHCI_S3C_DMA=y > CONFIG_MMC_DW=y > CONFIG_MMC_DW_IDMAC=y > CONFIG_MMC_DW_EXYNOS=y > +CONFIG_NEW_LEDS=y > +CONFIG_LEDS_CLASS=m > +CONFIG_LEDS_PWM=m > +CONFIG_LEDS_TRIGGERS=y > +CONFIG_LEDS_TRIGGER_TIMER=m > +CONFIG_LEDS_TRIGGER_HEARTBEAT=m > CONFIG_RTC_CLASS=y > CONFIG_RTC_DRV_MAX77686=y > CONFIG_RTC_DRV_MAX77802=y > ^ permalink raw reply [flat|nested] 20+ messages in thread
* Re: [PATCHv2 2/2] ARM: exynos_defconfig: Enable CONFIG_LEDS_PWM for Odroid-XU3 2015-09-02 14:12 ` Krzysztof Kozlowski @ 2015-09-02 15:40 ` Anand Moon -1 siblings, 0 replies; 20+ messages in thread From: Anand Moon @ 2015-09-02 15:40 UTC (permalink / raw) To: Krzysztof Kozlowski Cc: Javier Martinez Canillas, Lukasz Majewski, Andreas Faerber, Sachin Kamat, Sjoerd Simons, Russell King, Kukjin Kim, linux-samsung-soc@vger.kernel.org, Linux Kernel, linux-arm-kernel HI Krzysztof, On 2 September 2015 at 19:42, Krzysztof Kozlowski <k.kozlowski@samsung.com> wrote: > W dniu 08.06.2015 o 02:03, Anand Moon pisze: >> Enable CONFIG_LEDS_PWM amd CONFIG_LEDS_TRIGGER_HEARTBEAT for >> Odroid-XU3 board. >> >> Signed-off-by: Anand Moon <linux.amoon@gmail.com> > > Dear Anand, > > There was some confusion for this patch (mixed v3 and v2) so overall it > slipped through fingers. > > Can you please: > 1. Rebase and resend. > 2. Enable them as built-ins, not modules. For exynos_defconfig > everything is built-in which makes easier to test on various boards. > 3. Enable LEDS_GPIO. I don't know why it disappeared... > > Best regards, > Krzysztof > > >> --- >> arch/arm/configs/exynos_defconfig | 6 ++++++ >> 1 file changed, 6 insertions(+) >> >> diff --git a/arch/arm/configs/exynos_defconfig b/arch/arm/configs/exynos_defconfig >> index 1b7253b..2bbdf80 100644 >> --- a/arch/arm/configs/exynos_defconfig >> +++ b/arch/arm/configs/exynos_defconfig >> @@ -165,6 +165,12 @@ CONFIG_MMC_SDHCI_S3C_DMA=y >> CONFIG_MMC_DW=y >> CONFIG_MMC_DW_IDMAC=y >> CONFIG_MMC_DW_EXYNOS=y >> +CONFIG_NEW_LEDS=y >> +CONFIG_LEDS_CLASS=m >> +CONFIG_LEDS_PWM=m >> +CONFIG_LEDS_TRIGGERS=y >> +CONFIG_LEDS_TRIGGER_TIMER=m >> +CONFIG_LEDS_TRIGGER_HEARTBEAT=m >> CONFIG_RTC_CLASS=y >> CONFIG_RTC_DRV_MAX77686=y >> CONFIG_RTC_DRV_MAX77802=y >> > Thanks for you input I will resend this patch. -Anand Moon ^ permalink raw reply [flat|nested] 20+ messages in thread
* [PATCHv2 2/2] ARM: exynos_defconfig: Enable CONFIG_LEDS_PWM for Odroid-XU3 @ 2015-09-02 15:40 ` Anand Moon 0 siblings, 0 replies; 20+ messages in thread From: Anand Moon @ 2015-09-02 15:40 UTC (permalink / raw) To: linux-arm-kernel HI Krzysztof, On 2 September 2015 at 19:42, Krzysztof Kozlowski <k.kozlowski@samsung.com> wrote: > W dniu 08.06.2015 o 02:03, Anand Moon pisze: >> Enable CONFIG_LEDS_PWM amd CONFIG_LEDS_TRIGGER_HEARTBEAT for >> Odroid-XU3 board. >> >> Signed-off-by: Anand Moon <linux.amoon@gmail.com> > > Dear Anand, > > There was some confusion for this patch (mixed v3 and v2) so overall it > slipped through fingers. > > Can you please: > 1. Rebase and resend. > 2. Enable them as built-ins, not modules. For exynos_defconfig > everything is built-in which makes easier to test on various boards. > 3. Enable LEDS_GPIO. I don't know why it disappeared... > > Best regards, > Krzysztof > > >> --- >> arch/arm/configs/exynos_defconfig | 6 ++++++ >> 1 file changed, 6 insertions(+) >> >> diff --git a/arch/arm/configs/exynos_defconfig b/arch/arm/configs/exynos_defconfig >> index 1b7253b..2bbdf80 100644 >> --- a/arch/arm/configs/exynos_defconfig >> +++ b/arch/arm/configs/exynos_defconfig >> @@ -165,6 +165,12 @@ CONFIG_MMC_SDHCI_S3C_DMA=y >> CONFIG_MMC_DW=y >> CONFIG_MMC_DW_IDMAC=y >> CONFIG_MMC_DW_EXYNOS=y >> +CONFIG_NEW_LEDS=y >> +CONFIG_LEDS_CLASS=m >> +CONFIG_LEDS_PWM=m >> +CONFIG_LEDS_TRIGGERS=y >> +CONFIG_LEDS_TRIGGER_TIMER=m >> +CONFIG_LEDS_TRIGGER_HEARTBEAT=m >> CONFIG_RTC_CLASS=y >> CONFIG_RTC_DRV_MAX77686=y >> CONFIG_RTC_DRV_MAX77802=y >> > Thanks for you input I will resend this patch. -Anand Moon ^ permalink raw reply [flat|nested] 20+ messages in thread
* Re: [PATCHv2 1/2] ARM: exynos_defconfig: Enable CONFIG_SND_SOC_ODROIDX2 for Odroid-XU3 2015-06-07 17:03 ` Anand Moon @ 2015-06-08 15:10 ` Lukasz Majewski -1 siblings, 0 replies; 20+ messages in thread From: Lukasz Majewski @ 2015-06-08 15:10 UTC (permalink / raw) To: Anand Moon Cc: Russell King, Kukjin Kim, Krzysztof Kozlowski, Javier Martinez Canillas, Andreas Faerber, Sachin Kamat, Sjoerd Simons, linux-arm-kernel, linux-samsung-soc, linux-kernel Hi Anand, > Enable CONFIG_SND_SOC_ODROIDX2 and CONFIG_SND_SIMPLE_CARD to enable > sound on Odroid-XU3 board. > > Below is the output of boot log. > [ 6.021550] max98090 5-0010: MAX98090 REVID=0x43 > [ 6.025506] random: nonblocking pool is initialized > [ 6.047297] asoc-simple-card sound: HiFi <-> 3830000.i2s mapping ok > [ 6.068392] s5m-rtc s2mps14-rtc: setting system clock to > 2015-06-07 12:51:06 UTC (1433681466) [ 6.123650] ALSA device list: > [ 6.135203] #0: Odroid-XU3 > > Signed-off-by: Anand Moon <linux.amoon@gmail.com> > --- > arch/arm/configs/exynos_defconfig | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/arch/arm/configs/exynos_defconfig > b/arch/arm/configs/exynos_defconfig index 9504e77..1b7253b 100644 > --- a/arch/arm/configs/exynos_defconfig > +++ b/arch/arm/configs/exynos_defconfig > @@ -144,6 +144,8 @@ CONFIG_SND=y > CONFIG_SND_SOC=y > CONFIG_SND_SOC_SAMSUNG=y > CONFIG_SND_SOC_SNOW=y > +CONFIG_SND_SOC_ODROIDX2=y > +CONFIG_SND_SIMPLE_CARD=y > CONFIG_USB=y > CONFIG_USB_ANNOUNCE_NEW_DEVICES=y > CONFIG_USB_XHCI_HCD=y Reviewed-by: Lukasz Majewski <l.majewski@samsung.com> -- Best regards, Lukasz Majewski Samsung R&D Institute Poland (SRPOL) | Linux Platform Group ^ permalink raw reply [flat|nested] 20+ messages in thread
* [PATCHv2 1/2] ARM: exynos_defconfig: Enable CONFIG_SND_SOC_ODROIDX2 for Odroid-XU3 @ 2015-06-08 15:10 ` Lukasz Majewski 0 siblings, 0 replies; 20+ messages in thread From: Lukasz Majewski @ 2015-06-08 15:10 UTC (permalink / raw) To: linux-arm-kernel Hi Anand, > Enable CONFIG_SND_SOC_ODROIDX2 and CONFIG_SND_SIMPLE_CARD to enable > sound on Odroid-XU3 board. > > Below is the output of boot log. > [ 6.021550] max98090 5-0010: MAX98090 REVID=0x43 > [ 6.025506] random: nonblocking pool is initialized > [ 6.047297] asoc-simple-card sound: HiFi <-> 3830000.i2s mapping ok > [ 6.068392] s5m-rtc s2mps14-rtc: setting system clock to > 2015-06-07 12:51:06 UTC (1433681466) [ 6.123650] ALSA device list: > [ 6.135203] #0: Odroid-XU3 > > Signed-off-by: Anand Moon <linux.amoon@gmail.com> > --- > arch/arm/configs/exynos_defconfig | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/arch/arm/configs/exynos_defconfig > b/arch/arm/configs/exynos_defconfig index 9504e77..1b7253b 100644 > --- a/arch/arm/configs/exynos_defconfig > +++ b/arch/arm/configs/exynos_defconfig > @@ -144,6 +144,8 @@ CONFIG_SND=y > CONFIG_SND_SOC=y > CONFIG_SND_SOC_SAMSUNG=y > CONFIG_SND_SOC_SNOW=y > +CONFIG_SND_SOC_ODROIDX2=y > +CONFIG_SND_SIMPLE_CARD=y > CONFIG_USB=y > CONFIG_USB_ANNOUNCE_NEW_DEVICES=y > CONFIG_USB_XHCI_HCD=y Reviewed-by: Lukasz Majewski <l.majewski@samsung.com> -- Best regards, Lukasz Majewski Samsung R&D Institute Poland (SRPOL) | Linux Platform Group ^ permalink raw reply [flat|nested] 20+ messages in thread
* Re: [PATCHv2 1/2] ARM: exynos_defconfig: Enable CONFIG_SND_SOC_ODROIDX2 for Odroid-XU3 2015-06-07 17:03 ` Anand Moon @ 2015-06-08 23:50 ` Krzysztof Kozlowski -1 siblings, 0 replies; 20+ messages in thread From: Krzysztof Kozlowski @ 2015-06-08 23:50 UTC (permalink / raw) To: Anand Moon, Russell King, Kukjin Kim, Javier Martinez Canillas, Lukasz Majewski, Andreas Faerber, Sachin Kamat, Sjoerd Simons Cc: linux-arm-kernel, linux-samsung-soc, linux-kernel On 08.06.2015 02:03, Anand Moon wrote: > Enable CONFIG_SND_SOC_ODROIDX2 and CONFIG_SND_SIMPLE_CARD to enable > sound on Odroid-XU3 board. > > Below is the output of boot log. > [ 6.021550] max98090 5-0010: MAX98090 REVID=0x43 > [ 6.025506] random: nonblocking pool is initialized > [ 6.047297] asoc-simple-card sound: HiFi <-> 3830000.i2s mapping ok > [ 6.068392] s5m-rtc s2mps14-rtc: setting system clock to 2015-06-07 12:51:06 UTC (1433681466) > [ 6.123650] ALSA device list: > [ 6.135203] #0: Odroid-XU3 Answering the question "why" and "what is device" would be sufficient. You answered the first question ("enable sound") so you can just add second part - using the max98090 audio codec. This whole dmesg does not bring any benefits here, especially the irrelevant items (like random or RTC). Could you trim the commit message? Beside of that it looks fine however you marked this as "v2": 1. I cannot find v1 on Google. The title was the same? 2. Where is changelog? Best regards, Krzysztof ^ permalink raw reply [flat|nested] 20+ messages in thread
* [PATCHv2 1/2] ARM: exynos_defconfig: Enable CONFIG_SND_SOC_ODROIDX2 for Odroid-XU3 @ 2015-06-08 23:50 ` Krzysztof Kozlowski 0 siblings, 0 replies; 20+ messages in thread From: Krzysztof Kozlowski @ 2015-06-08 23:50 UTC (permalink / raw) To: linux-arm-kernel On 08.06.2015 02:03, Anand Moon wrote: > Enable CONFIG_SND_SOC_ODROIDX2 and CONFIG_SND_SIMPLE_CARD to enable > sound on Odroid-XU3 board. > > Below is the output of boot log. > [ 6.021550] max98090 5-0010: MAX98090 REVID=0x43 > [ 6.025506] random: nonblocking pool is initialized > [ 6.047297] asoc-simple-card sound: HiFi <-> 3830000.i2s mapping ok > [ 6.068392] s5m-rtc s2mps14-rtc: setting system clock to 2015-06-07 12:51:06 UTC (1433681466) > [ 6.123650] ALSA device list: > [ 6.135203] #0: Odroid-XU3 Answering the question "why" and "what is device" would be sufficient. You answered the first question ("enable sound") so you can just add second part - using the max98090 audio codec. This whole dmesg does not bring any benefits here, especially the irrelevant items (like random or RTC). Could you trim the commit message? Beside of that it looks fine however you marked this as "v2": 1. I cannot find v1 on Google. The title was the same? 2. Where is changelog? Best regards, Krzysztof ^ permalink raw reply [flat|nested] 20+ messages in thread
* Re: [PATCHv2 1/2] ARM: exynos_defconfig: Enable CONFIG_SND_SOC_ODROIDX2 for Odroid-XU3 2015-06-08 23:50 ` Krzysztof Kozlowski @ 2015-06-09 2:39 ` Anand Moon -1 siblings, 0 replies; 20+ messages in thread From: Anand Moon @ 2015-06-09 2:39 UTC (permalink / raw) To: Krzysztof Kozlowski Cc: Russell King, Kukjin Kim, Javier Martinez Canillas, Lukasz Majewski, Andreas Faerber, Sachin Kamat, Sjoerd Simons, linux-arm-kernel, linux-samsung-soc@vger.kernel.org, Linux Kernel Hi, On 9 June 2015 at 05:20, Krzysztof Kozlowski <k.kozlowski@samsung.com> wrote: > On 08.06.2015 02:03, Anand Moon wrote: >> Enable CONFIG_SND_SOC_ODROIDX2 and CONFIG_SND_SIMPLE_CARD to enable >> sound on Odroid-XU3 board. >> >> Below is the output of boot log. >> [ 6.021550] max98090 5-0010: MAX98090 REVID=0x43 >> [ 6.025506] random: nonblocking pool is initialized >> [ 6.047297] asoc-simple-card sound: HiFi <-> 3830000.i2s mapping ok >> [ 6.068392] s5m-rtc s2mps14-rtc: setting system clock to 2015-06-07 12:51:06 UTC (1433681466) >> [ 6.123650] ALSA device list: >> [ 6.135203] #0: Odroid-XU3 > > Answering the question "why" and "what is device" would be sufficient. > You answered the first question ("enable sound") so you can just add > second part - using the max98090 audio codec. > > This whole dmesg does not bring any benefits here, especially the > irrelevant items (like random or RTC). Could you trim the commit message? > > Beside of that it looks fine however you marked this as "v2": > 1. I cannot find v1 on Google. The title was the same? > 2. Where is changelog? > > Best regards, > Krzysztof Look like I an doom to make mistake. This series of patch got PATCHv2 tag, It's my mistake. not maintain the version of the patch. I will resend it. -Anand Moon ^ permalink raw reply [flat|nested] 20+ messages in thread
* [PATCHv2 1/2] ARM: exynos_defconfig: Enable CONFIG_SND_SOC_ODROIDX2 for Odroid-XU3 @ 2015-06-09 2:39 ` Anand Moon 0 siblings, 0 replies; 20+ messages in thread From: Anand Moon @ 2015-06-09 2:39 UTC (permalink / raw) To: linux-arm-kernel Hi, On 9 June 2015 at 05:20, Krzysztof Kozlowski <k.kozlowski@samsung.com> wrote: > On 08.06.2015 02:03, Anand Moon wrote: >> Enable CONFIG_SND_SOC_ODROIDX2 and CONFIG_SND_SIMPLE_CARD to enable >> sound on Odroid-XU3 board. >> >> Below is the output of boot log. >> [ 6.021550] max98090 5-0010: MAX98090 REVID=0x43 >> [ 6.025506] random: nonblocking pool is initialized >> [ 6.047297] asoc-simple-card sound: HiFi <-> 3830000.i2s mapping ok >> [ 6.068392] s5m-rtc s2mps14-rtc: setting system clock to 2015-06-07 12:51:06 UTC (1433681466) >> [ 6.123650] ALSA device list: >> [ 6.135203] #0: Odroid-XU3 > > Answering the question "why" and "what is device" would be sufficient. > You answered the first question ("enable sound") so you can just add > second part - using the max98090 audio codec. > > This whole dmesg does not bring any benefits here, especially the > irrelevant items (like random or RTC). Could you trim the commit message? > > Beside of that it looks fine however you marked this as "v2": > 1. I cannot find v1 on Google. The title was the same? > 2. Where is changelog? > > Best regards, > Krzysztof Look like I an doom to make mistake. This series of patch got PATCHv2 tag, It's my mistake. not maintain the version of the patch. I will resend it. -Anand Moon ^ permalink raw reply [flat|nested] 20+ messages in thread
end of thread, other threads:[~2015-09-02 15:40 UTC | newest] Thread overview: 20+ messages (download: mbox.gz follow: Atom feed -- links below jump to the message on this page -- 2015-06-07 17:03 [PATCHv2 1/2] ARM: exynos_defconfig: Enable CONFIG_SND_SOC_ODROIDX2 for Odroid-XU3 Anand Moon 2015-06-07 17:03 ` Anand Moon 2015-06-07 17:03 ` [PATCHv2 2/2] ARM: exynos_defconfig: Enable CONFIG_LEDS_PWM " Anand Moon 2015-06-07 17:03 ` Anand Moon 2015-06-08 15:11 ` Lukasz Majewski 2015-06-08 15:11 ` Lukasz Majewski 2015-06-08 23:56 ` Krzysztof Kozlowski 2015-06-08 23:56 ` Krzysztof Kozlowski 2015-06-09 3:08 ` Anand Moon 2015-06-09 3:08 ` Anand Moon 2015-09-02 14:12 ` Krzysztof Kozlowski 2015-09-02 14:12 ` Krzysztof Kozlowski 2015-09-02 15:40 ` Anand Moon 2015-09-02 15:40 ` Anand Moon 2015-06-08 15:10 ` [PATCHv2 1/2] ARM: exynos_defconfig: Enable CONFIG_SND_SOC_ODROIDX2 " Lukasz Majewski 2015-06-08 15:10 ` Lukasz Majewski 2015-06-08 23:50 ` Krzysztof Kozlowski 2015-06-08 23:50 ` Krzysztof Kozlowski 2015-06-09 2:39 ` Anand Moon 2015-06-09 2:39 ` Anand Moon
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.