All of lore.kernel.org
 help / color / mirror / Atom feed
From: Joe Perches <joe@perches.com>
To: lustre-devel@lists.lustre.org
Subject: [lustre-devel] [PATCH v4 1/7] staging:lustre: move tcpip abstraction
Date: Mon, 08 Jun 2015 12:57:49 -0700	[thread overview]
Message-ID: <1433793469.2730.5.camel@perches.com> (raw)
In-Reply-To: <20150608193359.GA1001@kroah.com>

On Mon, 2015-06-08 at 12:33 -0700, Greg Kroah-Hartman wrote:
> Please generate patches in -M format, so I can see the rename properly,
> as it is, this is too messy for me to review.

Adding this to the .gitconfig works too

[diff]
	renames = true

That should probably be mentioned in SubmittingPatches.

Something like:
---
 Documentation/SubmittingPatches | 7 +++++++
 1 file changed, 7 insertions(+)

diff --git a/Documentation/SubmittingPatches b/Documentation/SubmittingPatches
index 27e7e5e..d86cf89 100644
--- a/Documentation/SubmittingPatches
+++ b/Documentation/SubmittingPatches
@@ -715,6 +715,13 @@ the top of the kernel source tree and don't use too much horizontal
 space (easily fit in 80 columns, maybe with some indentation).  (git
 generates appropriate diffstats by default.)
 
+Another good thing is to generate shorter patches whenever a file rename
+has been done.  Using "git format-patch -M" does this appropriately.
+Adding a [diff] section as below to .gitconfig can also do this:
+
+       [diff]
+              renames = true
+
 See more details on the proper patch format in the following
 references.
 

WARNING: multiple messages have this Message-ID (diff)
From: Joe Perches <joe@perches.com>
To: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	Jonathan Corbet <corbet@lwn.net>,
	linux-doc@vger.kernel.org
Cc: James Simmons <jsimmons@infradead.org>,
	devel@driverdev.osuosl.org, Oleg Drokin <oleg.drokin@intel.com>,
	Andreas Dilger <andreas.dilger@intel.com>,
	Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
	lustre-devel@lists.lustre.org
Subject: Re: [PATCH v4 1/7] staging:lustre: move tcpip abstraction
Date: Mon, 08 Jun 2015 12:57:49 -0700	[thread overview]
Message-ID: <1433793469.2730.5.camel@perches.com> (raw)
In-Reply-To: <20150608193359.GA1001@kroah.com>

On Mon, 2015-06-08 at 12:33 -0700, Greg Kroah-Hartman wrote:
> Please generate patches in -M format, so I can see the rename properly,
> as it is, this is too messy for me to review.

Adding this to the .gitconfig works too

[diff]
	renames = true

That should probably be mentioned in SubmittingPatches.

Something like:
---
 Documentation/SubmittingPatches | 7 +++++++
 1 file changed, 7 insertions(+)

diff --git a/Documentation/SubmittingPatches b/Documentation/SubmittingPatches
index 27e7e5e..d86cf89 100644
--- a/Documentation/SubmittingPatches
+++ b/Documentation/SubmittingPatches
@@ -715,6 +715,13 @@ the top of the kernel source tree and don't use too much horizontal
 space (easily fit in 80 columns, maybe with some indentation).  (git
 generates appropriate diffstats by default.)
 
+Another good thing is to generate shorter patches whenever a file rename
+has been done.  Using "git format-patch -M" does this appropriately.
+Adding a [diff] section as below to .gitconfig can also do this:
+
+       [diff]
+              renames = true
+
 See more details on the proper patch format in the following
 references.
 



  reply	other threads:[~2015-06-08 19:57 UTC|newest]

Thread overview: 36+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-06-03 19:57 [lustre-devel] [PATCH v4 0/7] staging:lustre: remove tcpip abstraction from libcfs James Simmons
2015-06-03 19:57 ` James Simmons
2015-06-03 19:57 ` [lustre-devel] [PATCH v4 1/7] staging:lustre: move tcpip abstraction James Simmons
2015-06-03 19:57   ` James Simmons
2015-06-04  5:35   ` [lustre-devel] " Sudip Mukherjee
2015-06-04  5:35     ` Sudip Mukherjee
2015-06-04  7:34     ` [lustre-devel] " Dan Carpenter
2015-06-04  7:34       ` Dan Carpenter
2015-06-04  7:45       ` [lustre-devel] " Sudip Mukherjee
2015-06-04  7:45         ` Sudip Mukherjee
2015-06-09 13:38         ` [lustre-devel] " Simmons, James A.
2015-06-09 13:38           ` Simmons, James A.
2015-06-08 19:33   ` Greg Kroah-Hartman
2015-06-08 19:33     ` Greg Kroah-Hartman
2015-06-08 19:57     ` Joe Perches [this message]
2015-06-08 19:57       ` Joe Perches
2015-06-03 19:57 ` [lustre-devel] [PATCH v4 2/7] staging:lustre: remove useless libcfs_sock_release James Simmons
2015-06-03 19:57   ` James Simmons
2015-06-03 19:57 ` [lustre-devel] [PATCH v4 3/7] staging:lustre: remove useless libcfs_sock_abort_accept James Simmons
2015-06-03 19:57   ` James Simmons
2015-06-03 19:57 ` [lustre-devel] [PATCH v4 4/7] staging:lustre: rename tcpip handling functions to lnet_* prefix James Simmons
2015-06-03 19:57   ` James Simmons
2015-06-04  5:57   ` [lustre-devel] " Sudip Mukherjee
2015-06-04  5:57     ` Sudip Mukherjee
2015-06-04  7:41     ` [lustre-devel] " Dan Carpenter
2015-06-04  7:41       ` Dan Carpenter
2015-06-03 19:57 ` [lustre-devel] [PATCH v4 5/7] staging:lustre: use available kernel wrappers in lib-socket.c James Simmons
2015-06-03 19:57   ` James Simmons
2015-06-03 19:57 ` [lustre-devel] [PATCH v4 6/7] staging:lustre: style cleanups for lib-socket.c James Simmons
2015-06-03 19:57   ` James Simmons
2015-06-04  6:02   ` [lustre-devel] " Sudip Mukherjee
2015-06-04  6:02     ` Sudip Mukherjee
2015-06-04  7:54   ` [lustre-devel] " Dan Carpenter
2015-06-04  7:54     ` Dan Carpenter
2015-06-03 19:57 ` [lustre-devel] [PATCH v4 7/7] staging:lustre: Update license and copyright " James Simmons
2015-06-03 19:57   ` James Simmons

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1433793469.2730.5.camel@perches.com \
    --to=joe@perches.com \
    --cc=lustre-devel@lists.lustre.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.