All of lore.kernel.org
 help / color / mirror / Atom feed
From: Dan Carpenter <dan.carpenter@oracle.com>
To: lustre-devel@lists.lustre.org
Subject: [lustre-devel] [PATCH v4 4/7] staging:lustre: rename tcpip handling functions to lnet_* prefix
Date: Thu, 4 Jun 2015 10:41:07 +0300	[thread overview]
Message-ID: <20150604074107.GB28762@mwanda> (raw)
In-Reply-To: <20150604055710.GC6376@sudip-PC>

On Thu, Jun 04, 2015 at 11:27:10AM +0530, Sudip Mukherjee wrote:
> On Wed, Jun 03, 2015 at 03:57:10PM -0400, James Simmons wrote:
> > With all the TCPIP handling done in the lnet layer we should
> > rename all the functions with the prefix lnet_*. One other
> > change done was changing the remove argument of lnet_sock_getaddr
> > from a int to a bool.
> thats two different change.
> and apart from this:
> 1) the function declarations were renamed and moved from
> lustre/include/linux/libcfs/libcfs.h to drivers/staging/lustre/include/linux/lnet/lib-lnet.h
> 
> 2) some functions you have changed the coding style. like:
> -     rc = libcfs_sock_getaddr(conn->ksnc_sock, 0,
> -                              &conn->ksnc_myipaddr, NULL);
> +     rc = lnet_sock_getaddr(conn->ksnc_sock, 0, &conn->ksnc_myipaddr, NULL);
> 

Those are tiny related changes.  They're fine.  When you rename
functions you normally have to change the indenting as well.

regards,
dan carpenter

WARNING: multiple messages have this Message-ID (diff)
From: Dan Carpenter <dan.carpenter@oracle.com>
To: Sudip Mukherjee <sudipm.mukherjee@gmail.com>
Cc: James Simmons <jsimmons@infradead.org>,
	devel@driverdev.osuosl.org,
	Andreas Dilger <andreas.dilger@intel.com>,
	Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
	Oleg Drokin <oleg.drokin@intel.com>,
	lustre-devel@lists.lustre.org
Subject: Re: [PATCH v4 4/7] staging:lustre: rename tcpip handling functions to lnet_* prefix
Date: Thu, 4 Jun 2015 10:41:07 +0300	[thread overview]
Message-ID: <20150604074107.GB28762@mwanda> (raw)
In-Reply-To: <20150604055710.GC6376@sudip-PC>

On Thu, Jun 04, 2015 at 11:27:10AM +0530, Sudip Mukherjee wrote:
> On Wed, Jun 03, 2015 at 03:57:10PM -0400, James Simmons wrote:
> > With all the TCPIP handling done in the lnet layer we should
> > rename all the functions with the prefix lnet_*. One other
> > change done was changing the remove argument of lnet_sock_getaddr
> > from a int to a bool.
> thats two different change.
> and apart from this:
> 1) the function declarations were renamed and moved from
> lustre/include/linux/libcfs/libcfs.h to drivers/staging/lustre/include/linux/lnet/lib-lnet.h
> 
> 2) some functions you have changed the coding style. like:
> -     rc = libcfs_sock_getaddr(conn->ksnc_sock, 0,
> -                              &conn->ksnc_myipaddr, NULL);
> +     rc = lnet_sock_getaddr(conn->ksnc_sock, 0, &conn->ksnc_myipaddr, NULL);
> 

Those are tiny related changes.  They're fine.  When you rename
functions you normally have to change the indenting as well.

regards,
dan carpenter


  reply	other threads:[~2015-06-04  7:41 UTC|newest]

Thread overview: 36+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-06-03 19:57 [lustre-devel] [PATCH v4 0/7] staging:lustre: remove tcpip abstraction from libcfs James Simmons
2015-06-03 19:57 ` James Simmons
2015-06-03 19:57 ` [lustre-devel] [PATCH v4 1/7] staging:lustre: move tcpip abstraction James Simmons
2015-06-03 19:57   ` James Simmons
2015-06-04  5:35   ` [lustre-devel] " Sudip Mukherjee
2015-06-04  5:35     ` Sudip Mukherjee
2015-06-04  7:34     ` [lustre-devel] " Dan Carpenter
2015-06-04  7:34       ` Dan Carpenter
2015-06-04  7:45       ` [lustre-devel] " Sudip Mukherjee
2015-06-04  7:45         ` Sudip Mukherjee
2015-06-09 13:38         ` [lustre-devel] " Simmons, James A.
2015-06-09 13:38           ` Simmons, James A.
2015-06-08 19:33   ` Greg Kroah-Hartman
2015-06-08 19:33     ` Greg Kroah-Hartman
2015-06-08 19:57     ` [lustre-devel] " Joe Perches
2015-06-08 19:57       ` Joe Perches
2015-06-03 19:57 ` [lustre-devel] [PATCH v4 2/7] staging:lustre: remove useless libcfs_sock_release James Simmons
2015-06-03 19:57   ` James Simmons
2015-06-03 19:57 ` [lustre-devel] [PATCH v4 3/7] staging:lustre: remove useless libcfs_sock_abort_accept James Simmons
2015-06-03 19:57   ` James Simmons
2015-06-03 19:57 ` [lustre-devel] [PATCH v4 4/7] staging:lustre: rename tcpip handling functions to lnet_* prefix James Simmons
2015-06-03 19:57   ` James Simmons
2015-06-04  5:57   ` [lustre-devel] " Sudip Mukherjee
2015-06-04  5:57     ` Sudip Mukherjee
2015-06-04  7:41     ` Dan Carpenter [this message]
2015-06-04  7:41       ` Dan Carpenter
2015-06-03 19:57 ` [lustre-devel] [PATCH v4 5/7] staging:lustre: use available kernel wrappers in lib-socket.c James Simmons
2015-06-03 19:57   ` James Simmons
2015-06-03 19:57 ` [lustre-devel] [PATCH v4 6/7] staging:lustre: style cleanups for lib-socket.c James Simmons
2015-06-03 19:57   ` James Simmons
2015-06-04  6:02   ` [lustre-devel] " Sudip Mukherjee
2015-06-04  6:02     ` Sudip Mukherjee
2015-06-04  7:54   ` [lustre-devel] " Dan Carpenter
2015-06-04  7:54     ` Dan Carpenter
2015-06-03 19:57 ` [lustre-devel] [PATCH v4 7/7] staging:lustre: Update license and copyright " James Simmons
2015-06-03 19:57   ` James Simmons

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20150604074107.GB28762@mwanda \
    --to=dan.carpenter@oracle.com \
    --cc=lustre-devel@lists.lustre.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.