From: "Jiang, Dave" <dave.jiang@intel.com>
To: "bhelgaas@google.com" <bhelgaas@google.com>
Cc: "Allen.Hubbe@emc.com" <Allen.Hubbe@emc.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"linux-pci@vger.kernel.org" <linux-pci@vger.kernel.org>,
"jdmason@kudzu.us" <jdmason@kudzu.us>,
"linux-ntb@googlegroups.com" <linux-ntb@googlegroups.com>
Subject: Re: [PATCH v3 18/18] NTB: Increase transport MTU to 64k from 16k
Date: Tue, 9 Jun 2015 16:45:36 +0000 [thread overview]
Message-ID: <1433868335.38406.111.camel@intel.com> (raw)
In-Reply-To: <CAErSpo7B8qP34ZObkzjZ-r7bCnG6A0KG3Rorw+TajP4XU43wFg@mail.gmail.com>
T24gVHVlLCAyMDE1LTA2LTA5IGF0IDExOjA0IC0wNTAwLCAnQmpvcm4gSGVsZ2FhcycgdmlhIGxp
bnV4LW50YiB3cm90ZToNCj4gT24gVHVlLCBKdW4gOSwgMjAxNSBhdCA0OjQ0IEFNLCBBbGxlbiBI
dWJiZSA8QWxsZW4uSHViYmVAZW1jLmNvbT4gDQo+IHdyb3RlOg0KPiA+IEZyb206IERhdmUgSmlh
bmcgPGRhdmUuamlhbmdAaW50ZWwuY29tPg0KPiA+IA0KPiA+IEJlbmNobWFya2luZyBzaG93ZWQg
c2lnbmlmaWNhbnQgcGVyZm9ybWFuY2UgaW5jcmVhc2UgZ29pbmcgZnJvbSBNVFUgDQo+ID4gc2l6
ZQ0KPiA+IG9mIDY0ayBmcm9tIDE2ay4gIENoYW5naW5nIHRoZSBkZWZhdWx0Lg0KPiANCj4gVGhp
cyBjaGFuZ2Vsb2cgZG9lc24ndCBwYXJzZS4gIEkgdGhpbmsgeW91IG1lYW4gImdvaW5nIGZyb20g
TVRVIHNpemUNCj4gMTZrIHRvIDY0ay4iDQoNClllcy4gU29ycnkgYWJvdXQgdGhlIGNvbmZ1c2lv
bi4NCg0KPiANCj4gVGhlIG9yaWdpbmFsIHZhbHVlIHdhcyAweDQwMWUgKDE2ayArIDB4MWUpLCBh
bmQgdGhlIG5ldyB2YWx1ZSBpcw0KPiBleGFjdGx5IDY0ay4gIFBsZWFzZSBpbmNsdWRlIGEgbm90
ZSBhYm91dCB3aGF0IHRoYXQgZXh0cmEgMHgxZSB3YXMgDQo+IGZvcg0KPiBhbmQgd2h5IGl0IGlz
bid0IG5lZWRlZCBpbiB0aGUgbmV3IHZhbHVlLg0KDQpKb24sIGNhbiB5b3UgY29tbWVudCBvbiB3
aHkgdGhlcmUncyB0aGUgYWRkaXRpb25hbCAzMCBieXRlcyBvbiB0b3Agb2YNCjE2ayBpbiB0aGUg
cHJldmlvdXMgdmFsdWU/IA0KDQo+IA0KPiA+IFNpZ25lZC1vZmYtYnk6IERhdmUgSmlhbmcgPGRh
dmUuamlhbmdAaW50ZWwuY29tPg0KPiA+IC0tLQ0KPiA+ICBkcml2ZXJzL250Yi9udGJfdHJhbnNw
b3J0LmMgfCAyICstDQo+ID4gIDEgZmlsZSBjaGFuZ2VkLCAxIGluc2VydGlvbigrKSwgMSBkZWxl
dGlvbigtKQ0KPiA+IA0KPiA+IGRpZmYgLS1naXQgYS9kcml2ZXJzL250Yi9udGJfdHJhbnNwb3J0
LmMgDQo+ID4gYi9kcml2ZXJzL250Yi9udGJfdHJhbnNwb3J0LmMNCj4gPiBpbmRleCBlYTIzN2Fl
Y2EyOGMuLmM4N2JjMGNiZDYwNyAxMDA2NDQNCj4gPiAtLS0gYS9kcml2ZXJzL250Yi9udGJfdHJh
bnNwb3J0LmMNCj4gPiArKysgYi9kcml2ZXJzL250Yi9udGJfdHJhbnNwb3J0LmMNCj4gPiBAQCAt
NzYsNyArNzYsNyBAQCBzdGF0aWMgdW5zaWduZWQgbG9uZyBtYXhfbXdfc2l6ZTsNCj4gPiAgbW9k
dWxlX3BhcmFtKG1heF9td19zaXplLCB1bG9uZywgMDY0NCk7DQo+ID4gIE1PRFVMRV9QQVJNX0RF
U0MobWF4X213X3NpemUsICJMaW1pdCBzaXplIG9mIGxhcmdlIG1lbW9yeSANCj4gPiB3aW5kb3dz
Iik7DQo+ID4gDQo+ID4gLXN0YXRpYyB1bnNpZ25lZCBpbnQgdHJhbnNwb3J0X210dSA9IDB4NDAx
RTsNCj4gPiArc3RhdGljIHVuc2lnbmVkIGludCB0cmFuc3BvcnRfbXR1ID0gMHgxMDAwMDsNCj4g
PiAgbW9kdWxlX3BhcmFtKHRyYW5zcG9ydF9tdHUsIHVpbnQsIDA2NDQpOw0KPiA+ICBNT0RVTEVf
UEFSTV9ERVNDKHRyYW5zcG9ydF9tdHUsICJNYXhpbXVtIHNpemUgb2YgTlRCIHRyYW5zcG9ydCAN
Cj4gPiBwYWNrZXRzIik7DQo+ID4gDQo+ID4gLS0NCj4gPiAyLjQuMC5yYzAuNDMuZ2NmOGE4YzYN
Cj4gPiANCj4gPiAtLQ0KPiA+IFRvIHVuc3Vic2NyaWJlIGZyb20gdGhpcyBsaXN0OiBzZW5kIHRo
ZSBsaW5lICJ1bnN1YnNjcmliZSBsaW51eA0KPiA+IC1wY2kiIGluDQo+ID4gdGhlIGJvZHkgb2Yg
YSBtZXNzYWdlIHRvIG1ham9yZG9tb0B2Z2VyLmtlcm5lbC5vcmcNCj4gPiBNb3JlIG1ham9yZG9t
byBpbmZvIGF0ICBodHRwOi8vdmdlci5rZXJuZWwub3JnL21ham9yZG9tby1pbmZvLmh0bWwNCj4g
WARNING: multiple messages have this Message-ID (diff)
From: "Jiang, Dave" <dave.jiang@intel.com>
To: "bhelgaas@google.com" <bhelgaas@google.com>
Cc: "Allen.Hubbe@emc.com" <Allen.Hubbe@emc.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"linux-pci@vger.kernel.org" <linux-pci@vger.kernel.org>,
"jdmason@kudzu.us" <jdmason@kudzu.us>,
"linux-ntb@googlegroups.com" <linux-ntb@googlegroups.com>
Subject: Re: [PATCH v3 18/18] NTB: Increase transport MTU to 64k from 16k
Date: Tue, 9 Jun 2015 16:45:36 +0000 [thread overview]
Message-ID: <1433868335.38406.111.camel@intel.com> (raw)
In-Reply-To: <CAErSpo7B8qP34ZObkzjZ-r7bCnG6A0KG3Rorw+TajP4XU43wFg@mail.gmail.com>
On Tue, 2015-06-09 at 11:04 -0500, 'Bjorn Helgaas' via linux-ntb wrote:
> On Tue, Jun 9, 2015 at 4:44 AM, Allen Hubbe <Allen.Hubbe@emc.com>
> wrote:
> > From: Dave Jiang <dave.jiang@intel.com>
> >
> > Benchmarking showed significant performance increase going from MTU
> > size
> > of 64k from 16k. Changing the default.
>
> This changelog doesn't parse. I think you mean "going from MTU size
> 16k to 64k."
Yes. Sorry about the confusion.
>
> The original value was 0x401e (16k + 0x1e), and the new value is
> exactly 64k. Please include a note about what that extra 0x1e was
> for
> and why it isn't needed in the new value.
Jon, can you comment on why there's the additional 30 bytes on top of
16k in the previous value?
>
> > Signed-off-by: Dave Jiang <dave.jiang@intel.com>
> > ---
> > drivers/ntb/ntb_transport.c | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/drivers/ntb/ntb_transport.c
> > b/drivers/ntb/ntb_transport.c
> > index ea237aeca28c..c87bc0cbd607 100644
> > --- a/drivers/ntb/ntb_transport.c
> > +++ b/drivers/ntb/ntb_transport.c
> > @@ -76,7 +76,7 @@ static unsigned long max_mw_size;
> > module_param(max_mw_size, ulong, 0644);
> > MODULE_PARM_DESC(max_mw_size, "Limit size of large memory
> > windows");
> >
> > -static unsigned int transport_mtu = 0x401E;
> > +static unsigned int transport_mtu = 0x10000;
> > module_param(transport_mtu, uint, 0644);
> > MODULE_PARM_DESC(transport_mtu, "Maximum size of NTB transport
> > packets");
> >
> > --
> > 2.4.0.rc0.43.gcf8a8c6
> >
> > --
> > To unsubscribe from this list: send the line "unsubscribe linux
> > -pci" in
> > the body of a message to majordomo@vger.kernel.org
> > More majordomo info at http://vger.kernel.org/majordomo-info.html
>
WARNING: multiple messages have this Message-ID (diff)
From: "Jiang, Dave" <dave.jiang@intel.com>
To: "bhelgaas@google.com" <bhelgaas@google.com>
Cc: "Allen.Hubbe@emc.com" <Allen.Hubbe@emc.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"linux-pci@vger.kernel.org" <linux-pci@vger.kernel.org>,
"jdmason@kudzu.us" <jdmason@kudzu.us>,
"linux-ntb@googlegroups.com" <linux-ntb@googlegroups.com>
Subject: Re: [PATCH v3 18/18] NTB: Increase transport MTU to 64k from 16k
Date: Tue, 9 Jun 2015 16:45:36 +0000 [thread overview]
Message-ID: <1433868335.38406.111.camel@intel.com> (raw)
In-Reply-To: <CAErSpo7B8qP34ZObkzjZ-r7bCnG6A0KG3Rorw+TajP4XU43wFg@mail.gmail.com>
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #1: Type: text/plain; charset="utf-8", Size: 1931 bytes --]
On Tue, 2015-06-09 at 11:04 -0500, 'Bjorn Helgaas' via linux-ntb wrote:
> On Tue, Jun 9, 2015 at 4:44 AM, Allen Hubbe <Allen.Hubbe@emc.com>
> wrote:
> > From: Dave Jiang <dave.jiang@intel.com>
> >
> > Benchmarking showed significant performance increase going from MTU
> > size
> > of 64k from 16k. Changing the default.
>
> This changelog doesn't parse. I think you mean "going from MTU size
> 16k to 64k."
Yes. Sorry about the confusion.
>
> The original value was 0x401e (16k + 0x1e), and the new value is
> exactly 64k. Please include a note about what that extra 0x1e was
> for
> and why it isn't needed in the new value.
Jon, can you comment on why there's the additional 30 bytes on top of
16k in the previous value?
>
> > Signed-off-by: Dave Jiang <dave.jiang@intel.com>
> > ---
> > drivers/ntb/ntb_transport.c | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/drivers/ntb/ntb_transport.c
> > b/drivers/ntb/ntb_transport.c
> > index ea237aeca28c..c87bc0cbd607 100644
> > --- a/drivers/ntb/ntb_transport.c
> > +++ b/drivers/ntb/ntb_transport.c
> > @@ -76,7 +76,7 @@ static unsigned long max_mw_size;
> > module_param(max_mw_size, ulong, 0644);
> > MODULE_PARM_DESC(max_mw_size, "Limit size of large memory
> > windows");
> >
> > -static unsigned int transport_mtu = 0x401E;
> > +static unsigned int transport_mtu = 0x10000;
> > module_param(transport_mtu, uint, 0644);
> > MODULE_PARM_DESC(transport_mtu, "Maximum size of NTB transport
> > packets");
> >
> > --
> > 2.4.0.rc0.43.gcf8a8c6
> >
> > --
> > To unsubscribe from this list: send the line "unsubscribe linux
> > -pci" in
> > the body of a message to majordomo@vger.kernel.org
> > More majordomo info at http://vger.kernel.org/majordomo-info.html
> ÿôèº{.nÇ+‰·Ÿ®‰†+%ŠËÿ±éݶ\x17¥Šwÿº{.nÇ+‰·¥Š{±þG«éÿŠ{ayº\x1dʇڙë,j\a¢f£¢·hšïêÿ‘êçz_è®\x03(階ŠÝ¢j"ú\x1a¶^[m§ÿÿ¾\a«þG«éÿ¢¸?™¨èÚ&£ø§~á¶iO•æ¬z·švØ^\x14\x04\x1a¶^[m§ÿÿÃ\fÿ¶ìÿ¢¸?–I¥
next prev parent reply other threads:[~2015-06-09 16:45 UTC|newest]
Thread overview: 42+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-06-09 9:44 [PATCH v3 00/18] NTB: Add NTB hardware abstraction layer Allen Hubbe
2015-06-09 9:44 ` [PATCH v3 01/18] NTB: Move files in preparation for NTB abstraction Allen Hubbe
2015-06-09 16:16 ` Bjorn Helgaas
2015-06-09 16:42 ` Hubbe, Allen
2015-06-09 16:42 ` Hubbe, Allen
2015-06-09 16:42 ` Hubbe, Allen
2015-06-09 9:44 ` [PATCH v3 02/18] NTB: Add NTB hardware abstraction layer Allen Hubbe
2015-06-09 16:23 ` Bjorn Helgaas
2015-06-09 16:43 ` Hubbe, Allen
2015-06-09 16:43 ` Hubbe, Allen
2015-06-09 16:43 ` Hubbe, Allen
2015-06-09 16:53 ` Bjorn Helgaas
2015-06-09 17:32 ` Hubbe, Allen
2015-06-09 17:32 ` Hubbe, Allen
2015-06-09 17:32 ` Hubbe, Allen
2015-06-09 9:44 ` [PATCH v3 03/18] NTB: Read peer info from local SPAD in transport Allen Hubbe
2015-06-09 16:24 ` Bjorn Helgaas
2015-06-09 9:44 ` [PATCH v3 04/18] NTB: Enable link for Intel root port mode in probe Allen Hubbe
2015-06-09 9:44 ` [PATCH v3 05/18] NTB: Check the device ID to set errata flags Allen Hubbe
2015-06-09 9:44 ` [PATCH v3 06/18] NTB: Differentiate transport link down messages Allen Hubbe
2015-06-09 9:44 ` [PATCH v3 07/18] NTB: Do not advance transport RX on link down Allen Hubbe
2015-06-09 9:44 ` [PATCH v3 08/18] NTB: Reset transport QP link stats on down Allen Hubbe
2015-06-09 9:44 ` [PATCH v3 09/18] NTB: Add parameters for Intel SNB B2B addresses Allen Hubbe
2015-06-09 16:42 ` Bjorn Helgaas
2015-06-09 16:59 ` Hubbe, Allen
2015-06-09 16:59 ` Hubbe, Allen
2015-06-09 16:59 ` Hubbe, Allen
2015-06-09 9:44 ` [PATCH v3 10/18] NTB: Add ping pong test client Allen Hubbe
2015-06-09 9:44 ` [PATCH v3 11/18] NTB: Add tool " Allen Hubbe
2015-06-09 9:44 ` [PATCH v3 12/18] NTB: Rate limit ntb_qp_link_work Allen Hubbe
2015-06-09 9:44 ` [PATCH v3 13/18] NTB: Use NUMA memory and DMA chan in transport Allen Hubbe
2015-06-09 16:43 ` Bjorn Helgaas
2015-06-09 9:44 ` [PATCH v3 14/18] NTB: Use NUMA memory in Intel driver Allen Hubbe
2015-06-09 9:44 ` [PATCH v3 15/18] NTB: Improve performance with write combining Allen Hubbe
2015-06-09 16:46 ` Bjorn Helgaas
2015-06-09 9:44 ` [PATCH v3 16/18] NTB: Default to CPU memcpy for performance Allen Hubbe
2015-06-09 9:44 ` [PATCH v3 17/18] NTB: Rename intel hw to proper platform names Allen Hubbe
2015-06-09 9:44 ` [PATCH v3 18/18] NTB: Increase transport MTU to 64k from 16k Allen Hubbe
2015-06-09 16:04 ` Bjorn Helgaas
2015-06-09 16:45 ` Jiang, Dave [this message]
2015-06-09 16:45 ` Jiang, Dave
2015-06-09 16:45 ` Jiang, Dave
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1433868335.38406.111.camel@intel.com \
--to=dave.jiang@intel.com \
--cc=Allen.Hubbe@emc.com \
--cc=bhelgaas@google.com \
--cc=jdmason@kudzu.us \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-ntb@googlegroups.com \
--cc=linux-pci@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.