From: Tejun Heo <tj-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
To: axboe-tSWWG44O7X1aa/9Udqfwiw@public.gmane.org
Cc: linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
cgroups-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
vgoyal-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org,
avanzini.arianna-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org,
kernel-team-b10kYP2dOMg@public.gmane.org,
Tejun Heo <tj-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>,
Johannes Weiner <hannes-druUgvl0LCNAfugRpC6u6w@public.gmane.org>,
Li Zefan <lizefan-hv44wF8Li93QT0dZR+AlfA@public.gmane.org>
Subject: [PATCH 1/6] cgroup: make cftype->private a unsigned long
Date: Thu, 25 Jun 2015 17:38:52 -0400 [thread overview]
Message-ID: <1435268337-1738-2-git-send-email-tj@kernel.org> (raw)
In-Reply-To: <1435268337-1738-1-git-send-email-tj-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
It's pretty unusual to have an int as a private data field and it
makes it impossible to carray a pointer value through it. Let's make
it an unsigned long. AFAICS, this shouldn't break anything.
Signed-off-by: Tejun Heo <tj-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
Cc: Johannes Weiner <hannes-druUgvl0LCNAfugRpC6u6w@public.gmane.org>
Cc: Li Zefan <lizefan-hv44wF8Li93QT0dZR+AlfA@public.gmane.org>
---
include/linux/cgroup.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/include/linux/cgroup.h b/include/linux/cgroup.h
index e7da0aa..5571f9f 100644
--- a/include/linux/cgroup.h
+++ b/include/linux/cgroup.h
@@ -417,7 +417,7 @@ struct cftype {
* end of cftype array.
*/
char name[MAX_CFTYPE_NAME];
- int private;
+ unsigned long private;
/*
* If not 0, file mode is set to this value, otherwise it will
* be figured out automatically
--
2.4.3
WARNING: multiple messages have this Message-ID (diff)
From: Tejun Heo <tj@kernel.org>
To: axboe@kernel.dk
Cc: linux-kernel@vger.kernel.org, cgroups@vger.kernel.org,
vgoyal@redhat.com, avanzini.arianna@gmail.com,
kernel-team@fb.com, Tejun Heo <tj@kernel.org>,
Johannes Weiner <hannes@cmpxchg.org>,
Li Zefan <lizefan@huawei.com>
Subject: [PATCH 1/6] cgroup: make cftype->private a unsigned long
Date: Thu, 25 Jun 2015 17:38:52 -0400 [thread overview]
Message-ID: <1435268337-1738-2-git-send-email-tj@kernel.org> (raw)
In-Reply-To: <1435268337-1738-1-git-send-email-tj@kernel.org>
It's pretty unusual to have an int as a private data field and it
makes it impossible to carray a pointer value through it. Let's make
it an unsigned long. AFAICS, this shouldn't break anything.
Signed-off-by: Tejun Heo <tj@kernel.org>
Cc: Johannes Weiner <hannes@cmpxchg.org>
Cc: Li Zefan <lizefan@huawei.com>
---
include/linux/cgroup.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/include/linux/cgroup.h b/include/linux/cgroup.h
index e7da0aa..5571f9f 100644
--- a/include/linux/cgroup.h
+++ b/include/linux/cgroup.h
@@ -417,7 +417,7 @@ struct cftype {
* end of cftype array.
*/
char name[MAX_CFTYPE_NAME];
- int private;
+ unsigned long private;
/*
* If not 0, file mode is set to this value, otherwise it will
* be figured out automatically
--
2.4.3
next prev parent reply other threads:[~2015-06-25 21:38 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-06-25 21:38 [PATCHSET block/for-4.2/writeback] blkcg: blkcg stats cleanup Tejun Heo
2015-06-25 21:38 ` Tejun Heo
[not found] ` <1435268337-1738-1-git-send-email-tj-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
2015-06-25 21:38 ` Tejun Heo [this message]
2015-06-25 21:38 ` [PATCH 1/6] cgroup: make cftype->private a unsigned long Tejun Heo
[not found] ` <1435268337-1738-2-git-send-email-tj-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
2015-06-30 6:50 ` Zefan Li
2015-06-30 6:50 ` Zefan Li
2015-06-25 21:38 ` [PATCH 2/6] blkcg: add blkg_[rw]stat->aux_cnt and replace cfq_group->dead_stats with it Tejun Heo
2015-06-25 21:38 ` Tejun Heo
[not found] ` <1435268337-1738-3-git-send-email-tj-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
2015-06-26 13:27 ` Vivek Goyal
2015-06-26 13:27 ` Vivek Goyal
[not found] ` <20150626132702.GA14803-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
2015-06-26 13:35 ` Tejun Heo
2015-06-26 13:35 ` Tejun Heo
[not found] ` <20150626133540.GA15805-qYNAdHglDFBN0TnZuCh8vA@public.gmane.org>
2015-06-26 13:45 ` Vivek Goyal
2015-06-26 13:45 ` Vivek Goyal
[not found] ` <20150626134525.GB14803-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
2015-06-26 13:55 ` Tejun Heo
2015-06-26 13:55 ` Tejun Heo
2015-06-25 21:38 ` [PATCH 3/6] blkcg: make blkcg_[rw]stat per-cpu Tejun Heo
2015-06-25 21:38 ` Tejun Heo
2015-06-25 21:38 ` [PATCH 6/6] blkcg: remove cfqg_stats->sectors Tejun Heo
2015-06-25 21:38 ` Tejun Heo
2015-06-25 21:38 ` [PATCH 4/6] blkcg: make blkg_[rw]stat_recursive_sum() to be able to index into blkcg_gq Tejun Heo
2015-06-25 21:38 ` [PATCH 5/6] blkcg: move io_service_bytes and io_serviced stats " Tejun Heo
[not found] ` <1435268337-1738-6-git-send-email-tj-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
2015-06-26 16:01 ` Vivek Goyal
2015-06-26 16:01 ` Vivek Goyal
[not found] ` <20150626160142.GA24554-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
2015-06-26 16:09 ` Tejun Heo
2015-06-26 16:09 ` Tejun Heo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1435268337-1738-2-git-send-email-tj@kernel.org \
--to=tj-dgejt+ai2ygdnm+yrofe0a@public.gmane.org \
--cc=avanzini.arianna-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org \
--cc=axboe-tSWWG44O7X1aa/9Udqfwiw@public.gmane.org \
--cc=cgroups-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=hannes-druUgvl0LCNAfugRpC6u6w@public.gmane.org \
--cc=kernel-team-b10kYP2dOMg@public.gmane.org \
--cc=linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=lizefan-hv44wF8Li93QT0dZR+AlfA@public.gmane.org \
--cc=vgoyal-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.