All of lore.kernel.org
 help / color / mirror / Atom feed
From: Zefan Li <lizefan-hv44wF8Li93QT0dZR+AlfA@public.gmane.org>
To: Tejun Heo <tj-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
Cc: axboe-tSWWG44O7X1aa/9Udqfwiw@public.gmane.org,
	linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
	cgroups-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
	vgoyal-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org,
	avanzini.arianna-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org,
	kernel-team-b10kYP2dOMg@public.gmane.org,
	Johannes Weiner <hannes-druUgvl0LCNAfugRpC6u6w@public.gmane.org>
Subject: Re: [PATCH 1/6] cgroup: make cftype->private a unsigned long
Date: Tue, 30 Jun 2015 14:50:26 +0800	[thread overview]
Message-ID: <55923C32.4020909@huawei.com> (raw)
In-Reply-To: <1435268337-1738-2-git-send-email-tj-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>

On 2015/6/26 5:38, Tejun Heo wrote:
> It's pretty unusual to have an int as a private data field and it
> makes it impossible to carray a pointer value through it.  Let's make
> it an unsigned long.  AFAICS, this shouldn't break anything.
> 
> Signed-off-by: Tejun Heo <tj-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
> Cc: Johannes Weiner <hannes-druUgvl0LCNAfugRpC6u6w@public.gmane.org>
> Cc: Li Zefan <lizefan-hv44wF8Li93QT0dZR+AlfA@public.gmane.org>

Acked

WARNING: multiple messages have this Message-ID (diff)
From: Zefan Li <lizefan@huawei.com>
To: Tejun Heo <tj@kernel.org>
Cc: <axboe@kernel.dk>, <linux-kernel@vger.kernel.org>,
	<cgroups@vger.kernel.org>, <vgoyal@redhat.com>,
	<avanzini.arianna@gmail.com>, <kernel-team@fb.com>,
	Johannes Weiner <hannes@cmpxchg.org>
Subject: Re: [PATCH 1/6] cgroup: make cftype->private a unsigned long
Date: Tue, 30 Jun 2015 14:50:26 +0800	[thread overview]
Message-ID: <55923C32.4020909@huawei.com> (raw)
In-Reply-To: <1435268337-1738-2-git-send-email-tj@kernel.org>

On 2015/6/26 5:38, Tejun Heo wrote:
> It's pretty unusual to have an int as a private data field and it
> makes it impossible to carray a pointer value through it.  Let's make
> it an unsigned long.  AFAICS, this shouldn't break anything.
> 
> Signed-off-by: Tejun Heo <tj@kernel.org>
> Cc: Johannes Weiner <hannes@cmpxchg.org>
> Cc: Li Zefan <lizefan@huawei.com>

Acked

  parent reply	other threads:[~2015-06-30  6:50 UTC|newest]

Thread overview: 26+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-06-25 21:38 [PATCHSET block/for-4.2/writeback] blkcg: blkcg stats cleanup Tejun Heo
2015-06-25 21:38 ` Tejun Heo
     [not found] ` <1435268337-1738-1-git-send-email-tj-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
2015-06-25 21:38   ` [PATCH 1/6] cgroup: make cftype->private a unsigned long Tejun Heo
2015-06-25 21:38     ` Tejun Heo
     [not found]     ` <1435268337-1738-2-git-send-email-tj-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
2015-06-30  6:50       ` Zefan Li [this message]
2015-06-30  6:50         ` Zefan Li
2015-06-25 21:38   ` [PATCH 2/6] blkcg: add blkg_[rw]stat->aux_cnt and replace cfq_group->dead_stats with it Tejun Heo
2015-06-25 21:38     ` Tejun Heo
     [not found]     ` <1435268337-1738-3-git-send-email-tj-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
2015-06-26 13:27       ` Vivek Goyal
2015-06-26 13:27         ` Vivek Goyal
     [not found]         ` <20150626132702.GA14803-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
2015-06-26 13:35           ` Tejun Heo
2015-06-26 13:35             ` Tejun Heo
     [not found]             ` <20150626133540.GA15805-qYNAdHglDFBN0TnZuCh8vA@public.gmane.org>
2015-06-26 13:45               ` Vivek Goyal
2015-06-26 13:45                 ` Vivek Goyal
     [not found]                 ` <20150626134525.GB14803-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
2015-06-26 13:55                   ` Tejun Heo
2015-06-26 13:55                     ` Tejun Heo
2015-06-25 21:38   ` [PATCH 3/6] blkcg: make blkcg_[rw]stat per-cpu Tejun Heo
2015-06-25 21:38     ` Tejun Heo
2015-06-25 21:38   ` [PATCH 6/6] blkcg: remove cfqg_stats->sectors Tejun Heo
2015-06-25 21:38     ` Tejun Heo
2015-06-25 21:38 ` [PATCH 4/6] blkcg: make blkg_[rw]stat_recursive_sum() to be able to index into blkcg_gq Tejun Heo
2015-06-25 21:38 ` [PATCH 5/6] blkcg: move io_service_bytes and io_serviced stats " Tejun Heo
     [not found]   ` <1435268337-1738-6-git-send-email-tj-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
2015-06-26 16:01     ` Vivek Goyal
2015-06-26 16:01       ` Vivek Goyal
     [not found]       ` <20150626160142.GA24554-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
2015-06-26 16:09         ` Tejun Heo
2015-06-26 16:09           ` Tejun Heo

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=55923C32.4020909@huawei.com \
    --to=lizefan-hv44wf8li93qt0dzr+alfa@public.gmane.org \
    --cc=avanzini.arianna-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org \
    --cc=axboe-tSWWG44O7X1aa/9Udqfwiw@public.gmane.org \
    --cc=cgroups-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    --cc=hannes-druUgvl0LCNAfugRpC6u6w@public.gmane.org \
    --cc=kernel-team-b10kYP2dOMg@public.gmane.org \
    --cc=linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    --cc=tj-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org \
    --cc=vgoyal-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.