[PATCH] make rangeset_report_ranges() report all ranges

[PATCH] make rangeset_report_ranges() report all ranges

[Jan Beulich]

[-- Attachment #1: Type: text/plain, Size: 583 bytes --]

find_range() returns NULL when s is below the lowest range, so we have
to use first_range() here (which is as good performance wise).

Signed-off-by: Jan Beulich <jbeulich@suse.com>

--- a/xen/common/rangeset.c
+++ b/xen/common/rangeset.c
@@ -289,7 +289,7 @@ int rangeset_report_ranges(
 
     read_lock(&r->lock);
 
-    for ( x = find_range(r, s); x && (x->s <= e) && !rc; x = next_range(r, x) )
+    for ( x = first_range(r); x && (x->s <= e) && !rc; x = next_range(r, x) )
         if ( x->e >= s )
             rc = cb(max(x->s, s), min(x->e, e), ctxt);
 




[-- Attachment #2: rangeset-report-fix.patch --]
[-- Type: text/plain, Size: 628 bytes --]

make rangeset_report_ranges() report all ranges

find_range() returns NULL when s is below the lowest range, so we have
to use first_range() here (which is as good performance wise).

Signed-off-by: Jan Beulich <jbeulich@suse.com>

--- a/xen/common/rangeset.c
+++ b/xen/common/rangeset.c
@@ -289,7 +289,7 @@ int rangeset_report_ranges(
 
     read_lock(&r->lock);
 
-    for ( x = find_range(r, s); x && (x->s <= e) && !rc; x = next_range(r, x) )
+    for ( x = first_range(r); x && (x->s <= e) && !rc; x = next_range(r, x) )
         if ( x->e >= s )
             rc = cb(max(x->s, s), min(x->e, e), ctxt);
 

[-- Attachment #3: Type: text/plain, Size: 126 bytes --]

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
http://lists.xen.org/xen-devel

Re: [PATCH] make rangeset_report_ranges() report all ranges

[Ian Campbell]

On Wed, 2015-07-15 at 14:06 +0100, Jan Beulich wrote:
> find_range() returns NULL when s is below the lowest range, so we have
> to use first_range() here (which is as good performance wise).

The bug here was that the first range would be omitted under certain
conditions? Saying which here would be interesting.

> Signed-off-by: Jan Beulich <jbeulich@suse.com>

Acked-by: Ian Campbell <ian.campbell@citrix.com>

> 
> --- a/xen/common/rangeset.c
> +++ b/xen/common/rangeset.c
> @@ -289,7 +289,7 @@ int rangeset_report_ranges(
>  
>      read_lock(&r->lock);
>  
> -    for ( x = find_range(r, s); x && (x->s <= e) && !rc; x = next_range(r, x) )
> +    for ( x = first_range(r); x && (x->s <= e) && !rc; x = next_range(r, x) )
>          if ( x->e >= s )
>              rc = cb(max(x->s, s), min(x->e, e), ctxt);
>  
> 
> 
> 

Re: [PATCH] make rangeset_report_ranges() report all ranges

[Jan Beulich]

>>> On 15.07.15 at 15:43, <ian.campbell@citrix.com> wrote:
> On Wed, 2015-07-15 at 14:06 +0100, Jan Beulich wrote:
>> find_range() returns NULL when s is below the lowest range, so we have
>> to use first_range() here (which is as good performance wise).
> 
> The bug here was that the first range would be omitted under certain
> conditions? Saying which here would be interesting.

Not just omitted - the function would have reported nothing at all
in that case. No current user appears to be affected though, but
I have a new user now in the still pending MSI-X patch series that
was harmed.

Jan