From: Joe Perches <joe@perches.com>
To: Vinay Simha BN <simhavcs@gmail.com>
Cc: Sudip Mukherjee <sudipm.mukherjee@gmail.com>,
Teddy Wang <teddy.wang@siliconmotion.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
"open list:STAGING - SILICON MOTION SM750 FRAME BUFFER DRIVER"
<linux-fbdev@vger.kernel.org>,
"open list:STAGING SUBSYSTEM" <devel@driverdev.osuosl.org>,
open list <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] sm750fb: coding style fixes lines over 80 chars
Date: Thu, 16 Jul 2015 03:57:37 +0000 [thread overview]
Message-ID: <1437019057.16262.22.camel@perches.com> (raw)
In-Reply-To: <1436985972-5431-1-git-send-email-simhavcs@gmail.com>
On Thu, 2015-07-16 at 00:16 +0530, Vinay Simha BN wrote:
> scripts/checkpatch.pl kernel coding style fixes of WARNING
Please don't be a checkpatch robot.
Use tools to prompt your brain, but don't ever turn
your brain off.
> diff --git a/drivers/staging/sm750fb/ddk750_help.h b/drivers/staging/sm750fb/ddk750_help.h
> +/* if 718 big endian turned on,be aware that don't use this driver for general
> + use,only for ppc big-endian */
> +#warning "big endian on target cpu and enable nature big endian support of 718
> + capability !"
Yes, this if #if 0, but it's also obviously incorrect
I didn't look at the rest.
WARNING: multiple messages have this Message-ID (diff)
From: Joe Perches <joe@perches.com>
To: Vinay Simha BN <simhavcs@gmail.com>
Cc: Sudip Mukherjee <sudipm.mukherjee@gmail.com>,
Teddy Wang <teddy.wang@siliconmotion.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
"open list:STAGING - SILICON MOTION SM750 FRAME BUFFER DRIVER"
<linux-fbdev@vger.kernel.org>,
"open list:STAGING SUBSYSTEM" <devel@driverdev.osuosl.org>,
open list <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] sm750fb: coding style fixes lines over 80 chars
Date: Wed, 15 Jul 2015 20:57:37 -0700 [thread overview]
Message-ID: <1437019057.16262.22.camel@perches.com> (raw)
In-Reply-To: <1436985972-5431-1-git-send-email-simhavcs@gmail.com>
On Thu, 2015-07-16 at 00:16 +0530, Vinay Simha BN wrote:
> scripts/checkpatch.pl kernel coding style fixes of WARNING
Please don't be a checkpatch robot.
Use tools to prompt your brain, but don't ever turn
your brain off.
> diff --git a/drivers/staging/sm750fb/ddk750_help.h b/drivers/staging/sm750fb/ddk750_help.h
> +/* if 718 big endian turned on,be aware that don't use this driver for general
> + use,only for ppc big-endian */
> +#warning "big endian on target cpu and enable nature big endian support of 718
> + capability !"
Yes, this if #if 0, but it's also obviously incorrect
I didn't look at the rest.
next prev parent reply other threads:[~2015-07-16 3:57 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-07-15 18:46 [PATCH] sm750fb: coding style fixes lines over 80 chars Vinay Simha BN
2015-07-15 18:58 ` Vinay Simha BN
2015-07-16 3:57 ` Joe Perches [this message]
2015-07-16 3:57 ` Joe Perches
2015-07-17 7:16 ` Vinay Simha
2015-07-17 7:28 ` Vinay Simha
-- strict thread matches above, loose matches on Subject: below --
2015-07-17 7:28 Vinay Simha BN
2015-07-17 7:40 ` Vinay Simha BN
2015-07-17 7:38 ` Joe Perches
2015-07-17 7:38 ` Joe Perches
2015-07-21 6:44 ` [PATCH] sm750fb: coding style fixes in _accel.h,__help.h Vinay Simha BN
2015-07-21 6:56 ` Vinay Simha BN
2015-07-21 7:17 ` Sudip Mukherjee
2015-07-21 7:29 ` Sudip Mukherjee
[not found] ` <CAGWqDJ5AkG5PwQOkboZfiC1PzXw0j+x5zwaYn0SWWtiks+OP2A@mail.gmail.com>
2015-07-21 7:31 ` Sudip Mukherjee
2015-07-21 7:43 ` Sudip Mukherjee
2015-07-21 7:40 ` [PATCH 1/2] sm750fb: coding style fixes lines over 80 chars Vinay Simha BN
2015-07-21 7:52 ` Vinay Simha BN
2015-07-21 7:40 ` [PATCH 2/2] sm750fb: coding style fixes lines over 80 chars - v2 Vinay Simha BN
2015-07-21 7:52 ` Vinay Simha BN
2015-07-21 8:39 ` Dan Carpenter
2015-07-21 8:39 ` Dan Carpenter
2015-07-21 8:14 ` [PATCH 1/2] sm750fb: coding style fixes lines over 80 chars Joe Perches
2015-07-21 8:14 ` Joe Perches
2015-07-21 8:35 ` Dan Carpenter
2015-07-21 8:35 ` Dan Carpenter
[not found] ` <CAGWqDJ4dgrsYAiWXMKi2j1-kGoFhQ_rZGxuDuqpbfTG2P7bnsw@mail.gmail.com>
2015-07-27 5:24 ` [PATCH] " Sudip Mukherjee
2015-07-27 5:36 ` Sudip Mukherjee
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1437019057.16262.22.camel@perches.com \
--to=joe@perches.com \
--cc=devel@driverdev.osuosl.org \
--cc=gregkh@linuxfoundation.org \
--cc=linux-fbdev@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=simhavcs@gmail.com \
--cc=sudipm.mukherjee@gmail.com \
--cc=teddy.wang@siliconmotion.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.