From: Dan Carpenter <dan.carpenter@oracle.com>
To: Vinay Simha BN <simhavcs@gmail.com>
Cc: "open list:STAGING SUBSYSTEM" <devel@driverdev.osuosl.org>,
"open list:STAGING - SILICON MOTION SM750 FRAME BUFFER DRIVER"
<linux-fbdev@vger.kernel.org>,
Teddy Wang <teddy.wang@siliconmotion.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
open list <linux-kernel@vger.kernel.org>,
Sudip Mukherjee <sudipm.mukherjee@gmail.com>
Subject: Re: [PATCH 2/2] sm750fb: coding style fixes lines over 80 chars - v2
Date: Tue, 21 Jul 2015 08:39:23 +0000 [thread overview]
Message-ID: <20150721083923.GL5371@mwanda> (raw)
In-Reply-To: <1437464402-18451-2-git-send-email-simhavcs@gmail.com>
Slow down. This patch is totally wrong. You're panicking and sending
nonsense patches without a description or signed off by. It deletes
code. The v2 isn't where it should be [PATCH 2/2 v2].
There is no need to rush. Fix this and send the patch tomorrow.
regards,
dan carpenter
WARNING: multiple messages have this Message-ID (diff)
From: Dan Carpenter <dan.carpenter@oracle.com>
To: Vinay Simha BN <simhavcs@gmail.com>
Cc: "open list:STAGING SUBSYSTEM" <devel@driverdev.osuosl.org>,
"open list:STAGING - SILICON MOTION SM750 FRAME BUFFER DRIVER"
<linux-fbdev@vger.kernel.org>,
Teddy Wang <teddy.wang@siliconmotion.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
open list <linux-kernel@vger.kernel.org>,
Sudip Mukherjee <sudipm.mukherjee@gmail.com>
Subject: Re: [PATCH 2/2] sm750fb: coding style fixes lines over 80 chars - v2
Date: Tue, 21 Jul 2015 11:39:23 +0300 [thread overview]
Message-ID: <20150721083923.GL5371@mwanda> (raw)
In-Reply-To: <1437464402-18451-2-git-send-email-simhavcs@gmail.com>
Slow down. This patch is totally wrong. You're panicking and sending
nonsense patches without a description or signed off by. It deletes
code. The v2 isn't where it should be [PATCH 2/2 v2].
There is no need to rush. Fix this and send the patch tomorrow.
regards,
dan carpenter
next prev parent reply other threads:[~2015-07-21 8:39 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-07-17 7:28 [PATCH] sm750fb: coding style fixes lines over 80 chars Vinay Simha BN
2015-07-17 7:40 ` Vinay Simha BN
2015-07-17 7:38 ` Joe Perches
2015-07-17 7:38 ` Joe Perches
2015-07-21 6:44 ` [PATCH] sm750fb: coding style fixes in _accel.h,__help.h Vinay Simha BN
2015-07-21 6:56 ` Vinay Simha BN
2015-07-21 7:17 ` Sudip Mukherjee
2015-07-21 7:29 ` Sudip Mukherjee
[not found] ` <CAGWqDJ5AkG5PwQOkboZfiC1PzXw0j+x5zwaYn0SWWtiks+OP2A@mail.gmail.com>
2015-07-21 7:31 ` Sudip Mukherjee
2015-07-21 7:43 ` Sudip Mukherjee
2015-07-21 7:40 ` [PATCH 1/2] sm750fb: coding style fixes lines over 80 chars Vinay Simha BN
2015-07-21 7:52 ` Vinay Simha BN
2015-07-21 7:40 ` [PATCH 2/2] sm750fb: coding style fixes lines over 80 chars - v2 Vinay Simha BN
2015-07-21 7:52 ` Vinay Simha BN
2015-07-21 8:39 ` Dan Carpenter [this message]
2015-07-21 8:39 ` Dan Carpenter
2015-07-21 8:14 ` [PATCH 1/2] sm750fb: coding style fixes lines over 80 chars Joe Perches
2015-07-21 8:14 ` Joe Perches
2015-07-21 8:35 ` Dan Carpenter
2015-07-21 8:35 ` Dan Carpenter
[not found] ` <CAGWqDJ4dgrsYAiWXMKi2j1-kGoFhQ_rZGxuDuqpbfTG2P7bnsw@mail.gmail.com>
2015-07-27 5:24 ` [PATCH] " Sudip Mukherjee
2015-07-27 5:36 ` Sudip Mukherjee
-- strict thread matches above, loose matches on Subject: below --
2015-07-15 18:46 Vinay Simha BN
2015-07-15 18:58 ` Vinay Simha BN
2015-07-16 3:57 ` Joe Perches
2015-07-16 3:57 ` Joe Perches
2015-07-17 7:16 ` Vinay Simha
2015-07-17 7:28 ` Vinay Simha
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150721083923.GL5371@mwanda \
--to=dan.carpenter@oracle.com \
--cc=devel@driverdev.osuosl.org \
--cc=gregkh@linuxfoundation.org \
--cc=linux-fbdev@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=simhavcs@gmail.com \
--cc=sudipm.mukherjee@gmail.com \
--cc=teddy.wang@siliconmotion.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.