All of lore.kernel.org
 help / color / mirror / Atom feed
From: Yingjoe Chen <yingjoe.chen@mediatek.com>
To: Daniel Lezcano <daniel.lezcano@linaro.org>,
	Thomas Gleixner <tglx@linutronix.de>
Cc: Stephen Boyd <sboyd@codeaurora.org>,
	James Liao <jamesjj.liao@mediatek.com>,
	Russell King <linux@arm.linux.org.uk>,
	srv_heupstream <srv_heupstream@mediatek.com>,
	Arnd Bergmann <arnd@arndb.de>,
	"open list:OPEN FIRMWARE AND..." <devicetree@vger.kernel.org>,
	Catalin Marinas <catalin.marinas@arm.com>,
	Michael Turquette <mturquette@baylibre.com>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	"Matthias Brugger" <matthias.bgg@gmail.com>,
	Rob Herring <robh+dt@kernel.org>,
	<linux-mediatek@lists.infradead.org>,
	Sascha Hauer <kernel@pengutronix.de>,
	Olof Johansson <olof@lixom.net>, <linux-clk@vger.kernel.org>,
	"linux-arm-kernel@lists.infradead.org"
	<linux-arm-kernel@lists.infradead.org>,
	Daniel Kurtz <djkurtz@chromium.org>
Subject: Re: [PATCH v2 1/5] clocksource: mediatek: do not enable GPT_CLK_EVT when setup
Date: Fri, 31 Jul 2015 11:14:01 +0800	[thread overview]
Message-ID: <1438312441.26889.5.camel@mtksdaap41> (raw)
In-Reply-To: <1437552878-3684-1-git-send-email-yingjoe.chen@mediatek.com>

On Wed, 2015-07-22 at 16:14 +0800, Yingjoe Chen wrote:
> Spurious mtk timer interrupt is noticed at boot and cause kernel
> crash. It seems if GPT is enabled, it will latch irq status even
> when its IRQ is disabled. When irq is enabled afterward, we see
> spurious interrupt.
> Change init flow to only enable GPT_CLK_SRC at mtk_timer_init.
> 
> Acked-by: Matthias Brugger <matthias.bgg@gmail.com>
> Reviewed-by: Daniel Kurtz <djkurtz@chromium.org>
> Signed-off-by: Yingjoe Chen <yingjoe.chen@mediatek.com>
> ---
> Update to my patch [1], added __init as Daniel suggest. This is the
> only patch that need to change in that series, so I only sent this one.
> 
> http://lists.infradead.org/pipermail/linux-mediatek/2015-July/001545.html


Hi Daniel, Thomas,

Any suggestions for mtk_timer fixes in this series?
Should I resend and add tags from the reviewers?

Joe.C



WARNING: multiple messages have this Message-ID (diff)
From: Yingjoe Chen <yingjoe.chen-NuS5LvNUpcJWk0Htik3J/w@public.gmane.org>
To: Daniel Lezcano
	<daniel.lezcano-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>,
	Thomas Gleixner <tglx-hfZtesqFncYOwBW4kG4KsQ@public.gmane.org>
Cc: Stephen Boyd <sboyd-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org>,
	James Liao <jamesjj.liao-NuS5LvNUpcJWk0Htik3J/w@public.gmane.org>,
	Russell King <linux-lFZ/pmaqli7XmaaqVzeoHQ@public.gmane.org>,
	srv_heupstream
	<srv_heupstream-NuS5LvNUpcJWk0Htik3J/w@public.gmane.org>,
	Arnd Bergmann <arnd-r2nGTMty4D4@public.gmane.org>,
	"open list:OPEN FIRMWARE AND..."
	<devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>,
	Catalin Marinas <catalin.marinas-5wv7dgnIgG8@public.gmane.org>,
	Michael Turquette
	<mturquette-rdvid1DuHRBWk0Htik3J/w@public.gmane.org>,
	"linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org"
	<linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>,
	Matthias Brugger
	<matthias.bgg-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>,
	Rob Herring <robh+dt-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>,
	linux-mediatek-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org,
	Sascha Hauer <kernel-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org>,
	Olof Johansson <olof-nZhT3qVonbNeoWH0uzbU5w@public.gmane.org>,
	linux-clk-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
	"linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org"
	<linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org>,
	Daniel Kurtz <djkurtz-F7+t8E8rja9g9hUCZPvPmw@public.gmane.org>
Subject: Re: [PATCH v2 1/5] clocksource: mediatek: do not enable GPT_CLK_EVT when setup
Date: Fri, 31 Jul 2015 11:14:01 +0800	[thread overview]
Message-ID: <1438312441.26889.5.camel@mtksdaap41> (raw)
In-Reply-To: <1437552878-3684-1-git-send-email-yingjoe.chen-NuS5LvNUpcJWk0Htik3J/w@public.gmane.org>

On Wed, 2015-07-22 at 16:14 +0800, Yingjoe Chen wrote:
> Spurious mtk timer interrupt is noticed at boot and cause kernel
> crash. It seems if GPT is enabled, it will latch irq status even
> when its IRQ is disabled. When irq is enabled afterward, we see
> spurious interrupt.
> Change init flow to only enable GPT_CLK_SRC at mtk_timer_init.
> 
> Acked-by: Matthias Brugger <matthias.bgg-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
> Reviewed-by: Daniel Kurtz <djkurtz-F7+t8E8rja9g9hUCZPvPmw@public.gmane.org>
> Signed-off-by: Yingjoe Chen <yingjoe.chen-NuS5LvNUpcJWk0Htik3J/w@public.gmane.org>
> ---
> Update to my patch [1], added __init as Daniel suggest. This is the
> only patch that need to change in that series, so I only sent this one.
> 
> http://lists.infradead.org/pipermail/linux-mediatek/2015-July/001545.html


Hi Daniel, Thomas,

Any suggestions for mtk_timer fixes in this series?
Should I resend and add tags from the reviewers?

Joe.C


--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

WARNING: multiple messages have this Message-ID (diff)
From: yingjoe.chen@mediatek.com (Yingjoe Chen)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v2 1/5] clocksource: mediatek: do not enable GPT_CLK_EVT when setup
Date: Fri, 31 Jul 2015 11:14:01 +0800	[thread overview]
Message-ID: <1438312441.26889.5.camel@mtksdaap41> (raw)
In-Reply-To: <1437552878-3684-1-git-send-email-yingjoe.chen@mediatek.com>

On Wed, 2015-07-22 at 16:14 +0800, Yingjoe Chen wrote:
> Spurious mtk timer interrupt is noticed at boot and cause kernel
> crash. It seems if GPT is enabled, it will latch irq status even
> when its IRQ is disabled. When irq is enabled afterward, we see
> spurious interrupt.
> Change init flow to only enable GPT_CLK_SRC at mtk_timer_init.
> 
> Acked-by: Matthias Brugger <matthias.bgg@gmail.com>
> Reviewed-by: Daniel Kurtz <djkurtz@chromium.org>
> Signed-off-by: Yingjoe Chen <yingjoe.chen@mediatek.com>
> ---
> Update to my patch [1], added __init as Daniel suggest. This is the
> only patch that need to change in that series, so I only sent this one.
> 
> http://lists.infradead.org/pipermail/linux-mediatek/2015-July/001545.html


Hi Daniel, Thomas,

Any suggestions for mtk_timer fixes in this series?
Should I resend and add tags from the reviewers?

Joe.C

  reply	other threads:[~2015-07-31  3:14 UTC|newest]

Thread overview: 111+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-07-13  9:32 [PATCH 0/5] add GPT timer support for mt8173 Yingjoe Chen
2015-07-13  9:32 ` Yingjoe Chen
2015-07-13  9:32 ` Yingjoe Chen
2015-07-13  9:32 ` [PATCH 1/5] clocksource: mediatek: do not enable GPT_CLK_EVT when setup Yingjoe Chen
2015-07-13  9:32   ` Yingjoe Chen
2015-07-13  9:32   ` Yingjoe Chen
2015-07-14  7:39   ` Daniel Kurtz
2015-07-14  7:39     ` Daniel Kurtz
2015-07-22  8:14     ` [PATCH v2 " Yingjoe Chen
2015-07-22  8:14       ` Yingjoe Chen
2015-07-22  8:14       ` Yingjoe Chen
2015-07-31  3:14       ` Yingjoe Chen [this message]
2015-07-31  3:14         ` Yingjoe Chen
2015-07-31  3:14         ` Yingjoe Chen
2015-08-13  8:35       ` Daniel Lezcano
2015-08-13  8:35         ` Daniel Lezcano
2015-08-17 14:10         ` Yingjoe Chen
2015-08-17 14:10           ` Yingjoe Chen
2015-08-17 14:10           ` Yingjoe Chen
2015-08-20 14:28           ` Daniel Lezcano
2015-08-20 14:28             ` Daniel Lezcano
2015-08-21 14:39             ` Yingjoe Chen
2015-08-21 14:39               ` Yingjoe Chen
2015-08-21 14:39               ` Yingjoe Chen
2015-08-24  7:51               ` Daniel Lezcano
2015-08-24  7:51                 ` Daniel Lezcano
2015-08-24  7:51                 ` Daniel Lezcano
2015-08-24 14:22                 ` Yingjoe Chen
2015-08-24 14:22                   ` Yingjoe Chen
2015-08-24 14:22                   ` Yingjoe Chen
2015-08-24 13:30               ` [PATCH] clockevents/drivers/mtk: Fix spurious interrupt leading to crash Daniel Lezcano
2015-08-24 13:30                 ` Daniel Lezcano
2015-08-24 13:30                 ` Daniel Lezcano
2015-08-24 14:35                 ` Yingjoe Chen
2015-08-24 14:35                   ` Yingjoe Chen
2015-08-24 14:35                   ` Yingjoe Chen
2015-08-24 21:57                   ` [PATCH V2] " Daniel Lezcano
2015-08-24 21:57                     ` Daniel Lezcano
2015-08-24 21:57                     ` Daniel Lezcano
2015-08-25 13:21                     ` Yingjoe Chen
2015-08-25 13:21                       ` Yingjoe Chen
2015-08-25 13:21                       ` Yingjoe Chen
2015-08-26 14:25                       ` Daniel Lezcano
2015-08-26 14:25                         ` Daniel Lezcano
2015-09-04  7:15                         ` Yingjoe Chen
2015-09-04  7:15                           ` Yingjoe Chen
2015-09-04  7:15                           ` Yingjoe Chen
2015-09-04  7:36                           ` Daniel Lezcano
2015-09-04  7:36                             ` Daniel Lezcano
2015-10-27 11:11                         ` Matthias Brugger
2015-10-27 11:11                           ` Matthias Brugger
     [not found]                           ` <562F5BE9.30200-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2015-10-27 11:23                             ` Daniel Lezcano
2015-10-27 11:23                               ` Daniel Lezcano
2015-10-27 11:23                               ` Daniel Lezcano
2015-10-27 11:47                               ` Daniel Lezcano
2015-10-27 11:47                                 ` Daniel Lezcano
2015-07-22  8:24     ` [PATCH 1/5] clocksource: mediatek: do not enable GPT_CLK_EVT when setup Yingjoe Chen
2015-07-22  8:24       ` Yingjoe Chen
2015-07-22  8:24       ` Yingjoe Chen
2015-07-17 21:56   ` Matthias Brugger
2015-07-17 21:56     ` Matthias Brugger
2015-07-17 21:56     ` Matthias Brugger
2015-07-13  9:32 ` [PATCH 2/5] clocksource: mediatek: Use GPT as sched clock source Yingjoe Chen
2015-07-13  9:32   ` Yingjoe Chen
2015-07-13  9:32   ` Yingjoe Chen
2015-07-14  0:40   ` Stephen Boyd
2015-07-14  0:40     ` Stephen Boyd
2015-07-14  0:40     ` Stephen Boyd
2015-07-17 21:49   ` Matthias Brugger
2015-07-17 21:49     ` Matthias Brugger
2015-07-17 21:49     ` Matthias Brugger
2015-07-13  9:32 ` [PATCH 3/5] arm64: mediatek: enable MTK_TIMER Yingjoe Chen
2015-07-13  9:32   ` Yingjoe Chen
2015-07-13  9:32   ` Yingjoe Chen
2015-07-17 21:54   ` Matthias Brugger
2015-07-17 21:54     ` Matthias Brugger
2015-07-18  7:31     ` Thomas Gleixner
2015-07-18  7:31       ` Thomas Gleixner
2015-07-18  7:31       ` Thomas Gleixner
2015-07-21  7:52       ` Matthias Brugger
2015-07-21  7:52         ` Matthias Brugger
2015-07-21  7:52         ` Matthias Brugger
2015-07-13  9:32 ` [PATCH 4/5] clk: mediatek: add 13mhz clock for MT8173 Yingjoe Chen
2015-07-13  9:32   ` Yingjoe Chen
2015-07-13  9:32   ` Yingjoe Chen
2015-07-14  0:40   ` Stephen Boyd
2015-07-14  0:40     ` Stephen Boyd
2015-07-14  0:40     ` Stephen Boyd
2015-07-14  7:34   ` Daniel Kurtz
2015-07-14  7:34     ` Daniel Kurtz
2015-07-14  7:34     ` Daniel Kurtz
2015-07-13  9:32 ` [PATCH 5/5] arm64: dts: mt8173: add timer node Yingjoe Chen
2015-07-13  9:32   ` Yingjoe Chen
2015-07-13  9:32   ` Yingjoe Chen
2015-07-14  4:26   ` Daniel Kurtz
2015-07-14  4:26     ` Daniel Kurtz
2015-07-14  4:27     ` Daniel Kurtz
2015-07-14  4:27       ` Daniel Kurtz
2015-07-14  4:27       ` Daniel Kurtz
2015-08-11 15:54 ` [PATCH 0/5] add GPT timer support for mt8173 Daniel Kurtz
2015-08-11 15:54   ` Daniel Kurtz
2015-08-12 12:32   ` Daniel Lezcano
2015-08-12 12:32     ` Daniel Lezcano
2015-08-13  4:49     ` Daniel Kurtz
2015-08-13  4:49       ` Daniel Kurtz
2015-08-13  4:49       ` Daniel Kurtz
2015-08-26  7:37 ` Daniel Lezcano
2015-08-26  7:37   ` Daniel Lezcano
2015-08-26 14:10   ` Yingjoe Chen
2015-08-26 14:10     ` Yingjoe Chen
2015-08-26 14:10     ` Yingjoe Chen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1438312441.26889.5.camel@mtksdaap41 \
    --to=yingjoe.chen@mediatek.com \
    --cc=arnd@arndb.de \
    --cc=catalin.marinas@arm.com \
    --cc=daniel.lezcano@linaro.org \
    --cc=devicetree@vger.kernel.org \
    --cc=djkurtz@chromium.org \
    --cc=jamesjj.liao@mediatek.com \
    --cc=kernel@pengutronix.de \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-clk@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mediatek@lists.infradead.org \
    --cc=linux@arm.linux.org.uk \
    --cc=matthias.bgg@gmail.com \
    --cc=mturquette@baylibre.com \
    --cc=olof@lixom.net \
    --cc=robh+dt@kernel.org \
    --cc=sboyd@codeaurora.org \
    --cc=srv_heupstream@mediatek.com \
    --cc=tglx@linutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.