All of lore.kernel.org
 help / color / mirror / Atom feed
* Re: [osstest test] 60149: regressions - FAIL
       [not found] <osstest-60149-mainreport@xen.org>
@ 2015-07-31  6:40 ` Ian Campbell
  2015-07-31  8:49   ` Ian Campbell
  2015-07-31  9:47   ` Ian Campbell
  0 siblings, 2 replies; 7+ messages in thread
From: Ian Campbell @ 2015-07-31  6:40 UTC (permalink / raw)
  To: osstest service owner, Wei Liu; +Cc: xen-devel

On Fri, 2015-07-31 at 05:01 +0000, osstest service owner wrote:
> flight 60149 osstest real [real]
> http://logs.test-lab.xenproject.org/osstest/logs/60149/
> 
> Regressions :-(
> 
> Tests which did not succeed and are blocking,
> including tests which could not be run:
>  build-i386-libvirt            5 libvirt-build             fail REGR. vs. 60083
>  build-amd64-libvirt           5 libvirt-build             fail REGR. vs. 60083
>  build-armhf-libvirt           5 libvirt-build             fail REGR. vs. 60083

Pretest contains the libvirt testing from Wei (ccd)

One of the libvirt self tests failed:
TEST: virshtest
      !!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!! 40 
      !!!!!!!!!!!!                             52  FAIL
FAIL: virshtest
[...]
=======================================
1 of 114 tests failed
(1 test was not run)
Please report to libvir-list@redhat.com
=======================================

Which isn't a lot to go on, aside frmo fixing this issue do we need to
gather more logs?

>  test-amd64-i386-qemut-rhel6hvm-amd  9 redhat-install      fail REGR. vs. 60083

2015-07-30 23:02:32 Z execution took 71 seconds[<=2x600]: timeout 630 ssh -o StrictHostKeyChecking=no -o BatchMode=yes -o ConnectTimeout=100 -o ServerAliveInterval=100 -o PasswordAuthentication=no -o ChallengeResponseAuthentication=no -o UserKnownHostsFile=tmp/t.known_hosts_60149.test-amd64-i386-qemuu-rhel6hvm-amd root@172.16.144.35         mkdir -p /root/60149.test-amd64-i386-qemuu-rhel6hvm-amd.redhat-newiso
        genisoimage -R -J -T -b isolinux/isolinux.bin -c isolinux/boot.cat -no-emul-boot -boot-load-size 4 -boot-info-table -o /root/60149.test-amd64-i386-qemuu-rhel6hvm-amd.rhel-server-6.1-i386-dvd.iso /root/60149.test-amd64-i386-qemuu-rhel6hvm-amd.redhat-newiso/.
Use of uninitialized value in pattern match (m//) at Osstest/TestSupport.pm line 1736.
2015-07-30 23:02:32 Z runvar store: redhat_cfgpath=/etc/xen/redhat.guest.osstest.cfg
2015-07-30 23:02:32 Z executing scp ... /home/logs/logs/60149/test-amd64-i386-qemuu-rhel6hvm-amd/pinot1--redhat.guest.osstest.cfg root@172.16.144.35:/etc/xen/redhat.guest.osstest.cfg
2015-07-30 23:02:33 Z executing ssh ... root@172.16.144.35         (echo xenvnc; echo xenvnc) | vncpasswd redhat.vncpw
2015-07-30 23:02:33 Z executing ssh ... root@172.16.144.35 readlink /dev/pinot1/redhat.guest.osstest-disk
2015-07-30 23:02:33 Z executing ssh ... root@172.16.144.35 lvdisplay --colon /dev/pinot1/redhat.guest.osstest-disk
Can't call method "create" on unblessed reference at Osstest/TestSupport.pm line 1436.

Presumably relating to some refactoring done?

>  test-amd64-amd64-xl-qemut-win7-amd64  9 windows-install   fail REGR. vs. 60083
>  test-amd64-i386-qemuu-rhel6hvm-amd  9 redhat-install      fail REGR. vs. 60083
>  test-amd64-amd64-xl-qemut-winxpsp3  9 windows-install     fail REGR. vs. 60083
>  test-amd64-i386-xl-qemut-win7-amd64  9 windows-install    fail REGR. vs. 60083
>  test-amd64-i386-xl-qemuu-win7-amd64  9 windows-install    fail REGR. vs. 60083
>  test-amd64-amd64-amd64-pvgrub 10 guest-start              fail REGR. vs. 60083
>  test-amd64-i386-xl-qemut-winxpsp3  9 windows-install      fail REGR. vs. 60083
>  test-amd64-i386-xl-qemut-winxpsp3-vcpus1 9 windows-install fail REGR. vs. 60083
>  test-amd64-i386-qemuu-rhel6hvm-intel  9 redhat-install    fail REGR. vs. 60083
>  test-amd64-i386-qemut-rhel6hvm-intel  9 redhat-install    fail REGR. vs. 60083
>  test-amd64-i386-xl-qemuu-winxpsp3-vcpus1 9 windows-install fail REGR. vs. 60083
>  test-amd64-amd64-xl-qemuu-win7-amd64  9 windows-install   fail REGR. vs. 60083
>  test-amd64-amd64-xl-qemuu-winxpsp3  9 windows-install     fail REGR. vs. 60083
>  test-amd64-i386-xl-qemuu-winxpsp3  9 windows-install      fail REGR. vs. 60083
> 
> Regressions which are regarded as allowable (not blocking):
>  test-armhf-armhf-xl-rtds     11 guest-start                  fail   like 60083
>  test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm 9 debian-hvm-install fail like 60083
>  test-amd64-i386-xl-qemut-debianhvm-amd64 12 guest-saverestore  fail like 60083
>  test-amd64-i386-xl-qemuu-ovmf-amd64 12 guest-saverestore       fail like 60083
> 
> Tests which did not succeed, but are not blocking:
>  test-amd64-amd64-libvirt-pair  1 build-check(1)               blocked  n/a
>  test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 1 build-check(1) blocked n/a
>  test-amd64-i386-libvirt-pair  1 build-check(1)               blocked  n/a
>  test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 1 build-check(1) blocked n/a
>  test-armhf-armhf-libvirt-raw  1 build-check(1)               blocked  n/a
>  test-armhf-armhf-libvirt-qcow2  1 build-check(1)               blocked  n/a
>  test-amd64-amd64-libvirt-xsm  1 build-check(1)               blocked  n/a
>  test-armhf-armhf-libvirt-vhd  1 build-check(1)               blocked  n/a
>  test-armhf-armhf-libvirt-xsm  1 build-check(1)               blocked  n/a
>  test-amd64-i386-libvirt-xsm   1 build-check(1)               blocked  n/a
>  test-amd64-i386-libvirt       1 build-check(1)               blocked  n/a
>  test-amd64-amd64-libvirt      1 build-check(1)               blocked  n/a
>  test-amd64-i386-libvirt-raw   1 build-check(1)               blocked  n/a
>  test-amd64-amd64-libvirt-vhd  1 build-check(1)               blocked  n/a
>  test-amd64-i386-libvirt-qcow2  1 build-check(1)               blocked  n/a
>  test-amd64-amd64-libvirt-qcow2  1 build-check(1)               blocked  n/a
>  test-amd64-i386-libvirt-vhd   1 build-check(1)               blocked  n/a
>  test-armhf-armhf-libvirt      1 build-check(1)               blocked  n/a
>  test-amd64-amd64-libvirt-raw  1 build-check(1)               blocked  n/a
>  test-armhf-armhf-xl-qcow2     9 debian-di-install            fail   never pass
>  test-amd64-amd64-xl-pvh-amd  11 guest-start                  fail   never pass
>  test-armhf-armhf-xl-xsm      13 saverestore-support-check    fail   never pass
>  test-armhf-armhf-xl-xsm      12 migrate-support-check        fail   never pass
>  test-armhf-armhf-xl          12 migrate-support-check        fail   never pass
>  test-armhf-armhf-xl          13 saverestore-support-check    fail   never pass
>  test-armhf-armhf-xl-arndale  12 migrate-support-check        fail   never pass
>  test-armhf-armhf-xl-arndale  13 saverestore-support-check    fail   never pass
>  test-armhf-armhf-xl-raw       9 debian-di-install            fail   never pass
>  test-armhf-armhf-xl-cubietruck 12 migrate-support-check        fail never pass
>  test-armhf-armhf-xl-cubietruck 13 saverestore-support-check    fail never pass
>  test-armhf-armhf-xl-vhd       9 debian-di-install            fail   never pass
>  test-armhf-armhf-xl-credit2  13 saverestore-support-check    fail   never pass
>  test-armhf-armhf-xl-credit2  12 migrate-support-check        fail   never pass
>  test-amd64-amd64-xl-pvh-intel 11 guest-start                  fail  never pass
>  test-armhf-armhf-xl-multivcpu 13 saverestore-support-check    fail  never pass
>  test-armhf-armhf-xl-multivcpu 12 migrate-support-check        fail  never pass
> 
> version targeted for testing:
>  osstest              81cbee6666d45f382b14ac305180c3fe23895e92
> baseline version:
>  osstest              aad948fb77a04b4654d99cbe7762961261099054
> 
> Last test of basis    60083  2015-07-28 15:38:48 Z    2 days
> Testing same since    60149  2015-07-30 18:38:52 Z    0 days    1 attempts
> 
> jobs:
>  build-amd64-xsm                                              pass   
>  build-armhf-xsm                                              pass   
>  build-i386-xsm                                               pass   
>  build-amd64                                                  pass   
>  build-armhf                                                  pass   
>  build-i386                                                   pass   
>  build-amd64-libvirt                                          fail   
>  build-armhf-libvirt                                          fail   
>  build-i386-libvirt                                           fail   
>  build-amd64-pvops                                            pass   
>  build-armhf-pvops                                            pass   
>  build-i386-pvops                                             pass   
>  build-amd64-rumpuserxen                                      pass   
>  build-i386-rumpuserxen                                       pass   
>  test-amd64-amd64-xl                                          pass   
>  test-armhf-armhf-xl                                          pass   
>  test-amd64-i386-xl                                           pass   
>  test-amd64-amd64-xl-qemut-debianhvm-amd64-xsm                pass   
>  test-amd64-i386-xl-qemut-debianhvm-amd64-xsm                 pass   
>  test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm           blocked 
>  test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm            blocked 
>  test-amd64-amd64-xl-qemuu-debianhvm-amd64-xsm                pass   
>  test-amd64-i386-xl-qemuu-debianhvm-amd64-xsm                 pass   
>  test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm        pass   
>  test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm         fail   
>  test-amd64-amd64-libvirt-xsm                                 blocked 
>  test-armhf-armhf-libvirt-xsm                                 blocked 
>  test-amd64-i386-libvirt-xsm                                  blocked 
>  test-amd64-amd64-xl-xsm                                      pass   
>  test-armhf-armhf-xl-xsm                                      pass   
>  test-amd64-i386-xl-xsm                                       pass   
>  test-amd64-amd64-xl-pvh-amd                                  fail   
>  test-amd64-i386-qemut-rhel6hvm-amd                           fail   
>  test-amd64-i386-qemuu-rhel6hvm-amd                           fail   
>  test-amd64-amd64-xl-qemut-debianhvm-amd64                    pass   
>  test-amd64-i386-xl-qemut-debianhvm-amd64                     fail   
>  test-amd64-amd64-xl-qemuu-debianhvm-amd64                    pass   
>  test-amd64-i386-xl-qemuu-debianhvm-amd64                     pass   
>  test-amd64-i386-freebsd10-amd64                              pass   
>  test-amd64-amd64-xl-qemuu-ovmf-amd64                         pass   
>  test-amd64-i386-xl-qemuu-ovmf-amd64                          fail   
>  test-amd64-amd64-rumpuserxen-amd64                           pass   
>  test-amd64-amd64-xl-qemut-win7-amd64                         fail   
>  test-amd64-i386-xl-qemut-win7-amd64                          fail   
>  test-amd64-amd64-xl-qemuu-win7-amd64                         fail   
>  test-amd64-i386-xl-qemuu-win7-amd64                          fail   
>  test-armhf-armhf-xl-arndale                                  pass   
>  test-amd64-amd64-xl-credit2                                  pass   
>  test-armhf-armhf-xl-credit2                                  pass   
>  test-armhf-armhf-xl-cubietruck                               pass   
>  test-amd64-i386-freebsd10-i386                               pass   
>  test-amd64-i386-rumpuserxen-i386                             pass   
>  test-amd64-amd64-xl-pvh-intel                                fail   
>  test-amd64-i386-qemut-rhel6hvm-intel                         fail   
>  test-amd64-i386-qemuu-rhel6hvm-intel                         fail   
>  test-amd64-amd64-libvirt                                     blocked 
>  test-armhf-armhf-libvirt                                     blocked 
>  test-amd64-i386-libvirt                                      blocked 
>  test-amd64-amd64-xl-multivcpu                                pass   
>  test-armhf-armhf-xl-multivcpu                                pass   
>  test-amd64-amd64-pair                                        pass   
>  test-amd64-i386-pair                                         pass   
>  test-amd64-amd64-libvirt-pair                                blocked 
>  test-amd64-i386-libvirt-pair                                 blocked 
>  test-amd64-amd64-amd64-pvgrub                                fail   
>  test-amd64-amd64-i386-pvgrub                                 pass   
>  test-amd64-amd64-pygrub                                      pass   
>  test-amd64-amd64-libvirt-qcow2                               blocked 
>  test-armhf-armhf-libvirt-qcow2                               blocked 
>  test-amd64-i386-libvirt-qcow2                                blocked 
>  test-amd64-amd64-xl-qcow2                                    pass   
>  test-armhf-armhf-xl-qcow2                                    fail   
>  test-amd64-i386-xl-qcow2                                     pass   
>  test-amd64-amd64-libvirt-raw                                 blocked 
>  test-armhf-armhf-libvirt-raw                                 blocked 
>  test-amd64-i386-libvirt-raw                                  blocked 
>  test-amd64-amd64-xl-raw                                      pass   
>  test-armhf-armhf-xl-raw                                      fail   
>  test-amd64-i386-xl-raw                                       pass   
>  test-amd64-amd64-xl-rtds                                     pass   
>  test-armhf-armhf-xl-rtds                                     fail   
>  test-amd64-i386-xl-qemut-winxpsp3-vcpus1                     fail   
>  test-amd64-i386-xl-qemuu-winxpsp3-vcpus1                     fail   
>  test-amd64-amd64-libvirt-vhd                                 blocked 
>  test-armhf-armhf-libvirt-vhd                                 blocked 
>  test-amd64-i386-libvirt-vhd                                  blocked 
>  test-amd64-amd64-xl-vhd                                      pass   
>  test-armhf-armhf-xl-vhd                                      fail   
>  test-amd64-i386-xl-vhd                                       pass   
>  test-amd64-amd64-xl-qemut-winxpsp3                           fail   
>  test-amd64-i386-xl-qemut-winxpsp3                            fail   
>  test-amd64-amd64-xl-qemuu-winxpsp3                           fail   
>  test-amd64-i386-xl-qemuu-winxpsp3                            fail   
> 
> 
> ------------------------------------------------------------
> sg-report-flight on osstest.test-lab.xenproject.org
> logs: /home/logs/logs
> images: /home/logs/images
> 
> Logs, config files, etc. are available at
>     http://logs.test-lab.xenproject.org/osstest/logs
> 
> Explanation of these reports, and of osstest in general, is at
>     http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master
>     http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master
> 
> Test harness code can be found at
>     http://xenbits.xen.org/gitweb?p=osstest.git;a=summary
> 
> 
> Not pushing.
> 

^ permalink raw reply	[flat|nested] 7+ messages in thread

* Re: [osstest test] 60149: regressions - FAIL
  2015-07-31  6:40 ` [osstest test] 60149: regressions - FAIL Ian Campbell
@ 2015-07-31  8:49   ` Ian Campbell
  2015-07-31  8:50     ` Wei Liu
  2015-07-31  9:47   ` Ian Campbell
  1 sibling, 1 reply; 7+ messages in thread
From: Ian Campbell @ 2015-07-31  8:49 UTC (permalink / raw)
  To: osstest service owner, Wei Liu; +Cc: xen-devel

On Fri, 2015-07-31 at 07:40 +0100, Ian Campbell wrote:
> On Fri, 2015-07-31 at 05:01 +0000, osstest service owner wrote:
> > flight 60149 osstest real [real]
> > http://logs.test-lab.xenproject.org/osstest/logs/60149/
> > 
> > Regressions :-(
> > 
> > Tests which did not succeed and are blocking,
> > including tests which could not be run:
> >  build-i386-libvirt            5 libvirt-build             fail REGR. 
> > vs. 60083
> >  build-amd64-libvirt           5 libvirt-build             fail REGR. 
> > vs. 60083
> >  build-armhf-libvirt           5 libvirt-build             fail REGR. 
> > vs. 60083
> 
> Pretest contains the libvirt testing from Wei (ccd)
> 
> One of the libvirt self tests failed:
> TEST: virshtest
>       !!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!! 40 
>       !!!!!!!!!!!!                             52  FAIL
> FAIL: virshtest
> [...]
> =======================================
> 1 of 114 tests failed
> (1 test was not run)
> Please report to libvir-list@redhat.com
> =======================================
> 
> Which isn't a lot to go on, aside frmo fixing this issue do we need to
> gather more logs?

Shall we drop "ts-libvirt-build: run libvirt test suite" from pretest for
the time being? It seems a bit orthogonal to the rest of the series anyway.

Ian.

^ permalink raw reply	[flat|nested] 7+ messages in thread

* Re: [osstest test] 60149: regressions - FAIL
  2015-07-31  8:49   ` Ian Campbell
@ 2015-07-31  8:50     ` Wei Liu
  0 siblings, 0 replies; 7+ messages in thread
From: Wei Liu @ 2015-07-31  8:50 UTC (permalink / raw)
  To: Ian Campbell; +Cc: Wei Liu, osstest service owner, xen-devel

On Fri, Jul 31, 2015 at 09:49:30AM +0100, Ian Campbell wrote:
> On Fri, 2015-07-31 at 07:40 +0100, Ian Campbell wrote:
> > On Fri, 2015-07-31 at 05:01 +0000, osstest service owner wrote:
> > > flight 60149 osstest real [real]
> > > http://logs.test-lab.xenproject.org/osstest/logs/60149/
> > > 
> > > Regressions :-(
> > > 
> > > Tests which did not succeed and are blocking,
> > > including tests which could not be run:
> > >  build-i386-libvirt            5 libvirt-build             fail REGR. 
> > > vs. 60083
> > >  build-amd64-libvirt           5 libvirt-build             fail REGR. 
> > > vs. 60083
> > >  build-armhf-libvirt           5 libvirt-build             fail REGR. 
> > > vs. 60083
> > 
> > Pretest contains the libvirt testing from Wei (ccd)
> > 
> > One of the libvirt self tests failed:
> > TEST: virshtest
> >       !!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!! 40 
> >       !!!!!!!!!!!!                             52  FAIL
> > FAIL: virshtest
> > [...]
> > =======================================
> > 1 of 114 tests failed
> > (1 test was not run)
> > Please report to libvir-list@redhat.com
> > =======================================
> > 
> > Which isn't a lot to go on, aside frmo fixing this issue do we need to
> > gather more logs?
> 
> Shall we drop "ts-libvirt-build: run libvirt test suite" from pretest for
> the time being? It seems a bit orthogonal to the rest of the series anyway.
> 

Yes, that's fine.

Wei.

> Ian.

^ permalink raw reply	[flat|nested] 7+ messages in thread

* Re: [osstest test] 60149: regressions - FAIL
  2015-07-31  6:40 ` [osstest test] 60149: regressions - FAIL Ian Campbell
  2015-07-31  8:49   ` Ian Campbell
@ 2015-07-31  9:47   ` Ian Campbell
  2015-07-31  9:54     ` Ian Campbell
  2015-07-31  9:54     ` Wei Liu
  1 sibling, 2 replies; 7+ messages in thread
From: Ian Campbell @ 2015-07-31  9:47 UTC (permalink / raw)
  To: osstest service owner, Wei Liu; +Cc: xen-devel

On Fri, 2015-07-31 at 07:40 +0100, Ian Campbell wrote:
> 
> >  test-amd64-i386-qemut-rhel6hvm-amd  9 redhat-install      fail REGR.
> > vs. 60083
> 
> 2015-07-30 23:02:32 Z execution took 71 seconds[<=2x600]: timeout 630 ssh 
> -o StrictHostKeyChecking=no -o BatchMode=yes -o ConnectTimeout=100 -o 
> ServerAliveInterval=100 -o PasswordAuthentication=no -o 
> ChallengeResponseAuthentication=no -o 
> UserKnownHostsFile=tmp/t.known_hosts_60149.test-amd64-i386-qemuu-rhel6hvm
> -amd root@172.16.144.35         mkdir -p /root/60149.test-amd64-i386
> -qemuu-rhel6hvm-amd.redhat-newiso
>         genisoimage -R -J -T -b isolinux/isolinux.bin -c 
> isolinux/boot.cat -no-emul-boot -boot-load-size 4 -boot-info-table -o 
> /root/60149.test-amd64-i386-qemuu-rhel6hvm-amd.rhel-server-6.1-i386
> -dvd.iso /root/60149.test-amd64-i386-qemuu-rhel6hvm-amd.redhat-newiso/.
> Use of uninitialized value in pattern match (m//) at 
> Osstest/TestSupport.pm line 1736.

By inspection I think this one might be:
diff --git a/Osstest/TestSupport.pm b/Osstest/TestSupport.pm
index a6d42bd..ceb4d0f 100644
--- a/Osstest/TestSupport.pm
+++ b/Osstest/TestSupport.pm
@@ -1733,7 +1733,7 @@ sub more_prepareguest_hvm ($$$$;@) {
     }
     my $disks = join ",\t\t\n", map { "'$_'" } @disks;
 
-    my $kernel = $ho->{Toolstack}->{Name} =~ m/xend/ ?
+    my $kernel = toolstack($ho)->{Name} =~ m/xend/ ?
 	"kernel      = 'hvmloader'" : '';
 
     my $cfg = <<END;

Since toolstack() is the function which initialises $ho->{Toolstack} my
hypothesis is that on this path nothing has previously called toolstack(),
something which could well have changed over a rebase at some point. I
could imagine also that ts-{redhat,debian-hvm,windows}-install might differ
in some subtle way here.


> 2015-07-30 23:02:32 Z runvar store: 
> redhat_cfgpath=/etc/xen/redhat.guest.osstest.cfg
> 2015-07-30 23:02:32 Z executing scp ... /home/logs/logs/60149/test-amd64
> -i386-qemuu-rhel6hvm-amd/pinot1--redhat.guest.osstest.cfg 
> root@172.16.144.35:/etc/xen/redhat.guest.osstest.cfg
> 2015-07-30 23:02:33 Z executing ssh ... root@172.16.144.35         (echo 
> xenvnc; echo xenvnc) | vncpasswd redhat.vncpw
> 2015-07-30 23:02:33 Z executing ssh ... root@172.16.144.35 readlink 
> /dev/pinot1/redhat.guest.osstest-disk
> 2015-07-30 23:02:33 Z executing ssh ... root@172.16.144.35 lvdisplay -
> -colon /dev/pinot1/redhat.guest.osstest-disk
> Can't call method "create" on unblessed reference at 
> Osstest/TestSupport.pm line 1436.

I can't explain this one yet.

Calling a method on an undefined value results in a different message,
"Can't call method "create" on an undefined value", so somehow
toolstack($ho) is an actual reference, but an unblessed one. I haven't
figured out how that can have happened yet.

Ian.

^ permalink raw reply related	[flat|nested] 7+ messages in thread

* Re: [osstest test] 60149: regressions - FAIL
  2015-07-31  9:47   ` Ian Campbell
@ 2015-07-31  9:54     ` Ian Campbell
  2015-07-31 10:15       ` Ian Campbell
  2015-07-31  9:54     ` Wei Liu
  1 sibling, 1 reply; 7+ messages in thread
From: Ian Campbell @ 2015-07-31  9:54 UTC (permalink / raw)
  To: osstest service owner, Wei Liu; +Cc: xen-devel

On Fri, 2015-07-31 at 10:47 +0100, Ian Campbell wrote:
> 2015-07-30 23:02:32 Z runvar store:
> > redhat_cfgpath=/etc/xen/redhat.guest.osstest.cfg
> > 2015-07-30 23:02:32 Z executing scp ... /home/logs/logs/60149/test
> > -amd64
> > -i386-qemuu-rhel6hvm-amd/pinot1--redhat.guest.osstest.cfg 
> > root@172.16.144.35:/etc/xen/redhat.guest.osstest.cfg
> > 2015-07-30 23:02:33 Z executing ssh ... root@172.16.144.35        
> >  (echo 
> > xenvnc; echo xenvnc) | vncpasswd redhat.vncpw
> > 2015-07-30 23:02:33 Z executing ssh ... root@172.16.144.35 readlink 
> > /dev/pinot1/redhat.guest.osstest-disk
> > 2015-07-30 23:02:33 Z executing ssh ... root@172.16.144.35 lvdisplay -
> > -colon /dev/pinot1/redhat.guest.osstest-disk
> > Can't call method "create" on unblessed reference at 
> > Osstest/TestSupport.pm line 1436.
> 
> I can't explain this one yet.
> 
> Calling a method on an undefined value results in a different message,
> "Can't call method "create" on an undefined value", so somehow
> toolstack($ho) is an actual reference, but an unblessed one. I haven't
> figured out how that can have happened yet.

$ cat t.pl
#!/usr/bin/perl -w

use strict;

my $foo = {};

my $baz = $foo->{Bar}->{Name} =~ m/123/ ? "A" : "B";

print "$baz\n";
$foo->{Bar}->create();
$ ./t.pl
Use of uninitialized value in pattern match (m//) at /home/ianc/t.pl line 7.
B
Can't call method "create" on unblessed reference at /home/ianc/t.pl line 10.

Whereas with:
    my $baz = $foo->{Bar} =~ m/123/ ? "A" : "B";
the error is:
    Can't call method "create" on an undefined value at /home/ianc/t.pl line 10.

IOW something about:
    $foo->{Bar}->{Name} =~ m/123/ ? "A" : "B";
causes $foo->{Bar} to be initialised.

IOW I think the fix to more_prepareguest_hvm is going to fix this too.

I'll fold that in, drop the patch which does make test and force push to
osstest's pretest, then I'll kill the current flight.

Ian.

^ permalink raw reply	[flat|nested] 7+ messages in thread

* Re: [osstest test] 60149: regressions - FAIL
  2015-07-31  9:47   ` Ian Campbell
  2015-07-31  9:54     ` Ian Campbell
@ 2015-07-31  9:54     ` Wei Liu
  1 sibling, 0 replies; 7+ messages in thread
From: Wei Liu @ 2015-07-31  9:54 UTC (permalink / raw)
  To: Ian Campbell; +Cc: Wei Liu, osstest service owner, xen-devel

On Fri, Jul 31, 2015 at 10:47:22AM +0100, Ian Campbell wrote:
> On Fri, 2015-07-31 at 07:40 +0100, Ian Campbell wrote:
> > 
> > >  test-amd64-i386-qemut-rhel6hvm-amd  9 redhat-install      fail REGR.
> > > vs. 60083
> > 
> > 2015-07-30 23:02:32 Z execution took 71 seconds[<=2x600]: timeout 630 ssh 
> > -o StrictHostKeyChecking=no -o BatchMode=yes -o ConnectTimeout=100 -o 
> > ServerAliveInterval=100 -o PasswordAuthentication=no -o 
> > ChallengeResponseAuthentication=no -o 
> > UserKnownHostsFile=tmp/t.known_hosts_60149.test-amd64-i386-qemuu-rhel6hvm
> > -amd root@172.16.144.35         mkdir -p /root/60149.test-amd64-i386
> > -qemuu-rhel6hvm-amd.redhat-newiso
> >         genisoimage -R -J -T -b isolinux/isolinux.bin -c 
> > isolinux/boot.cat -no-emul-boot -boot-load-size 4 -boot-info-table -o 
> > /root/60149.test-amd64-i386-qemuu-rhel6hvm-amd.rhel-server-6.1-i386
> > -dvd.iso /root/60149.test-amd64-i386-qemuu-rhel6hvm-amd.redhat-newiso/.
> > Use of uninitialized value in pattern match (m//) at 
> > Osstest/TestSupport.pm line 1736.
> 
> By inspection I think this one might be:
> diff --git a/Osstest/TestSupport.pm b/Osstest/TestSupport.pm
> index a6d42bd..ceb4d0f 100644
> --- a/Osstest/TestSupport.pm
> +++ b/Osstest/TestSupport.pm
> @@ -1733,7 +1733,7 @@ sub more_prepareguest_hvm ($$$$;@) {
>      }
>      my $disks = join ",\t\t\n", map { "'$_'" } @disks;
>  
> -    my $kernel = $ho->{Toolstack}->{Name} =~ m/xend/ ?
> +    my $kernel = toolstack($ho)->{Name} =~ m/xend/ ?
>  	"kernel      = 'hvmloader'" : '';
>  
>      my $cfg = <<END;
> 
> Since toolstack() is the function which initialises $ho->{Toolstack} my
> hypothesis is that on this path nothing has previously called toolstack(),
> something which could well have changed over a rebase at some point. I
> could imagine also that ts-{redhat,debian-hvm,windows}-install might differ
> in some subtle way here.
> 

Good catch.

The root cause is ts-debian-hvm-install calls host_get_free_memory which
initialises toolstack in the background. It's a trick only used by
debian hvm test case.

And I think your fix is correct.

Wei.

^ permalink raw reply	[flat|nested] 7+ messages in thread

* Re: [osstest test] 60149: regressions - FAIL
  2015-07-31  9:54     ` Ian Campbell
@ 2015-07-31 10:15       ` Ian Campbell
  0 siblings, 0 replies; 7+ messages in thread
From: Ian Campbell @ 2015-07-31 10:15 UTC (permalink / raw)
  To: osstest service owner, Wei Liu; +Cc: xen-devel

On Fri, 2015-07-31 at 10:54 +0100, Ian Campbell wrote:
> 
> I'll fold that in, drop the patch which does make test and force push to
> osstest's pretest, then I'll kill the current flight.

Done. The killed flight was 60184.

Ian.

^ permalink raw reply	[flat|nested] 7+ messages in thread

end of thread, other threads:[~2015-07-31 10:15 UTC | newest]

Thread overview: 7+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
     [not found] <osstest-60149-mainreport@xen.org>
2015-07-31  6:40 ` [osstest test] 60149: regressions - FAIL Ian Campbell
2015-07-31  8:49   ` Ian Campbell
2015-07-31  8:50     ` Wei Liu
2015-07-31  9:47   ` Ian Campbell
2015-07-31  9:54     ` Ian Campbell
2015-07-31 10:15       ` Ian Campbell
2015-07-31  9:54     ` Wei Liu

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.