Re: [PATCH for-4.6 v2] xl/libxl: disable PV vNUMA

[Dario Faggioli <dario.faggioli@citrix.com>]

[-- Attachment #1.1: Type: text/plain, Size: 867 bytes --]

On Fri, 2015-07-31 at 10:29 +0100, Ian Campbell wrote:
> On Thu, 2015-07-30 at 17:11 +0100, Wei Liu wrote:

> >  
> > +    /* PV vNUMA is not yet supported because there is an issue with
> > +     * cpuid handling.
> > +     */
> 
> Personally I think this is wrong and should be
>     /*
>      * PV vNUMA...
> 
Me too...

> but a) there are a bunch of similarly formatted comments in this function
>
Exactly.

> and b) tools/libxl/CODING_STYLE doesn't actually cover comment style.
> 
Should we make it do so? FWIW, I'd say we should (and can send a patch
to the effect...)

Dario
-- 
<<This happens because I choose it to happen!>> (Raistlin Majere)
-----------------------------------------------------------------
Dario Faggioli, Ph.D, http://about.me/dario.faggioli
Senior Software Engineer, Citrix Systems R&D Ltd., Cambridge (UK)

[-- Attachment #1.2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 181 bytes --]

[-- Attachment #2: Type: text/plain, Size: 126 bytes --]

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
http://lists.xen.org/xen-devel