From: Ian Campbell <ian.campbell@citrix.com>
To: Wei Liu <wei.liu2@citrix.com>,
Xen-devel <xen-devel@lists.xenproject.org>
Cc: Dario Faggioli <dario.faggioli@citrix.com>,
Ian Jackson <ian.jackson@eu.citrix.com>
Subject: Re: [PATCH for-4.6 v2] xl/libxl: disable PV vNUMA
Date: Fri, 31 Jul 2015 10:29:36 +0100 [thread overview]
Message-ID: <1438334976.30740.30.camel@citrix.com> (raw)
In-Reply-To: <1438272689-29944-1-git-send-email-wei.liu2@citrix.com>
On Thu, 2015-07-30 at 17:11 +0100, Wei Liu wrote:
> Update xl manual and disable PV vNUMA in libxl.
>
> Signed-off-by: Wei Liu <wei.liu2@citrix.com>
> ---
Acked-by: Ian Campbell <ian.campbell@citrix.com>
and applied.
>
> + /* PV vNUMA is not yet supported because there is an issue with
> + * cpuid handling.
> + */
Personally I think this is wrong and should be
/*
* PV vNUMA...
but a) there are a bunch of similarly formatted comments in this function
and b) tools/libxl/CODING_STYLE doesn't actually cover comment style.
So I left it.
Ian.
next prev parent reply other threads:[~2015-07-31 9:29 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-07-30 16:11 [PATCH for-4.6 v2] xl/libxl: disable PV vNUMA Wei Liu
2015-07-30 18:00 ` Dario Faggioli
2015-07-31 9:29 ` Ian Campbell [this message]
2015-07-31 10:04 ` Dario Faggioli
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1438334976.30740.30.camel@citrix.com \
--to=ian.campbell@citrix.com \
--cc=dario.faggioli@citrix.com \
--cc=ian.jackson@eu.citrix.com \
--cc=wei.liu2@citrix.com \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.