[PATCH for-4.6 v2] xl/libxl: disable PV vNUMA

[PATCH for-4.6 v2] xl/libxl: disable PV vNUMA

[Wei Liu]

Update xl manual and disable PV vNUMA in libxl.

Signed-off-by: Wei Liu <wei.liu2@citrix.com>
---
Cc: Ian Campbell <ian.campbell@citrix.com>
Cc: Ian Jackson <ian.jackson@eu.citrix.com>
Cc: Dario Faggioli <dario.faggioli@citrix.com>

v2: improve doc and code comment.
---
 docs/man/xl.cfg.pod.5      | 3 +++
 tools/libxl/libxl_create.c | 9 +++++++++
 2 files changed, 12 insertions(+)

diff --git a/docs/man/xl.cfg.pod.5 b/docs/man/xl.cfg.pod.5
index c78c3ba..80e51bb 100644
--- a/docs/man/xl.cfg.pod.5
+++ b/docs/man/xl.cfg.pod.5
@@ -261,6 +261,9 @@ Specify virtual NUMA configuration with positional arguments. The
 nth B<VNODE_SPEC> in the list specifies the configuration of nth
 virtual node.
 
+Note that virtual NUMA for PV guest is not yet supported, because
+there is an issue with cpuid handling that affects PV virtual NUMA.
+
 Each B<VNODE_SPEC> is a list, which has a form of
 "[VNODE_CONFIG_OPTION,VNODE_CONFIG_OPTION, ... ]"  (without quotes).
 
diff --git a/tools/libxl/libxl_create.c b/tools/libxl/libxl_create.c
index 4f2f50b..4b63559 100644
--- a/tools/libxl/libxl_create.c
+++ b/tools/libxl/libxl_create.c
@@ -860,6 +860,15 @@ static void initiate_domain_create(libxl__egc *egc,
         goto error_out;
     }
 
+    /* PV vNUMA is not yet supported because there is an issue with
+     * cpuid handling.
+     */
+    if (d_config->c_info.type == LIBXL_DOMAIN_TYPE_PV &&
+        d_config->b_info.num_vnuma_nodes) {
+        LOG(ERROR, "PV vNUMA is not yet supported");
+        goto error_out;
+    }
+
     ret = libxl__domain_create_info_setdefault(gc, &d_config->c_info);
     if (ret) {
         LOG(ERROR, "Unable to set domain create info defaults");
-- 
2.1.4

Re: [PATCH for-4.6 v2] xl/libxl: disable PV vNUMA

[Dario Faggioli]

[-- Attachment #1.1: Type: text/plain, Size: 710 bytes --]

On Thu, 2015-07-30 at 17:11 +0100, Wei Liu wrote:
> Update xl manual and disable PV vNUMA in libxl.
> 
> Signed-off-by: Wei Liu <wei.liu2@citrix.com>
> ---
> Cc: Ian Campbell <ian.campbell@citrix.com>
> Cc: Ian Jackson <ian.jackson@eu.citrix.com>
> Cc: Dario Faggioli <dario.faggioli@citrix.com>
> 
> v2: improve doc and code comment.
> ---
>
Reviewed-by: Dario Faggioli <dario.faggioli@citrix.com>

[With] Regard_s_,   :-D :-D
Dario
-- 
<<This happens because I choose it to happen!>> (Raistlin Majere)
-----------------------------------------------------------------
Dario Faggioli, Ph.D, http://about.me/dario.faggioli
Senior Software Engineer, Citrix Systems R&D Ltd., Cambridge (UK)

[-- Attachment #1.2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 181 bytes --]

[-- Attachment #2: Type: text/plain, Size: 126 bytes --]

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
http://lists.xen.org/xen-devel

Re: [PATCH for-4.6 v2] xl/libxl: disable PV vNUMA

[Ian Campbell]

On Thu, 2015-07-30 at 17:11 +0100, Wei Liu wrote:
> Update xl manual and disable PV vNUMA in libxl.
> 
> Signed-off-by: Wei Liu <wei.liu2@citrix.com>
> ---

Acked-by: Ian Campbell <ian.campbell@citrix.com>

and applied.

>  
> +    /* PV vNUMA is not yet supported because there is an issue with
> +     * cpuid handling.
> +     */

Personally I think this is wrong and should be
    /*
     * PV vNUMA...

but a) there are a bunch of similarly formatted comments in this function
and b) tools/libxl/CODING_STYLE doesn't actually cover comment style.

So I left it.

Ian.

Re: [PATCH for-4.6 v2] xl/libxl: disable PV vNUMA

[Dario Faggioli]

[-- Attachment #1.1: Type: text/plain, Size: 867 bytes --]

On Fri, 2015-07-31 at 10:29 +0100, Ian Campbell wrote:
> On Thu, 2015-07-30 at 17:11 +0100, Wei Liu wrote:

> >  
> > +    /* PV vNUMA is not yet supported because there is an issue with
> > +     * cpuid handling.
> > +     */
> 
> Personally I think this is wrong and should be
>     /*
>      * PV vNUMA...
> 
Me too...

> but a) there are a bunch of similarly formatted comments in this function
>
Exactly.

> and b) tools/libxl/CODING_STYLE doesn't actually cover comment style.
> 
Should we make it do so? FWIW, I'd say we should (and can send a patch
to the effect...)

Dario
-- 
<<This happens because I choose it to happen!>> (Raistlin Majere)
-----------------------------------------------------------------
Dario Faggioli, Ph.D, http://about.me/dario.faggioli
Senior Software Engineer, Citrix Systems R&D Ltd., Cambridge (UK)

[-- Attachment #1.2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 181 bytes --]

[-- Attachment #2: Type: text/plain, Size: 126 bytes --]

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
http://lists.xen.org/xen-devel