From: Priit Laes <plaes@plaes.org>
To: boris.brezillon@free-electrons.com,
David Woodhouse <dwmw2@infradead.org>,
Brian Norris <computersforpeace@gmail.com>,
linux-mtd@lists.infradead.org
Cc: Maxime Ripard <maxime.ripard@free-electrons.com>,
linux-sunxi@googlegroups.com,
linux-arm-kernel@lists.infradead.org,
Hans de Goede <hdegoede@redhat.com>,
stable@vger.kernel.org
Subject: Re: [linux-sunxi] [PATCH] mtd: nand: sunxi: fix sunxi_nand_chips_cleanup()
Date: Sun, 13 Sep 2015 19:26:53 +0300 [thread overview]
Message-ID: <1442161613.2857.9.camel@plaes.org> (raw)
In-Reply-To: <1442160883-29011-1-git-send-email-boris.brezillon@free-electrons.com>
On Sun, 2015-09-13 at 18:14 +0200, Boris Brezillon wrote:
> The sunxi_nand_chips_cleanup() function is missing a call to
> list_del()
> which generates a double free error.
Tested-by: Priit Laes <plaes@plaes.org>
>
> Reported-by: Priit Laes <plaes@plaes.org>
> Signed-off-by: Boris Brezillon <boris.brezillon@free-electrons.com>
> Cc: <stable@vger.kernel.org> # 3.19+
> Fixes: 1fef62c1423b ("mtd: nand: add sunxi NAND flash controller
> support")
> ---
> drivers/mtd/nand/sunxi_nand.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/mtd/nand/sunxi_nand.c
> b/drivers/mtd/nand/sunxi_nand.c
> index f9b5a4c..0467917 100644
> --- a/drivers/mtd/nand/sunxi_nand.c
> +++ b/drivers/mtd/nand/sunxi_nand.c
> @@ -1388,6 +1388,7 @@ static void sunxi_nand_chips_cleanup(struct
> sunxi_nfc *nfc)
> node);
> nand_release(&chip->mtd);
> sunxi_nand_ecc_cleanup(&chip->nand.ecc);
> + list_del(&chip->node);
> }
> }
>
> --
> 1.9.1
>
WARNING: multiple messages have this Message-ID (diff)
From: plaes@plaes.org (Priit Laes)
To: linux-arm-kernel@lists.infradead.org
Subject: [linux-sunxi] [PATCH] mtd: nand: sunxi: fix sunxi_nand_chips_cleanup()
Date: Sun, 13 Sep 2015 19:26:53 +0300 [thread overview]
Message-ID: <1442161613.2857.9.camel@plaes.org> (raw)
In-Reply-To: <1442160883-29011-1-git-send-email-boris.brezillon@free-electrons.com>
On Sun, 2015-09-13 at 18:14 +0200, Boris Brezillon wrote:
> The sunxi_nand_chips_cleanup() function is missing a call to
> list_del()
> which generates a double free error.
Tested-by: Priit Laes <plaes@plaes.org>
>
> Reported-by: Priit Laes <plaes@plaes.org>
> Signed-off-by: Boris Brezillon <boris.brezillon@free-electrons.com>
> Cc: <stable@vger.kernel.org> # 3.19+
> Fixes: 1fef62c1423b ("mtd: nand: add sunxi NAND flash controller
> support")
> ---
> drivers/mtd/nand/sunxi_nand.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/mtd/nand/sunxi_nand.c
> b/drivers/mtd/nand/sunxi_nand.c
> index f9b5a4c..0467917 100644
> --- a/drivers/mtd/nand/sunxi_nand.c
> +++ b/drivers/mtd/nand/sunxi_nand.c
> @@ -1388,6 +1388,7 @@ static void sunxi_nand_chips_cleanup(struct
> sunxi_nfc *nfc)
> node);
> nand_release(&chip->mtd);
> sunxi_nand_ecc_cleanup(&chip->nand.ecc);
> + list_del(&chip->node);
> }
> }
>
> --
> 1.9.1
>
next prev parent reply other threads:[~2015-09-13 16:26 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-09-13 16:14 [PATCH] mtd: nand: sunxi: fix sunxi_nand_chips_cleanup() Boris Brezillon
2015-09-13 16:14 ` Boris Brezillon
2015-09-13 16:26 ` Priit Laes [this message]
2015-09-13 16:26 ` [linux-sunxi] " Priit Laes
2015-09-22 0:15 ` Brian Norris
2015-09-22 0:15 ` Brian Norris
2015-09-22 7:52 ` Boris Brezillon
2015-09-22 7:52 ` Boris Brezillon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1442161613.2857.9.camel@plaes.org \
--to=plaes@plaes.org \
--cc=boris.brezillon@free-electrons.com \
--cc=computersforpeace@gmail.com \
--cc=dwmw2@infradead.org \
--cc=hdegoede@redhat.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-mtd@lists.infradead.org \
--cc=linux-sunxi@googlegroups.com \
--cc=maxime.ripard@free-electrons.com \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.