All of lore.kernel.org
 help / color / mirror / Atom feed
From: Brian Norris <computersforpeace@gmail.com>
To: Boris Brezillon <boris.brezillon@free-electrons.com>
Cc: David Woodhouse <dwmw2@infradead.org>,
	linux-mtd@lists.infradead.org,
	Maxime Ripard <maxime.ripard@free-electrons.com>,
	linux-sunxi@googlegroups.com,
	linux-arm-kernel@lists.infradead.org,
	Priit Laes <plaes@plaes.org>, Hans de Goede <hdegoede@redhat.com>,
	stable@vger.kernel.org
Subject: Re: [PATCH] mtd: nand: sunxi: fix sunxi_nand_chips_cleanup()
Date: Mon, 21 Sep 2015 17:15:28 -0700	[thread overview]
Message-ID: <20150922001528.GL31505@google.com> (raw)
In-Reply-To: <1442160883-29011-1-git-send-email-boris.brezillon@free-electrons.com>

On Sun, Sep 13, 2015 at 06:14:43PM +0200, Boris Brezillon wrote:
> The sunxi_nand_chips_cleanup() function is missing a call to list_del()
> which generates a double free error.

And if you could manage to get past that...an infinite loop, no?

> Reported-by: Priit Laes <plaes@plaes.org>
> Signed-off-by: Boris Brezillon <boris.brezillon@free-electrons.com>
> Cc: <stable@vger.kernel.org> # 3.19+
> Fixes: 1fef62c1423b ("mtd: nand: add sunxi NAND flash controller support")

Applied to linux-mtd.git, as this is a -stable fix.

Brian

WARNING: multiple messages have this Message-ID (diff)
From: computersforpeace@gmail.com (Brian Norris)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] mtd: nand: sunxi: fix sunxi_nand_chips_cleanup()
Date: Mon, 21 Sep 2015 17:15:28 -0700	[thread overview]
Message-ID: <20150922001528.GL31505@google.com> (raw)
In-Reply-To: <1442160883-29011-1-git-send-email-boris.brezillon@free-electrons.com>

On Sun, Sep 13, 2015 at 06:14:43PM +0200, Boris Brezillon wrote:
> The sunxi_nand_chips_cleanup() function is missing a call to list_del()
> which generates a double free error.

And if you could manage to get past that...an infinite loop, no?

> Reported-by: Priit Laes <plaes@plaes.org>
> Signed-off-by: Boris Brezillon <boris.brezillon@free-electrons.com>
> Cc: <stable@vger.kernel.org> # 3.19+
> Fixes: 1fef62c1423b ("mtd: nand: add sunxi NAND flash controller support")

Applied to linux-mtd.git, as this is a -stable fix.

Brian

  parent reply	other threads:[~2015-09-22  0:15 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-09-13 16:14 [PATCH] mtd: nand: sunxi: fix sunxi_nand_chips_cleanup() Boris Brezillon
2015-09-13 16:14 ` Boris Brezillon
2015-09-13 16:26 ` [linux-sunxi] " Priit Laes
2015-09-13 16:26   ` Priit Laes
2015-09-22  0:15 ` Brian Norris [this message]
2015-09-22  0:15   ` Brian Norris
2015-09-22  7:52   ` Boris Brezillon
2015-09-22  7:52     ` Boris Brezillon

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20150922001528.GL31505@google.com \
    --to=computersforpeace@gmail.com \
    --cc=boris.brezillon@free-electrons.com \
    --cc=dwmw2@infradead.org \
    --cc=hdegoede@redhat.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-mtd@lists.infradead.org \
    --cc=linux-sunxi@googlegroups.com \
    --cc=maxime.ripard@free-electrons.com \
    --cc=plaes@plaes.org \
    --cc=stable@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.