All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jiang Liu <jiang.liu@linux.intel.com>
To: Thomas Gleixner <tglx@linutronix.de>,
	Bjorn Helgaas <bhelgaas@google.com>,
	Arthur Marsh <arthur.marsh@internode.on.net>,
	Dario Ballabio <ballabio_dario@emc.com>,
	"James E.J. Bottomley" <JBottomley@odin.com>
Cc: Jiang Liu <jiang.liu@linux.intel.com>,
	linux-kernel@vger.kernel.org, linux-pci@vger.kernel.org,
	linux-scsi@vger.kernel.org, x86@kernel.org
Subject: [Bugfix 3/3] eata: Enhance eata driver to support PCI device hot-removal
Date: Mon, 14 Sep 2015 11:08:59 +0800	[thread overview]
Message-ID: <1442200140-30808-4-git-send-email-jiang.liu@linux.intel.com> (raw)
In-Reply-To: <1442200140-30808-1-git-send-email-jiang.liu@linux.intel.com>

Due to having no hardware for testing, this is just a sample code
to support PCI device hot-removal. It just passing compilation,
no any tests.

Signed-off-by: Jiang Liu <jiang.liu@linux.intel.com>
---
 drivers/scsi/eata.c |   26 ++++++++++++++++++++++++++
 1 file changed, 26 insertions(+)

diff --git a/drivers/scsi/eata.c b/drivers/scsi/eata.c
index b92e6856f909..f3bd7cbf260e 100644
--- a/drivers/scsi/eata.c
+++ b/drivers/scsi/eata.c
@@ -1474,6 +1474,21 @@ static unsigned int port_probe(unsigned long port_base,
 #ifdef CONFIG_PCI
 static int eata2x_pci_device_count;
 
+/* TODO: need help here to shutdown the scsi host and release resources */
+static void port_remove(unsigned int id, resource_size_t port_base,
+			struct pci_dev *pdev)
+{
+	struct Scsi_Host *shost = sh[id];
+
+	/* TODO: stop scsi device */
+	scsi_unregister(shost);
+	/* TODO: clean up resources allocated by port_detect() */
+	clear_bit(id, eata_board_bitmap);
+	free_irq(shost->irq, &sha[id]);
+	release_region(port_base, REGION_SIZE);
+	ida_simple_remove(&eata_ida, id);
+}
+
 static int eata2x_pci_probe(struct pci_dev *dev, const struct pci_device_id *id)
 {
 	int i, ret = -ENXIO;
@@ -1521,6 +1536,16 @@ out_error:
 	return ret;
 }
 
+static void eata2x_pci_remove(struct pci_dev *pdev)
+{
+	int id = (int)(long)dev_get_drvdata(&pdev->dev);
+	resource_size_t port_base;
+
+	port_base = pci_resource_start(pdev, 0) + PCI_BASE_ADDRESS_0;
+	port_remove(id, port_base, pdev);
+	pci_disable_device(pdev);
+}
+
 static struct pci_device_id eata2x_tbl[] = {
 	{ PCI_DEVICE_CLASS(PCI_CLASS_STORAGE_SCSI << 8, PCI_ANY_ID) },
 	{ },
@@ -1531,6 +1556,7 @@ static struct pci_driver eata2x_pci_driver = {
 	.name		= "eata",
 	.id_table	= eata2x_tbl,
 	.probe		= eata2x_pci_probe,
+	.remove		= eata2x_pci_remove,
 };
 
 static int eata2x_probe_pci_devices(struct scsi_host_template *tpnt)
-- 
1.7.10.4


  parent reply	other threads:[~2015-09-14  3:08 UTC|newest]

Thread overview: 55+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-09-06  6:28 eata fails to load on post 4.2 kernels Arthur Marsh
2015-09-06  9:04 ` Arthur Marsh
2015-09-06 11:37   ` Arthur Marsh
2015-09-06 20:31     ` Arthur Marsh
2015-09-07  3:06       ` Jiang Liu
     [not found]         ` <55ED2DFA.6030502@internode.on.net>
2015-09-07  9:24           ` Fwd: " Arthur Marsh
2015-09-08  5:19           ` Jiang Liu
2015-09-08  6:32             ` Arthur Marsh
2015-09-08  6:37               ` Jiang Liu
2015-09-08  7:26               ` [Bugfix] PCI, x86: Correctly allocate IRQs for PCI devices managed by non-PCI drivers Jiang Liu
2015-09-08  9:03                 ` Arthur Marsh
2015-09-08  9:44                   ` Jiang Liu
2015-09-08 16:27                 ` Bjorn Helgaas
2015-09-08 16:49                   ` Jiang Liu
2015-09-09 19:11                     ` Bjorn Helgaas
2015-09-10  8:58                       ` Jiang Liu
2015-09-14  3:08                       ` [Bugfix 0/3] Convert eata driver to a normal PCI device driver Jiang Liu
2015-09-14  3:08                         ` [Bugfix 1/3] eata: Use IDA to manage eata board IDs Jiang Liu
2015-09-14  8:08                           ` Hannes Reinecke
2015-09-14  8:08                             ` Hannes Reinecke
2015-09-14  3:08                         ` [Bugfix 2/3] eata: Implement PCI driver to manage eata PCI devices Jiang Liu
2015-09-14  8:17                           ` Hannes Reinecke
2015-09-14  8:31                             ` Jiang Liu
2015-09-14  3:08                         ` Jiang Liu [this message]
2015-09-14  8:21                           ` [Bugfix 3/3] eata: Enhance eata driver to support PCI device hot-removal Hannes Reinecke
2015-09-14  8:31                             ` Ballabio, Dario
2015-09-14  8:33                               ` Jiang Liu
2015-09-16 13:42                             ` Christoph Hellwig
2015-09-17  6:49                               ` Jiang Liu
2015-09-18 15:08                               ` Arthur Marsh
2015-09-22  7:30                               ` [RFT v3] eata: Convert eata driver as normal PCI and platform device drivers Jiang Liu
2015-09-22 20:27                                 ` Hannes Reinecke
2015-09-22 22:25                                 ` Arthur Marsh
2015-09-22 22:45                                   ` James Bottomley
2015-09-22 23:36                                     ` Arthur Marsh
2015-09-23  5:24                                       ` Jiang Liu
2015-09-23 10:44                                         ` Arthur Marsh
2015-09-23 14:40                                           ` James Bottomley
2015-09-24  4:28                                             ` Jiang Liu
2015-09-24  5:56                                               ` Arthur Marsh
2015-09-26  6:27                                                 ` Arthur Marsh
2015-10-03  8:11                                                   ` Jiang Liu
2015-10-03 11:14                                                     ` Arthur Marsh
2015-10-05  8:29                                                     ` Arthur Marsh
2015-09-14 16:01                         ` [Bugfix 0/3] Convert eata driver to a normal PCI device driver Arthur Marsh
2015-09-15  2:31                           ` Jiang Liu
2015-09-15  7:19                             ` Arthur Marsh
2015-09-16  5:07                               ` Jiang Liu
2015-09-16  7:37                                 ` Arthur Marsh
2015-09-16  8:21                                   ` Jiang Liu
2015-09-16 11:29                                     ` Arthur Marsh
2015-09-09 19:04                 ` [Bugfix] PCI, x86: Correctly allocate IRQs for PCI devices managed by non-PCI drivers Arthur Marsh
2015-09-10  7:50             ` eata fails to load on post 4.2 kernels Arthur Marsh
2015-09-10  8:13               ` Jiang Liu
2015-09-10  9:00                 ` Arthur Marsh

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1442200140-30808-4-git-send-email-jiang.liu@linux.intel.com \
    --to=jiang.liu@linux.intel.com \
    --cc=JBottomley@odin.com \
    --cc=arthur.marsh@internode.on.net \
    --cc=ballabio_dario@emc.com \
    --cc=bhelgaas@google.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-pci@vger.kernel.org \
    --cc=linux-scsi@vger.kernel.org \
    --cc=tglx@linutronix.de \
    --cc=x86@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.