Re: [Bugfix 3/3] eata: Enhance eata driver to support PCI device hot-removal

[Jiang Liu <jiang.liu@linux.intel.com>]

On 2015/9/16 21:42, Christoph Hellwig wrote:
> On Mon, Sep 14, 2015 at 10:21:14AM +0200, Hannes Reinecke wrote:
>> Welll ... if you don't have hardware (and I strongly hope you refer to
>> 'hardware able to do hotplugging', not 'hardware for the eata driver'
>> ...) why add the code at all?
>> Chances are no-one will ever need eata PCI hotplug; SCSI parallel
>> typically isn't very good at hotplugging, so throwing in PCI hotplug
>> will only confuse matters more.
>> Plus due to the sheer mechanics involved here I find it very unlikely
>> anyone will be using it in real life.
> 
> Because it's used for module removal and we want every driver to use
> the standard interface that.
> 
> Jiang, you also need to convert the driver to
> scsi_add_host/scsi_remove_host from the legacy scsi_register interface,
> otherwise the SCSI layer will be very unhappy.
> 
> Take a look at commit 0d31f8759109cbc1e6fc196d08e6b0e8a9e93b3f for
> example, the change should be straight forward.
Hi Christoph,
	I have taken a look at the commit 0d31f8759109cb and it seems
that the conversion is not so big. But I have no hardware for testing,
so could only ask for help from community.
Thanks!
Gerry