From: Ian Campbell <ian.campbell@citrix.com>
To: Julien Grall <julien.grall@citrix.com>
Cc: Marc Zyngier <Marc.Zyngier@arm.com>,
"xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>,
Will Deacon <will.deacon@arm.com>
Subject: Re: [PATCH] KVM: arm64: add workaround for Cortex-A57 erratum #852523
Date: Tue, 15 Sep 2015 09:40:34 +0100 [thread overview]
Message-ID: <1442306434.3549.321.camel@citrix.com> (raw)
In-Reply-To: <55F7535A.3020905@citrix.com>
On Tue, 2015-09-15 at 00:08 +0100, Julien Grall wrote:
> On 14/09/2015 16:58, Will Deacon wrote:
> > > The Xen ctxt switch code[0] has DACR_EL2 in the midst of it all, and
> > > certainly followed by some sysregs, which I've got my fingers crossed
> > > happens to be sufficient (other than maybe adding a comment).
> >
> > It looks like you restore CONTEXTIDR_EL1 fairly late, so you should be
> > ok.
Thanks Will.
> It may be worth to have a comment in the code explaining the errata to
> avoid introduce by inadvertence if we plan to re-order the context
> switch.
>
> I can send a patch for that.
Yes, please, a comment right before we restore DACR32_EL2 with the list of
register Will gave would be best I think.
>
> Regards,
>
next prev parent reply other threads:[~2015-09-15 8:40 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-09-14 15:06 [PATCH] KVM: arm64: add workaround for Cortex-A57 erratum #852523 Will Deacon
2015-09-14 15:06 ` Will Deacon
2015-09-14 15:06 ` Will Deacon
2015-09-14 15:36 ` Ian Campbell
2015-09-14 15:58 ` Will Deacon
2015-09-14 23:08 ` Julien Grall
2015-09-15 8:40 ` Ian Campbell [this message]
2015-09-14 15:46 ` Marc Zyngier
2015-09-14 15:46 ` Marc Zyngier
2015-09-14 15:46 ` Marc Zyngier
2015-09-14 17:01 ` Will Deacon
2015-09-14 17:01 ` Will Deacon
2015-09-14 17:01 ` Will Deacon
2015-09-15 19:00 ` Christoffer Dall
2015-09-15 19:00 ` Christoffer Dall
2015-09-15 19:00 ` Christoffer Dall
-- strict thread matches above, loose matches on Subject: below --
2015-09-14 15:06 Will Deacon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1442306434.3549.321.camel@citrix.com \
--to=ian.campbell@citrix.com \
--cc=Marc.Zyngier@arm.com \
--cc=julien.grall@citrix.com \
--cc=will.deacon@arm.com \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.