From: Will Deacon <will.deacon@arm.com>
To: Marc Zyngier <marc.zyngier@arm.com>
Cc: "kvmarm@lists.cs.columbia.edu" <kvmarm@lists.cs.columbia.edu>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>,
"kvm@vger.kernel.org" <kvm@vger.kernel.org>,
"xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>,
"linux@arm.linux.org.uk" <linux@arm.linux.org.uk>,
"christoffer.dall@linaro.org" <christoffer.dall@linaro.org>,
"stable@vger.kernel.org" <stable@vger.kernel.org>
Subject: Re: [PATCH] KVM: arm64: add workaround for Cortex-A57 erratum #852523
Date: Mon, 14 Sep 2015 18:01:11 +0100 [thread overview]
Message-ID: <20150914170111.GH23878@arm.com> (raw)
In-Reply-To: <55F6EBD4.30809@arm.com>
On Mon, Sep 14, 2015 at 04:46:28PM +0100, Marc Zyngier wrote:
> On 14/09/15 16:06, Will Deacon wrote:
> > When restoring the system register state for an AArch32 guest at EL2,
> > writes to DACR32_EL2 may not be correctly synchronised by Cortex-A57,
> > which can lead to the guest effectively running with junk in the DACR
> > and running into unexpected domain faults.
> >
> > This patch works around the issue by re-ordering our restoration of the
> > AArch32 register aliases so that they happen before the AArch64 system
> > registers. Ensuring that the registers are restored in this order
> > guarantees that they will be correctly synchronised by the core.
> >
> > Cc: <stable@vger.kernel.org>
> > Cc: Marc Zyngier <marc.zyngier@arm.com>
> > Signed-off-by: Will Deacon <will.deacon@arm.com>
>
> Reviewed-by: Marc Zyngier <marc.zyngier@arm.com>
>
> I'll queue that together with the next batch of fixes.
Great, thanks Marc.
Will
WARNING: multiple messages have this Message-ID (diff)
From: will.deacon@arm.com (Will Deacon)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] KVM: arm64: add workaround for Cortex-A57 erratum #852523
Date: Mon, 14 Sep 2015 18:01:11 +0100 [thread overview]
Message-ID: <20150914170111.GH23878@arm.com> (raw)
In-Reply-To: <55F6EBD4.30809@arm.com>
On Mon, Sep 14, 2015 at 04:46:28PM +0100, Marc Zyngier wrote:
> On 14/09/15 16:06, Will Deacon wrote:
> > When restoring the system register state for an AArch32 guest at EL2,
> > writes to DACR32_EL2 may not be correctly synchronised by Cortex-A57,
> > which can lead to the guest effectively running with junk in the DACR
> > and running into unexpected domain faults.
> >
> > This patch works around the issue by re-ordering our restoration of the
> > AArch32 register aliases so that they happen before the AArch64 system
> > registers. Ensuring that the registers are restored in this order
> > guarantees that they will be correctly synchronised by the core.
> >
> > Cc: <stable@vger.kernel.org>
> > Cc: Marc Zyngier <marc.zyngier@arm.com>
> > Signed-off-by: Will Deacon <will.deacon@arm.com>
>
> Reviewed-by: Marc Zyngier <marc.zyngier@arm.com>
>
> I'll queue that together with the next batch of fixes.
Great, thanks Marc.
Will
next prev parent reply other threads:[~2015-09-14 17:01 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-09-14 15:06 [PATCH] KVM: arm64: add workaround for Cortex-A57 erratum #852523 Will Deacon
2015-09-14 15:06 ` Will Deacon
2015-09-14 15:06 ` Will Deacon
2015-09-14 15:36 ` Ian Campbell
2015-09-14 15:58 ` Will Deacon
2015-09-14 23:08 ` Julien Grall
2015-09-15 8:40 ` Ian Campbell
2015-09-14 15:46 ` Marc Zyngier
2015-09-14 15:46 ` Marc Zyngier
2015-09-14 17:01 ` Will Deacon
2015-09-14 17:01 ` Will Deacon [this message]
2015-09-14 17:01 ` Will Deacon
2015-09-15 19:00 ` Christoffer Dall
2015-09-15 19:00 ` Christoffer Dall
2015-09-15 19:00 ` Christoffer Dall
2015-09-14 15:46 ` Marc Zyngier
-- strict thread matches above, loose matches on Subject: below --
2015-09-14 15:06 Will Deacon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150914170111.GH23878@arm.com \
--to=will.deacon@arm.com \
--cc=christoffer.dall@linaro.org \
--cc=kvm@vger.kernel.org \
--cc=kvmarm@lists.cs.columbia.edu \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux@arm.linux.org.uk \
--cc=marc.zyngier@arm.com \
--cc=stable@vger.kernel.org \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.