All of lore.kernel.org
 help / color / mirror / Atom feed
From: Michael Ellerman <mpe-Gsx/Oe8HsFggBc27wqDAHg@public.gmane.org>
To: Mathieu Desnoyers
	<mathieu.desnoyers-vg+e7yoeK/dWk0Htik3J/w@public.gmane.org>
Cc: Wang Long <long.wanglong-hv44wF8Li93QT0dZR+AlfA@public.gmane.org>,
	shuahkh-JPH+aEBZ4P+UEJcrhfAQsw@public.gmane.org,
	dvhart-wEGCiKHe2LqWVfeAwA7xHQ@public.gmane.org,
	keescook-F7+t8E8rja9g9hUCZPvPmw@public.gmane.org,
	davem-fT/PcQaiUtIeIZ0/mPfg9Q@public.gmane.org,
	luto-kltTT9wpgjJwATOyAt5JVQ@public.gmane.org,
	wad-F7+t8E8rja9g9hUCZPvPmw@public.gmane.org,
	Andrew Morton
	<akpm-de/tnXTf+JLsfHDXvbKv3WD2FQJk+8+b@public.gmane.org>,
	gorcunov-GEFAQzZX7r8dnm+yROfE0A@public.gmane.org,
	cov-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org,
	bobby prani <bobby.prani-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>,
	tyler baker <tyler.baker-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>,
	Tim Bird <tim.bird-/MT0OVThwyLZJqsBc5GL+g@public.gmane.org>,
	josh-iaAMLnmF4UmaiuxdJuQwMA@public.gmane.org,
	Andrea Arcangeli
	<aarcange-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>,
	andrej skvortzov
	<andrej.skvortzov-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>,
	sjayaram-JqFfY2XvxFXQT0dZR+AlfA@public.gmane.org,
	treding-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org,
	Ingo Molnar <mingo-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>,
	naresh kamboju
	<naresh.kamboju-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>,
	alexey kodanev
	<alexey.kodanev-QHcLZuEGTsvQT0dZR+AlfA@public.gmane.org>,
	linux-api <linux-api-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>,
	linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
	wanglong-m92B/FuLcaEcWVvVuXF20w@public.gmane.org
Subject: Re: [PATCH] kselftest: replace $(RM) with rm -f command
Date: Tue, 29 Sep 2015 19:57:45 +1000	[thread overview]
Message-ID: <1443520665.11041.1.camel@ellerman.id.au> (raw)
In-Reply-To: <1201012824.5792.1443410213729.JavaMail.zimbra-vg+e7yoeK/dWk0Htik3J/w@public.gmane.org>

On Mon, 2015-09-28 at 03:16 +0000, Mathieu Desnoyers wrote:
> ----- On Sep 27, 2015, at 10:10 PM, Wang Long long.wanglong-hv44wF8Li93QT0dZR+AlfA@public.gmane.org wrote:
> 
> > Some test's Makefile using "$(RM)" while the other's
> > using "rm -f". It is better to use one of them in all
> > tests.
> 
> I agree that this disparity appears to be unwanted. We
> should settle on one or the other.
> 
> > "rm -f" is better, because it is less magic, and everyone
> > konws what is does.
> 
> "$(RM)" is clearly defined as a Makefile implicit variable
> which defaults to "rm -f".
> Ref. https://www.gnu.org/software/make/manual/html_node/Implicit-Variables.html

Sure, but you had to look it up didn't you :) - I did.

> Leaving it as a variable is more flexible because then the
> default behavior can be overridden if need be, which is
> not the case of a hardcoded "rm -f".

But I don't think anyone actually wants to do that. Do they?

Anyway I don't really care either way, so I'm happy for you to do a patch that
uses $(RM). Or maybe Wang Long will be happy to respin his patch to use $(RM).

cheers

WARNING: multiple messages have this Message-ID (diff)
From: Michael Ellerman <mpe@ellerman.id.au>
To: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
Cc: Wang Long <long.wanglong@huawei.com>,
	shuahkh@osg.samsung.com, dvhart@infradead.org,
	keescook@chromium.org, davem@davemloft.net, luto@amacapital.net,
	wad@chromium.org, Andrew Morton <akpm@linux-foundation.org>,
	gorcunov@openvz.org, cov@codeaurora.org,
	bobby prani <bobby.prani@gmail.com>,
	tyler baker <tyler.baker@linaro.org>,
	Tim Bird <tim.bird@sonymobile.com>,
	josh@joshtriplett.org, Andrea Arcangeli <aarcange@redhat.com>,
	andrej skvortzov <andrej.skvortzov@gmail.com>,
	sjayaram@akamai.com, treding@nvidia.com,
	Ingo Molnar <mingo@kernel.org>,
	naresh kamboju <naresh.kamboju@linaro.org>,
	alexey kodanev <alexey.kodanev@oracle.com>,
	linux-api <linux-api@vger.kernel.org>,
	linux-kernel@vger.kernel.org, wanglong@laoqinren.net
Subject: Re: [PATCH] kselftest: replace $(RM) with rm -f command
Date: Tue, 29 Sep 2015 19:57:45 +1000	[thread overview]
Message-ID: <1443520665.11041.1.camel@ellerman.id.au> (raw)
In-Reply-To: <1201012824.5792.1443410213729.JavaMail.zimbra@efficios.com>

On Mon, 2015-09-28 at 03:16 +0000, Mathieu Desnoyers wrote:
> ----- On Sep 27, 2015, at 10:10 PM, Wang Long long.wanglong@huawei.com wrote:
> 
> > Some test's Makefile using "$(RM)" while the other's
> > using "rm -f". It is better to use one of them in all
> > tests.
> 
> I agree that this disparity appears to be unwanted. We
> should settle on one or the other.
> 
> > "rm -f" is better, because it is less magic, and everyone
> > konws what is does.
> 
> "$(RM)" is clearly defined as a Makefile implicit variable
> which defaults to "rm -f".
> Ref. https://www.gnu.org/software/make/manual/html_node/Implicit-Variables.html

Sure, but you had to look it up didn't you :) - I did.

> Leaving it as a variable is more flexible because then the
> default behavior can be overridden if need be, which is
> not the case of a hardcoded "rm -f".

But I don't think anyone actually wants to do that. Do they?

Anyway I don't really care either way, so I'm happy for you to do a patch that
uses $(RM). Or maybe Wang Long will be happy to respin his patch to use $(RM).

cheers



  parent reply	other threads:[~2015-09-29  9:57 UTC|newest]

Thread overview: 25+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-09-23  9:40 [PATCH] kselftest: using built-in rule when delete file Wang Long
2015-09-24  1:46 ` Michael Ellerman
2015-09-24  2:05   ` long.wanglong
2015-09-24  2:07     ` Michael Ellerman
2015-09-25 15:44       ` Darren Hart
2015-09-28  2:03         ` long.wanglong
2015-09-28  2:10         ` [PATCH] kselftest: replace $(RM) with rm -f command Wang Long
2015-09-28  2:10           ` Wang Long
     [not found]           ` <1443406217-137773-1-git-send-email-long.wanglong-hv44wF8Li93QT0dZR+AlfA@public.gmane.org>
2015-09-28  3:16             ` Mathieu Desnoyers
2015-09-28  3:16               ` Mathieu Desnoyers
2015-09-28  5:11               ` Cam Hutchison
     [not found]               ` <1201012824.5792.1443410213729.JavaMail.zimbra-vg+e7yoeK/dWk0Htik3J/w@public.gmane.org>
2015-09-29  9:57                 ` Michael Ellerman [this message]
2015-09-29  9:57                   ` Michael Ellerman
     [not found]                   ` <1443520665.11041.1.camel-Gsx/Oe8HsFggBc27wqDAHg@public.gmane.org>
2015-09-29 11:21                     ` [PATCH] kselftest: replace rm -f command with $(RM) Wang Long
2015-09-29 11:21                       ` Wang Long
2015-09-29 17:45                     ` [PATCH] kselftest: replace $(RM) with rm -f command Kees Cook
2015-09-29 17:45                       ` Kees Cook
2015-10-03  4:38                 ` Darren Hart
2015-10-03  4:38                   ` Darren Hart
2015-10-03 14:11                   ` Mathieu Desnoyers
     [not found]                     ` <1486799898.16862.1443881517178.JavaMail.zimbra-vg+e7yoeK/dWk0Htik3J/w@public.gmane.org>
2015-10-03 17:55                       ` Josh Triplett
2015-10-03 17:55                         ` Josh Triplett
2015-10-03 18:05                         ` Mathieu Desnoyers
2015-09-28  7:26             ` Yuan Sun
2015-09-28  7:26               ` Yuan Sun

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1443520665.11041.1.camel@ellerman.id.au \
    --to=mpe-gsx/oe8hsfggbc27wqdahg@public.gmane.org \
    --cc=aarcange-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org \
    --cc=akpm-de/tnXTf+JLsfHDXvbKv3WD2FQJk+8+b@public.gmane.org \
    --cc=alexey.kodanev-QHcLZuEGTsvQT0dZR+AlfA@public.gmane.org \
    --cc=andrej.skvortzov-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org \
    --cc=bobby.prani-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org \
    --cc=cov-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org \
    --cc=davem-fT/PcQaiUtIeIZ0/mPfg9Q@public.gmane.org \
    --cc=dvhart-wEGCiKHe2LqWVfeAwA7xHQ@public.gmane.org \
    --cc=gorcunov-GEFAQzZX7r8dnm+yROfE0A@public.gmane.org \
    --cc=josh-iaAMLnmF4UmaiuxdJuQwMA@public.gmane.org \
    --cc=keescook-F7+t8E8rja9g9hUCZPvPmw@public.gmane.org \
    --cc=linux-api-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    --cc=linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    --cc=long.wanglong-hv44wF8Li93QT0dZR+AlfA@public.gmane.org \
    --cc=luto-kltTT9wpgjJwATOyAt5JVQ@public.gmane.org \
    --cc=mathieu.desnoyers-vg+e7yoeK/dWk0Htik3J/w@public.gmane.org \
    --cc=mingo-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org \
    --cc=naresh.kamboju-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org \
    --cc=shuahkh-JPH+aEBZ4P+UEJcrhfAQsw@public.gmane.org \
    --cc=sjayaram-JqFfY2XvxFXQT0dZR+AlfA@public.gmane.org \
    --cc=tim.bird-/MT0OVThwyLZJqsBc5GL+g@public.gmane.org \
    --cc=treding-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org \
    --cc=tyler.baker-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org \
    --cc=wad-F7+t8E8rja9g9hUCZPvPmw@public.gmane.org \
    --cc=wanglong-m92B/FuLcaEcWVvVuXF20w@public.gmane.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.