From: Christopher Covington <cov@codeaurora.org>
To: drjones@redhat.com, qemu-devel@nongnu.org, kvm@vger.kernel.org,
kvmarm@lists.cs.columbia.edu
Cc: shannon.zhao@linaro.org, wei@redhat.com,
alistair.francis@xilinx.com,
Christopher Covington <cov@codeaurora.org>
Subject: [kvm-unit-tests PATCHv2] arm: Add PMU test
Date: Fri, 2 Oct 2015 11:48:28 -0400 [thread overview]
Message-ID: <1443800908-12159-1-git-send-email-cov@codeaurora.org> (raw)
In-Reply-To: <1443728841-10501-1-git-send-email-cov@codeaurora.org>
Add test the ARM Performance Monitors Unit (PMU). The informational
fields from the control register are printed, but not checked, and
the number of cycles it takes to run a known-instruction-count loop
is printed, but not checked. Once QEMU is fixed, we can at least
begin to check for IPC == 1 when using -icount.
Signed-off-by: Christopher Covington <cov@codeaurora.org>
---
arm/pmu.c | 89 +++++++++++++++++++++++++++++++++++++++++++++++++
arm/unittests.cfg | 11 ++++++
config/config-arm64.mak | 4 ++-
3 files changed, 103 insertions(+), 1 deletion(-)
create mode 100644 arm/pmu.c
diff --git a/arm/pmu.c b/arm/pmu.c
new file mode 100644
index 0000000..f724c2c
--- /dev/null
+++ b/arm/pmu.c
@@ -0,0 +1,89 @@
+/*
+ * Test the ARM Performance Monitors Unit (PMU).
+ *
+ * Copyright 2015 The Linux Foundation. All rights reserved.
+ *
+ * This program is free software; you can redistribute it and/or modify it
+ * under the terms of the GNU Lesser General Public License version 2.1 and
+ * only version 2.1 as published by the Free Software Foundation.
+ *
+ * This program is distributed in the hope that it will be useful, but WITHOUT
+ * ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or
+ * FITNESS FOR A PARTICULAR PURPOSE. See the GNU Lesser General Public License
+ * for more details.
+ */
+#include "libcflat.h"
+
+struct pmu_data {
+ union {
+ uint32_t pmcr_el0;
+ struct {
+ unsigned int enable:1;
+ unsigned int event_counter_reset:1;
+ unsigned int cycle_counter_reset:1;
+ unsigned int cycle_counter_clock_divider:1;
+ unsigned int event_counter_export:1;
+ unsigned int cycle_counter_disable_when_prohibited:1;
+ unsigned int cycle_counter_long:1;
+ unsigned int zeros:4;
+ unsigned int num_counters:5;
+ unsigned int identification_code:8;
+ unsigned int implementor:8;
+ };
+ };
+};
+
+/* Execute a known number of guest instructions. Only odd instruction counts
+ * greater than or equal to 3 are supported. The control register (PMCR) is
+ * initialized with the provided value (allowing for example for the cycle
+ * counter or eventer count to be reset if needed). After the known instruction
+ * count loop, zero is written to the PMCR to disable counting, allowing the
+ * cycle counter or event counters to be read as needed at a later time.
+ */
+static void measure_instrs(int len, struct pmu_data pmcr)
+{
+ int i = (len - 1) / 2;
+
+ if (len < 3 || ((len - 1) % 2))
+ abort();
+
+ asm volatile(
+ "msr pmcr_el0, %[pmcr]\n"
+ "1: subs %[i], %[i], #1\n"
+ "b.gt 1b\n"
+ "msr pmcr_el0, xzr"
+ : [i] "+r" (i) : [pmcr] "r" (pmcr) : "cc");
+}
+
+int main()
+{
+ struct pmu_data pmcr;
+ const int samples = 10;
+
+ asm volatile("mrs %0, pmcr_el0" : "=r" (pmcr));
+
+ printf("PMU implementor: %c\n", pmcr.implementor);
+ printf("Identification code: 0x%x\n", pmcr.identification_code);
+ printf("Event counters: %d\n", pmcr.num_counters);
+
+ pmcr.cycle_counter_reset = 1;
+ pmcr.enable = 1;
+
+ printf("\ninstructions : cycles0 cycles1 ...\n");
+
+ for (int i = 3; i < 300; i += 32) {
+ int avg, sum = 0;
+ printf("%d :", i);
+ for (int j = 0; j < samples; j++) {
+ int val;
+ measure_instrs(i, pmcr);
+ asm volatile("mrs %0, pmccntr_el0" : "=r" (val));
+ sum += val;
+ printf(" %d", val);
+ }
+ avg = sum / samples;
+ printf(" sum=%d avg=%d avg_ipc=%d avg_cpi=%d\n", sum, avg, i / avg, avg / i);
+ }
+
+ return report_summary();
+}
diff --git a/arm/unittests.cfg b/arm/unittests.cfg
index e068a0c..b3b7ff4 100644
--- a/arm/unittests.cfg
+++ b/arm/unittests.cfg
@@ -35,3 +35,14 @@ file = selftest.flat
smp = `getconf _NPROCESSORS_CONF`
extra_params = -append 'smp'
groups = selftest
+
+# Test PMU support without -icount
+[pmu]
+file = pmu.flat
+groups = pmu
+
+# Test PMU support with -icount
+[pmu-icount]
+file = pmu.flat
+groups = pmu
+extra_params = -icount 0
diff --git a/config/config-arm64.mak b/config/config-arm64.mak
index d61b703..140b611 100644
--- a/config/config-arm64.mak
+++ b/config/config-arm64.mak
@@ -12,9 +12,11 @@ cflatobjs += lib/arm64/processor.o
cflatobjs += lib/arm64/spinlock.o
# arm64 specific tests
-tests =
+tests = $(TEST_DIR)/pmu.flat
include config/config-arm-common.mak
arch_clean: arm_clean
$(RM) lib/arm64/.*.d
+
+$(TEST_DIR)/pmu.elf: $(cstart.o) $(TEST_DIR)/pmu.o
--
Qualcomm Innovation Center, Inc.
The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum,
a Linux Foundation Collaborative Project
WARNING: multiple messages have this Message-ID (diff)
From: Christopher Covington <cov@codeaurora.org>
To: drjones@redhat.com, qemu-devel@nongnu.org, kvm@vger.kernel.org,
kvmarm@lists.cs.columbia.edu
Cc: wei@redhat.com, Christopher Covington <cov@codeaurora.org>,
shannon.zhao@linaro.org, alistair.francis@xilinx.com
Subject: [Qemu-devel] [kvm-unit-tests PATCHv2] arm: Add PMU test
Date: Fri, 2 Oct 2015 11:48:28 -0400 [thread overview]
Message-ID: <1443800908-12159-1-git-send-email-cov@codeaurora.org> (raw)
In-Reply-To: <1443728841-10501-1-git-send-email-cov@codeaurora.org>
Add test the ARM Performance Monitors Unit (PMU). The informational
fields from the control register are printed, but not checked, and
the number of cycles it takes to run a known-instruction-count loop
is printed, but not checked. Once QEMU is fixed, we can at least
begin to check for IPC == 1 when using -icount.
Signed-off-by: Christopher Covington <cov@codeaurora.org>
---
arm/pmu.c | 89 +++++++++++++++++++++++++++++++++++++++++++++++++
arm/unittests.cfg | 11 ++++++
config/config-arm64.mak | 4 ++-
3 files changed, 103 insertions(+), 1 deletion(-)
create mode 100644 arm/pmu.c
diff --git a/arm/pmu.c b/arm/pmu.c
new file mode 100644
index 0000000..f724c2c
--- /dev/null
+++ b/arm/pmu.c
@@ -0,0 +1,89 @@
+/*
+ * Test the ARM Performance Monitors Unit (PMU).
+ *
+ * Copyright 2015 The Linux Foundation. All rights reserved.
+ *
+ * This program is free software; you can redistribute it and/or modify it
+ * under the terms of the GNU Lesser General Public License version 2.1 and
+ * only version 2.1 as published by the Free Software Foundation.
+ *
+ * This program is distributed in the hope that it will be useful, but WITHOUT
+ * ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or
+ * FITNESS FOR A PARTICULAR PURPOSE. See the GNU Lesser General Public License
+ * for more details.
+ */
+#include "libcflat.h"
+
+struct pmu_data {
+ union {
+ uint32_t pmcr_el0;
+ struct {
+ unsigned int enable:1;
+ unsigned int event_counter_reset:1;
+ unsigned int cycle_counter_reset:1;
+ unsigned int cycle_counter_clock_divider:1;
+ unsigned int event_counter_export:1;
+ unsigned int cycle_counter_disable_when_prohibited:1;
+ unsigned int cycle_counter_long:1;
+ unsigned int zeros:4;
+ unsigned int num_counters:5;
+ unsigned int identification_code:8;
+ unsigned int implementor:8;
+ };
+ };
+};
+
+/* Execute a known number of guest instructions. Only odd instruction counts
+ * greater than or equal to 3 are supported. The control register (PMCR) is
+ * initialized with the provided value (allowing for example for the cycle
+ * counter or eventer count to be reset if needed). After the known instruction
+ * count loop, zero is written to the PMCR to disable counting, allowing the
+ * cycle counter or event counters to be read as needed at a later time.
+ */
+static void measure_instrs(int len, struct pmu_data pmcr)
+{
+ int i = (len - 1) / 2;
+
+ if (len < 3 || ((len - 1) % 2))
+ abort();
+
+ asm volatile(
+ "msr pmcr_el0, %[pmcr]\n"
+ "1: subs %[i], %[i], #1\n"
+ "b.gt 1b\n"
+ "msr pmcr_el0, xzr"
+ : [i] "+r" (i) : [pmcr] "r" (pmcr) : "cc");
+}
+
+int main()
+{
+ struct pmu_data pmcr;
+ const int samples = 10;
+
+ asm volatile("mrs %0, pmcr_el0" : "=r" (pmcr));
+
+ printf("PMU implementor: %c\n", pmcr.implementor);
+ printf("Identification code: 0x%x\n", pmcr.identification_code);
+ printf("Event counters: %d\n", pmcr.num_counters);
+
+ pmcr.cycle_counter_reset = 1;
+ pmcr.enable = 1;
+
+ printf("\ninstructions : cycles0 cycles1 ...\n");
+
+ for (int i = 3; i < 300; i += 32) {
+ int avg, sum = 0;
+ printf("%d :", i);
+ for (int j = 0; j < samples; j++) {
+ int val;
+ measure_instrs(i, pmcr);
+ asm volatile("mrs %0, pmccntr_el0" : "=r" (val));
+ sum += val;
+ printf(" %d", val);
+ }
+ avg = sum / samples;
+ printf(" sum=%d avg=%d avg_ipc=%d avg_cpi=%d\n", sum, avg, i / avg, avg / i);
+ }
+
+ return report_summary();
+}
diff --git a/arm/unittests.cfg b/arm/unittests.cfg
index e068a0c..b3b7ff4 100644
--- a/arm/unittests.cfg
+++ b/arm/unittests.cfg
@@ -35,3 +35,14 @@ file = selftest.flat
smp = `getconf _NPROCESSORS_CONF`
extra_params = -append 'smp'
groups = selftest
+
+# Test PMU support without -icount
+[pmu]
+file = pmu.flat
+groups = pmu
+
+# Test PMU support with -icount
+[pmu-icount]
+file = pmu.flat
+groups = pmu
+extra_params = -icount 0
diff --git a/config/config-arm64.mak b/config/config-arm64.mak
index d61b703..140b611 100644
--- a/config/config-arm64.mak
+++ b/config/config-arm64.mak
@@ -12,9 +12,11 @@ cflatobjs += lib/arm64/processor.o
cflatobjs += lib/arm64/spinlock.o
# arm64 specific tests
-tests =
+tests = $(TEST_DIR)/pmu.flat
include config/config-arm-common.mak
arch_clean: arm_clean
$(RM) lib/arm64/.*.d
+
+$(TEST_DIR)/pmu.elf: $(cstart.o) $(TEST_DIR)/pmu.o
--
Qualcomm Innovation Center, Inc.
The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum,
a Linux Foundation Collaborative Project
next prev parent reply other threads:[~2015-10-02 15:48 UTC|newest]
Thread overview: 73+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-10-01 19:47 [PATCH] arm: Add PMU test Christopher Covington
2015-10-01 19:47 ` [Qemu-devel] " Christopher Covington
2015-10-02 9:58 ` Andrew Jones
2015-10-02 9:58 ` Andrew Jones
2015-10-02 15:48 ` Christopher Covington [this message]
2015-10-02 15:48 ` [Qemu-devel] [kvm-unit-tests PATCHv2] " Christopher Covington
2015-10-05 21:37 ` Wei Huang
2015-10-05 21:37 ` [Qemu-devel] " Wei Huang
2015-10-06 17:49 ` [kvm-unit-tests PATCHv3] ARM PMU tests Christopher Covington
2015-10-06 17:49 ` [Qemu-devel] " Christopher Covington
2015-10-06 17:49 ` [kvm-unit-tests PATCHv3 1/3] arm: Add PMU test Christopher Covington
2015-10-06 17:49 ` [Qemu-devel] " Christopher Covington
2015-10-06 19:38 ` Andrew Jones
2015-10-06 19:38 ` [Qemu-devel] " Andrew Jones
2015-10-06 17:49 ` [kvm-unit-tests PATCHv3 2/3] arm: pmu: Check cycle count increases Christopher Covington
2015-10-06 17:49 ` [Qemu-devel] " Christopher Covington
2015-10-06 19:49 ` Andrew Jones
2015-10-06 19:49 ` Andrew Jones
2015-10-06 17:49 ` [kvm-unit-tests PATCHv3 3/3] arm: pmu: Add CPI checking Christopher Covington
2015-10-06 17:49 ` [Qemu-devel] " Christopher Covington
2015-10-06 20:14 ` Andrew Jones
2015-10-06 20:14 ` [Qemu-devel] " Andrew Jones
2015-10-12 15:07 ` [kvm-unit-tests PATCHv4] ARM PMU tests Christopher Covington
2015-10-12 15:07 ` [Qemu-devel] " Christopher Covington
2015-10-12 15:07 ` [kvm-unit-tests PATCHv4 1/3] arm: Add PMU test Christopher Covington
2015-10-12 15:07 ` [Qemu-devel] " Christopher Covington
2015-10-18 17:54 ` Andrew Jones
2015-10-18 17:54 ` Andrew Jones
2015-10-12 15:07 ` [kvm-unit-tests PATCHv4 2/3] arm: pmu: Check cycle count increases Christopher Covington
2015-10-12 15:07 ` [Qemu-devel] " Christopher Covington
2015-10-18 18:10 ` Andrew Jones
2015-10-18 18:10 ` Andrew Jones
2015-10-12 15:07 ` [kvm-unit-tests PATCHv4 3/3] arm: pmu: Add CPI checking Christopher Covington
2015-10-12 15:07 ` [Qemu-devel] " Christopher Covington
2015-10-18 18:28 ` Andrew Jones
2015-10-18 18:28 ` Andrew Jones
2015-10-19 15:44 ` Christopher Covington
2015-10-19 15:44 ` Christopher Covington
2015-10-26 12:25 ` Andrew Jones
2015-10-26 12:25 ` Andrew Jones
2015-10-18 18:29 ` [Qemu-devel] [kvm-unit-tests PATCHv4] ARM PMU tests Andrew Jones
2015-10-18 18:29 ` Andrew Jones
2015-10-26 15:38 ` [kvm-unit-tests PATCHv5] " Christopher Covington
2015-10-26 15:38 ` [Qemu-devel] " Christopher Covington
2015-10-26 15:38 ` [kvm-unit-tests PATCHv5 1/3] arm: Add PMU test Christopher Covington
2015-10-26 15:38 ` [Qemu-devel] " Christopher Covington
2015-10-26 15:38 ` [kvm-unit-tests PATCHv5 2/3] arm: pmu: Check cycle count increases Christopher Covington
2015-10-26 15:38 ` [Qemu-devel] " Christopher Covington
2015-10-26 15:58 ` Andrew Jones
2015-10-26 15:58 ` Andrew Jones
2015-10-26 16:04 ` Christopher Covington
2015-10-26 16:04 ` Christopher Covington
2015-10-26 16:04 ` Andrew Jones
2015-10-26 16:04 ` Andrew Jones
2015-10-26 15:38 ` [kvm-unit-tests PATCHv5 3/3] arm: pmu: Add CPI checking Christopher Covington
2015-10-26 15:38 ` [Qemu-devel] " Christopher Covington
2015-10-26 16:28 ` Andrew Jones
2015-10-26 16:28 ` Andrew Jones
2015-10-28 19:12 ` [kvm-unit-tests PATCHv6] ARM PMU tests Christopher Covington
2015-10-28 19:12 ` [Qemu-devel] " Christopher Covington
2015-10-28 19:12 ` [kvm-unit-tests PATCHv5 1/3] arm: Add PMU test Christopher Covington
2015-10-28 19:12 ` [Qemu-devel] " Christopher Covington
2015-10-28 19:12 ` [kvm-unit-tests PATCHv5 2/3] arm: pmu: Check cycle count increases Christopher Covington
2015-10-28 19:12 ` [Qemu-devel] " Christopher Covington
2015-10-28 19:12 ` [kvm-unit-tests PATCHv5 3/3] arm: pmu: Add CPI checking Christopher Covington
2015-10-28 19:12 ` [Qemu-devel] " Christopher Covington
2015-10-30 13:00 ` Andrew Jones
2015-10-30 13:00 ` Andrew Jones
2015-10-30 19:32 ` Christopher Covington
2015-10-30 19:32 ` Christopher Covington
2015-11-02 15:58 ` Andrew Jones
2015-11-11 2:05 ` Andrew Jones
2015-11-11 12:50 ` Christopher Covington
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1443800908-12159-1-git-send-email-cov@codeaurora.org \
--to=cov@codeaurora.org \
--cc=alistair.francis@xilinx.com \
--cc=drjones@redhat.com \
--cc=kvm@vger.kernel.org \
--cc=kvmarm@lists.cs.columbia.edu \
--cc=qemu-devel@nongnu.org \
--cc=shannon.zhao@linaro.org \
--cc=wei@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.