* [PATCH 1/1] drm/i915/bxt: Set time interval unit to 0.833us
@ 2015-09-18 18:09 Sagar Arun Kamble
2015-09-21 12:39 ` Imre Deak
2015-10-06 18:16 ` Imre Deak
0 siblings, 2 replies; 6+ messages in thread
From: Sagar Arun Kamble @ 2015-09-18 18:09 UTC (permalink / raw)
To: intel-gfx; +Cc: Ankitprasad Sharma, Akash Goel
From: Akash Goel <akash.goel@intel.com>
Signed-off-by: Ankitprasad Sharma <ankitprasad.r.sharma@intel.com>
Signed-off-by: Akash Goel <akash.goel@intel.com>
Signed-off-by: Sagar Arun Kamble <sagar.a.kamble@intel.com>
---
drivers/gpu/drm/i915/i915_reg.h | 5 ++++-
1 file changed, 4 insertions(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/i915/i915_reg.h b/drivers/gpu/drm/i915/i915_reg.h
index 67bf205..6b1998c 100644
--- a/drivers/gpu/drm/i915/i915_reg.h
+++ b/drivers/gpu/drm/i915/i915_reg.h
@@ -2802,8 +2802,11 @@ enum skl_disp_power_wells {
#define INTERVAL_1_28_US(us) (((us) * 100) >> 7)
#define INTERVAL_1_33_US(us) (((us) * 3) >> 2)
+#define INTERVAL_0_833_US(us) (((us) * 6) / 5)
#define GT_INTERVAL_FROM_US(dev_priv, us) (IS_GEN9(dev_priv) ? \
- INTERVAL_1_33_US(us) : \
+ (IS_BROXTON(dev_priv) ? \
+ INTERVAL_0_833_US(us) : \
+ INTERVAL_1_33_US(us)) : \
INTERVAL_1_28_US(us))
/*
--
1.9.1
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply related [flat|nested] 6+ messages in thread* Re: [PATCH 1/1] drm/i915/bxt: Set time interval unit to 0.833us
2015-09-18 18:09 [PATCH 1/1] drm/i915/bxt: Set time interval unit to 0.833us Sagar Arun Kamble
@ 2015-09-21 12:39 ` Imre Deak
2015-10-06 18:16 ` Imre Deak
1 sibling, 0 replies; 6+ messages in thread
From: Imre Deak @ 2015-09-21 12:39 UTC (permalink / raw)
To: Sagar Arun Kamble; +Cc: Ankitprasad Sharma, intel-gfx, Akash Goel
On pe, 2015-09-18 at 23:39 +0530, Sagar Arun Kamble wrote:
> From: Akash Goel <akash.goel@intel.com>
>
> Signed-off-by: Ankitprasad Sharma <ankitprasad.r.sharma@intel.com>
> Signed-off-by: Akash Goel <akash.goel@intel.com>
> Signed-off-by: Sagar Arun Kamble <sagar.a.kamble@intel.com>
> ---
> drivers/gpu/drm/i915/i915_reg.h | 5 ++++-
> 1 file changed, 4 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/i915/i915_reg.h b/drivers/gpu/drm/i915/i915_reg.h
> index 67bf205..6b1998c 100644
> --- a/drivers/gpu/drm/i915/i915_reg.h
> +++ b/drivers/gpu/drm/i915/i915_reg.h
> @@ -2802,8 +2802,11 @@ enum skl_disp_power_wells {
>
> #define INTERVAL_1_28_US(us) (((us) * 100) >> 7)
> #define INTERVAL_1_33_US(us) (((us) * 3) >> 2)
> +#define INTERVAL_0_833_US(us) (((us) * 6) / 5)
> #define GT_INTERVAL_FROM_US(dev_priv, us) (IS_GEN9(dev_priv) ? \
> - INTERVAL_1_33_US(us) : \
> + (IS_BROXTON(dev_priv) ? \
> + INTERVAL_0_833_US(us) : \
> + INTERVAL_1_33_US(us)) : \
> INTERVAL_1_28_US(us))
Note that neither of the GEN9 values are mentioned in Bspec, so a
request for update should be filed there. I haven't found any other
place that would document this either, could you point me to it?
--Imre
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [PATCH 1/1] drm/i915/bxt: Set time interval unit to 0.833us
2015-09-18 18:09 [PATCH 1/1] drm/i915/bxt: Set time interval unit to 0.833us Sagar Arun Kamble
2015-09-21 12:39 ` Imre Deak
@ 2015-10-06 18:16 ` Imre Deak
2015-10-07 13:29 ` Daniel Vetter
1 sibling, 1 reply; 6+ messages in thread
From: Imre Deak @ 2015-10-06 18:16 UTC (permalink / raw)
To: Sagar Arun Kamble; +Cc: Ankitprasad Sharma, intel-gfx, Akash Goel
On pe, 2015-09-18 at 23:39 +0530, Sagar Arun Kamble wrote:
> From: Akash Goel <akash.goel@intel.com>
>
> Signed-off-by: Ankitprasad Sharma <ankitprasad.r.sharma@intel.com>
> Signed-off-by: Akash Goel <akash.goel@intel.com>
> Signed-off-by: Sagar Arun Kamble <sagar.a.kamble@intel.com>
The comment about units in gen6_set_rps_thresholds() is outdated, so you
could update that while at it. In any case this looks ok, so:
Reviewed-by: Imre Deak <imre.deak@intel.com>
> ---
> drivers/gpu/drm/i915/i915_reg.h | 5 ++++-
> 1 file changed, 4 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/i915/i915_reg.h b/drivers/gpu/drm/i915/i915_reg.h
> index 67bf205..6b1998c 100644
> --- a/drivers/gpu/drm/i915/i915_reg.h
> +++ b/drivers/gpu/drm/i915/i915_reg.h
> @@ -2802,8 +2802,11 @@ enum skl_disp_power_wells {
>
> #define INTERVAL_1_28_US(us) (((us) * 100) >> 7)
> #define INTERVAL_1_33_US(us) (((us) * 3) >> 2)
> +#define INTERVAL_0_833_US(us) (((us) * 6) / 5)
> #define GT_INTERVAL_FROM_US(dev_priv, us) (IS_GEN9(dev_priv) ? \
> - INTERVAL_1_33_US(us) : \
> + (IS_BROXTON(dev_priv) ? \
> + INTERVAL_0_833_US(us) : \
> + INTERVAL_1_33_US(us)) : \
> INTERVAL_1_28_US(us))
>
> /*
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [PATCH 1/1] drm/i915/bxt: Set time interval unit to 0.833us
2015-10-06 18:16 ` Imre Deak
@ 2015-10-07 13:29 ` Daniel Vetter
2015-10-07 13:35 ` Imre Deak
0 siblings, 1 reply; 6+ messages in thread
From: Daniel Vetter @ 2015-10-07 13:29 UTC (permalink / raw)
To: Imre Deak; +Cc: Ankitprasad Sharma, intel-gfx, Akash Goel
On Tue, Oct 06, 2015 at 09:16:28PM +0300, Imre Deak wrote:
> On pe, 2015-09-18 at 23:39 +0530, Sagar Arun Kamble wrote:
> > From: Akash Goel <akash.goel@intel.com>
> >
> > Signed-off-by: Ankitprasad Sharma <ankitprasad.r.sharma@intel.com>
> > Signed-off-by: Akash Goel <akash.goel@intel.com>
> > Signed-off-by: Sagar Arun Kamble <sagar.a.kamble@intel.com>
>
> The comment about units in gen6_set_rps_thresholds() is outdated, so you
> could update that while at it. In any case this looks ok, so:
> Reviewed-by: Imre Deak <imre.deak@intel.com>
In your previous review you noticed that Bspec is still outdated. Has that
been fixed meanwhile?
-Daniel
>
> > ---
> > drivers/gpu/drm/i915/i915_reg.h | 5 ++++-
> > 1 file changed, 4 insertions(+), 1 deletion(-)
> >
> > diff --git a/drivers/gpu/drm/i915/i915_reg.h b/drivers/gpu/drm/i915/i915_reg.h
> > index 67bf205..6b1998c 100644
> > --- a/drivers/gpu/drm/i915/i915_reg.h
> > +++ b/drivers/gpu/drm/i915/i915_reg.h
> > @@ -2802,8 +2802,11 @@ enum skl_disp_power_wells {
> >
> > #define INTERVAL_1_28_US(us) (((us) * 100) >> 7)
> > #define INTERVAL_1_33_US(us) (((us) * 3) >> 2)
> > +#define INTERVAL_0_833_US(us) (((us) * 6) / 5)
> > #define GT_INTERVAL_FROM_US(dev_priv, us) (IS_GEN9(dev_priv) ? \
> > - INTERVAL_1_33_US(us) : \
> > + (IS_BROXTON(dev_priv) ? \
> > + INTERVAL_0_833_US(us) : \
> > + INTERVAL_1_33_US(us)) : \
> > INTERVAL_1_28_US(us))
> >
> > /*
>
>
> _______________________________________________
> Intel-gfx mailing list
> Intel-gfx@lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/intel-gfx
--
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [PATCH 1/1] drm/i915/bxt: Set time interval unit to 0.833us
2015-10-07 13:29 ` Daniel Vetter
@ 2015-10-07 13:35 ` Imre Deak
2015-10-07 14:07 ` Daniel Vetter
0 siblings, 1 reply; 6+ messages in thread
From: Imre Deak @ 2015-10-07 13:35 UTC (permalink / raw)
To: Daniel Vetter; +Cc: Ankitprasad Sharma, intel-gfx, Akash Goel
On ke, 2015-10-07 at 15:29 +0200, Daniel Vetter wrote:
> On Tue, Oct 06, 2015 at 09:16:28PM +0300, Imre Deak wrote:
> > On pe, 2015-09-18 at 23:39 +0530, Sagar Arun Kamble wrote:
> > > From: Akash Goel <akash.goel@intel.com>
> > >
> > > Signed-off-by: Ankitprasad Sharma <ankitprasad.r.sharma@intel.com>
> > > Signed-off-by: Akash Goel <akash.goel@intel.com>
> > > Signed-off-by: Sagar Arun Kamble <sagar.a.kamble@intel.com>
> >
> > The comment about units in gen6_set_rps_thresholds() is outdated, so you
> > could update that while at it. In any case this looks ok, so:
> > Reviewed-by: Imre Deak <imre.deak@intel.com>
>
> In your previous review you noticed that Bspec is still outdated. Has that
> been fixed meanwhile?
Yep, Sagar pointed to a page in BSpec where the relevant clocks are
defined ("Timestamp bases") and he also filed a change request in Bspec
now to update the register description itself accordingly. Should've
mentioned this when adding my r-b.
--Imre
> -Daniel
>
> >
> > > ---
> > > drivers/gpu/drm/i915/i915_reg.h | 5 ++++-
> > > 1 file changed, 4 insertions(+), 1 deletion(-)
> > >
> > > diff --git a/drivers/gpu/drm/i915/i915_reg.h b/drivers/gpu/drm/i915/i915_reg.h
> > > index 67bf205..6b1998c 100644
> > > --- a/drivers/gpu/drm/i915/i915_reg.h
> > > +++ b/drivers/gpu/drm/i915/i915_reg.h
> > > @@ -2802,8 +2802,11 @@ enum skl_disp_power_wells {
> > >
> > > #define INTERVAL_1_28_US(us) (((us) * 100) >> 7)
> > > #define INTERVAL_1_33_US(us) (((us) * 3) >> 2)
> > > +#define INTERVAL_0_833_US(us) (((us) * 6) / 5)
> > > #define GT_INTERVAL_FROM_US(dev_priv, us) (IS_GEN9(dev_priv) ? \
> > > - INTERVAL_1_33_US(us) : \
> > > + (IS_BROXTON(dev_priv) ? \
> > > + INTERVAL_0_833_US(us) : \
> > > + INTERVAL_1_33_US(us)) : \
> > > INTERVAL_1_28_US(us))
> > >
> > > /*
> >
> >
> > _______________________________________________
> > Intel-gfx mailing list
> > Intel-gfx@lists.freedesktop.org
> > http://lists.freedesktop.org/mailman/listinfo/intel-gfx
>
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [PATCH 1/1] drm/i915/bxt: Set time interval unit to 0.833us
2015-10-07 13:35 ` Imre Deak
@ 2015-10-07 14:07 ` Daniel Vetter
0 siblings, 0 replies; 6+ messages in thread
From: Daniel Vetter @ 2015-10-07 14:07 UTC (permalink / raw)
To: Imre Deak; +Cc: Ankitprasad Sharma, intel-gfx, Akash Goel
On Wed, Oct 07, 2015 at 04:35:51PM +0300, Imre Deak wrote:
> On ke, 2015-10-07 at 15:29 +0200, Daniel Vetter wrote:
> > On Tue, Oct 06, 2015 at 09:16:28PM +0300, Imre Deak wrote:
> > > On pe, 2015-09-18 at 23:39 +0530, Sagar Arun Kamble wrote:
> > > > From: Akash Goel <akash.goel@intel.com>
> > > >
> > > > Signed-off-by: Ankitprasad Sharma <ankitprasad.r.sharma@intel.com>
> > > > Signed-off-by: Akash Goel <akash.goel@intel.com>
> > > > Signed-off-by: Sagar Arun Kamble <sagar.a.kamble@intel.com>
> > >
> > > The comment about units in gen6_set_rps_thresholds() is outdated, so you
> > > could update that while at it. In any case this looks ok, so:
> > > Reviewed-by: Imre Deak <imre.deak@intel.com>
> >
> > In your previous review you noticed that Bspec is still outdated. Has that
> > been fixed meanwhile?
>
> Yep, Sagar pointed to a page in BSpec where the relevant clocks are
> defined ("Timestamp bases") and he also filed a change request in Bspec
> now to update the register description itself accordingly. Should've
> mentioned this when adding my r-b.
Awesome. Added a note about this and applied the patch.
Thanks, Daniel
--
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2015-10-07 14:04 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-09-18 18:09 [PATCH 1/1] drm/i915/bxt: Set time interval unit to 0.833us Sagar Arun Kamble
2015-09-21 12:39 ` Imre Deak
2015-10-06 18:16 ` Imre Deak
2015-10-07 13:29 ` Daniel Vetter
2015-10-07 13:35 ` Imre Deak
2015-10-07 14:07 ` Daniel Vetter
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.