From: Ian Campbell <ian.campbell@citrix.com>
To: He Chen <he.chen@linux.intel.com>, xen-devel@lists.xenproject.org
Cc: wei.liu2@citrix.com, stefano.stabellini@eu.citrix.com,
andrew.cooper3@citrix.com, ian.jackson@eu.citrix.com,
jbeulich@suse.com, chao.p.peng@linux.intel.com, keir@xen.org
Subject: Re: [PATCH v7 3/3] tools & docs: add tools and docs support for Intel CDP
Date: Tue, 13 Oct 2015 17:23:29 +0100 [thread overview]
Message-ID: <1444753409.23192.111.camel@citrix.com> (raw)
In-Reply-To: <1444726426-10567-4-git-send-email-he.chen@linux.intel.com>
On Tue, 2015-10-13 at 16:53 +0800, He Chen wrote:
> @@ -8445,29 +8447,46 @@ out:
> return rc;
> }
>
> -static void psr_cat_print_one_domain_cbm(uint32_t domid, uint32_t
> socketid)
> +static void psr_cat_print_one_domain_cbm_type(uint32_t domid, uint32_t
> socketid,
> + libxl_psr_cbm_type type)
> {
> - char *domain_name;
> uint64_t cbm;
> + if (!libxl_psr_cat_get_cbm(ctx, domid, type, socketid, &cbm))
> + printf("%#16"PRIx64, cbm);
> + else
> + printf("%16s", "error");
Coding style is 4 space indentation, here you appear to have 8 for the
first level and 4 for the second level of indentation.
With that fixed:
Acked-by: Ian Campbell <ian.campbell@citrix.com>
next prev parent reply other threads:[~2015-10-13 16:23 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-10-13 8:53 [PATCH v7 0/3] detect and initialize CDP (Code/Data Prioritization) feature He Chen
2015-10-13 8:53 ` [PATCH v7 1/3] x86: Support enable CDP by boot parameter and add get CDP status He Chen
2015-10-14 2:02 ` Chao Peng
2015-10-13 8:53 ` [PATCH v7 2/3] x86: add domctl cmd to set/get CDP code/data CBM He Chen
2015-10-13 15:38 ` Jan Beulich
2015-10-14 2:07 ` Chao Peng
2015-10-15 14:57 ` Olaf Hering
2015-10-15 15:10 ` Wei Liu
2015-10-15 15:22 ` Olaf Hering
2015-10-15 15:26 ` Wei Liu
2015-10-15 15:30 ` Wei Liu
2015-10-16 9:10 ` Olaf Hering
2015-10-15 15:47 ` Jan Beulich
2015-10-16 8:24 ` He Chen
2015-10-16 8:32 ` Jan Beulich
2015-10-13 8:53 ` [PATCH v7 3/3] tools & docs: add tools and docs support for Intel CDP He Chen
2015-10-13 16:23 ` Ian Campbell [this message]
2015-10-14 2:38 ` Chao Peng
2015-10-14 8:52 ` Ian Campbell
2015-10-14 9:08 ` Dario Faggioli
2015-10-14 9:20 ` Ian Campbell
2015-10-14 10:52 ` Jan Beulich
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1444753409.23192.111.camel@citrix.com \
--to=ian.campbell@citrix.com \
--cc=andrew.cooper3@citrix.com \
--cc=chao.p.peng@linux.intel.com \
--cc=he.chen@linux.intel.com \
--cc=ian.jackson@eu.citrix.com \
--cc=jbeulich@suse.com \
--cc=keir@xen.org \
--cc=stefano.stabellini@eu.citrix.com \
--cc=wei.liu2@citrix.com \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.