From: Chao Peng <chao.p.peng@linux.intel.com>
To: Jan Beulich <JBeulich@suse.com>
Cc: wei.liu2@citrix.com, ian.campbell@citrix.com,
stefano.stabellini@eu.citrix.com, andrew.cooper3@citrix.com,
He Chen <he.chen@linux.intel.com>,
ian.jackson@eu.citrix.com, xen-devel@lists.xenproject.org,
keir@xen.org
Subject: Re: [PATCH v7 2/3] x86: add domctl cmd to set/get CDP code/data CBM
Date: Wed, 14 Oct 2015 10:07:19 +0800 [thread overview]
Message-ID: <20151014020719.GB4427@pengc-linux.bj.intel.com> (raw)
In-Reply-To: <561D41B202000078000AAAD8@prv-mh.provo.novell.com>
On Tue, Oct 13, 2015 at 09:38:58AM -0600, Jan Beulich wrote:
> >>> On 13.10.15 at 10:53, <he.chen@linux.intel.com> wrote:
> > @@ -331,19 +357,34 @@ static bool_t psr_check_cbm(unsigned int cbm_len, uint64_t cbm)
> > struct cos_cbm_info
> > {
> > unsigned int cos;
> > - uint64_t cbm;
> > + uint64_t cbm_code;
> > + uint64_t cbm_data;
> > + bool_t cdp;
> > };
>
> The bool_t field really fits well in the gap between the first and second
> one; I'll take the liberty to adjust this when committing (unless Chao
> comes forward with further comments; otherwise I'm kind of hoping
> for a Reviewed-by-him).
Correct, it can be a optimization and I don't see any problem. So please feel
free to adjust it. Thereby:
Reviewed-by: Chao Peng <chao.p.peng@linux.intel.com>
>
> Jan
next prev parent reply other threads:[~2015-10-14 2:11 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-10-13 8:53 [PATCH v7 0/3] detect and initialize CDP (Code/Data Prioritization) feature He Chen
2015-10-13 8:53 ` [PATCH v7 1/3] x86: Support enable CDP by boot parameter and add get CDP status He Chen
2015-10-14 2:02 ` Chao Peng
2015-10-13 8:53 ` [PATCH v7 2/3] x86: add domctl cmd to set/get CDP code/data CBM He Chen
2015-10-13 15:38 ` Jan Beulich
2015-10-14 2:07 ` Chao Peng [this message]
2015-10-15 14:57 ` Olaf Hering
2015-10-15 15:10 ` Wei Liu
2015-10-15 15:22 ` Olaf Hering
2015-10-15 15:26 ` Wei Liu
2015-10-15 15:30 ` Wei Liu
2015-10-16 9:10 ` Olaf Hering
2015-10-15 15:47 ` Jan Beulich
2015-10-16 8:24 ` He Chen
2015-10-16 8:32 ` Jan Beulich
2015-10-13 8:53 ` [PATCH v7 3/3] tools & docs: add tools and docs support for Intel CDP He Chen
2015-10-13 16:23 ` Ian Campbell
2015-10-14 2:38 ` Chao Peng
2015-10-14 8:52 ` Ian Campbell
2015-10-14 9:08 ` Dario Faggioli
2015-10-14 9:20 ` Ian Campbell
2015-10-14 10:52 ` Jan Beulich
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20151014020719.GB4427@pengc-linux.bj.intel.com \
--to=chao.p.peng@linux.intel.com \
--cc=JBeulich@suse.com \
--cc=andrew.cooper3@citrix.com \
--cc=he.chen@linux.intel.com \
--cc=ian.campbell@citrix.com \
--cc=ian.jackson@eu.citrix.com \
--cc=keir@xen.org \
--cc=stefano.stabellini@eu.citrix.com \
--cc=wei.liu2@citrix.com \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.