Re: [PATCH v7 3/3] tools & docs: add tools and docs support for Intel CDP

[Ian Campbell <ian.campbell@citrix.com>]

On Wed, 2015-10-14 at 10:38 +0800, Chao Peng wrote:
> > diff --git a/tools/libxl/xl_cmdimpl.c b/tools/libxl/xl_cmdimpl.c
> > index 365798b..8db0132 100644
> > --- a/tools/libxl/xl_cmdimpl.c
> > +++ b/tools/libxl/xl_cmdimpl.c
> > @@ -8434,6 +8434,8 @@ static int psr_cat_hwinfo(void)
> >          }
> >          printf("%-16s: %u\n", "Socket ID", info[i].id);
> >          printf("%-16s: %uKB\n", "L3 Cache", l3_cache_size);
> > +        printf("%-16s: %s\n", "CDP Status",
> > +               info->cdp_enabled ? "Enabled" : "Disabled");
> 
> Sorry I didn't notice this before but I guess 'info->cdp_enabled' here
> really would be 'info[i].cdp_enabled' as CDP status is per-socket.
> Current code will always print the data for the first socket in each
> iteration, which is undesirable.

I think you are correct, well spotted.


> With this and the indention issue proposed by Ian being fixed:
> 
> Reviewed-by: Chao Peng <chao.p.peng@linux.intel.com>
> 
> >          printf("%-16s: %u\n", "Maximum COS", info[i].cos_max);
> >          printf("%-16s: %u\n", "CBM length", info[i].cbm_len);
> >          printf("%-16s: %#llx\n", "Default CBM",
> > @@ -8445,29 +8447,46 @@ out:
> >      return rc;
> >  }