From: Ian Campbell <ian.campbell@citrix.com>
To: Wei Liu <wei.liu2@citrix.com>,
Xen-devel <xen-devel@lists.xenproject.org>
Cc: Ian Jackson <Ian.Jackson@eu.citrix.com>,
Stefano Stabellini <stefano.stabellini@eu.citrix.com>
Subject: Re: [PATCH] tools/xenpaging: install directory with default permission
Date: Wed, 21 Oct 2015 14:46:54 +0100 [thread overview]
Message-ID: <1445435214.9563.150.camel@citrix.com> (raw)
In-Reply-To: <1445429422-18749-1-git-send-email-wei.liu2@citrix.com>
On Wed, 2015-10-21 at 13:10 +0100, Wei Liu wrote:
> There is no need to explicitly ask for 700.
Is the rationale for 0700 explicitly not that the files in here will
contain possibly sensitive date from guest memory?
i.e. the use of something other than the default is deliberate.
If you think that is wrong then I think the changelog should explain why.
> Signed-off-by: Wei Liu <wei.liu2@citrix.com>
> ---
> tools/xenpaging/Makefile | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/tools/xenpaging/Makefile b/tools/xenpaging/Makefile
> index 2407a30..4badaae 100644
> --- a/tools/xenpaging/Makefile
> +++ b/tools/xenpaging/Makefile
> @@ -24,7 +24,7 @@ xenpaging: $(OBJS)
> $(CC) $(LDFLAGS) -o $@ $^ $(LDLIBS) $(APPEND_LDFLAGS)
>
> install: all
> - $(INSTALL_DIR) -m 0700 $(DESTDIR)$(XEN_PAGING_DIR)
> + $(INSTALL_DIR) $(DESTDIR)$(XEN_PAGING_DIR)
> $(INSTALL_DIR) $(DESTDIR)$(LIBEXEC_BIN)
> $(INSTALL_PROG) $(IBINS) $(DESTDIR)$(LIBEXEC_BIN)
>
next prev parent reply other threads:[~2015-10-21 13:47 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-10-21 12:10 [PATCH] tools/xenpaging: install directory with default permission Wei Liu
2015-10-21 13:46 ` Ian Campbell [this message]
2015-10-21 14:09 ` Wei Liu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1445435214.9563.150.camel@citrix.com \
--to=ian.campbell@citrix.com \
--cc=Ian.Jackson@eu.citrix.com \
--cc=stefano.stabellini@eu.citrix.com \
--cc=wei.liu2@citrix.com \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.