* [PATCH] tools/xenpaging: install directory with default permission
@ 2015-10-21 12:10 Wei Liu
2015-10-21 13:46 ` Ian Campbell
0 siblings, 1 reply; 3+ messages in thread
From: Wei Liu @ 2015-10-21 12:10 UTC (permalink / raw)
To: Xen-devel; +Cc: Wei Liu, Ian Jackson, Ian Campbell, Stefano Stabellini
There is no need to explicitly ask for 700.
Signed-off-by: Wei Liu <wei.liu2@citrix.com>
---
tools/xenpaging/Makefile | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/tools/xenpaging/Makefile b/tools/xenpaging/Makefile
index 2407a30..4badaae 100644
--- a/tools/xenpaging/Makefile
+++ b/tools/xenpaging/Makefile
@@ -24,7 +24,7 @@ xenpaging: $(OBJS)
$(CC) $(LDFLAGS) -o $@ $^ $(LDLIBS) $(APPEND_LDFLAGS)
install: all
- $(INSTALL_DIR) -m 0700 $(DESTDIR)$(XEN_PAGING_DIR)
+ $(INSTALL_DIR) $(DESTDIR)$(XEN_PAGING_DIR)
$(INSTALL_DIR) $(DESTDIR)$(LIBEXEC_BIN)
$(INSTALL_PROG) $(IBINS) $(DESTDIR)$(LIBEXEC_BIN)
--
2.1.4
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] tools/xenpaging: install directory with default permission
2015-10-21 12:10 [PATCH] tools/xenpaging: install directory with default permission Wei Liu
@ 2015-10-21 13:46 ` Ian Campbell
2015-10-21 14:09 ` Wei Liu
0 siblings, 1 reply; 3+ messages in thread
From: Ian Campbell @ 2015-10-21 13:46 UTC (permalink / raw)
To: Wei Liu, Xen-devel; +Cc: Ian Jackson, Stefano Stabellini
On Wed, 2015-10-21 at 13:10 +0100, Wei Liu wrote:
> There is no need to explicitly ask for 700.
Is the rationale for 0700 explicitly not that the files in here will
contain possibly sensitive date from guest memory?
i.e. the use of something other than the default is deliberate.
If you think that is wrong then I think the changelog should explain why.
> Signed-off-by: Wei Liu <wei.liu2@citrix.com>
> ---
> tools/xenpaging/Makefile | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/tools/xenpaging/Makefile b/tools/xenpaging/Makefile
> index 2407a30..4badaae 100644
> --- a/tools/xenpaging/Makefile
> +++ b/tools/xenpaging/Makefile
> @@ -24,7 +24,7 @@ xenpaging: $(OBJS)
> $(CC) $(LDFLAGS) -o $@ $^ $(LDLIBS) $(APPEND_LDFLAGS)
>
> install: all
> - $(INSTALL_DIR) -m 0700 $(DESTDIR)$(XEN_PAGING_DIR)
> + $(INSTALL_DIR) $(DESTDIR)$(XEN_PAGING_DIR)
> $(INSTALL_DIR) $(DESTDIR)$(LIBEXEC_BIN)
> $(INSTALL_PROG) $(IBINS) $(DESTDIR)$(LIBEXEC_BIN)
>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] tools/xenpaging: install directory with default permission
2015-10-21 13:46 ` Ian Campbell
@ 2015-10-21 14:09 ` Wei Liu
0 siblings, 0 replies; 3+ messages in thread
From: Wei Liu @ 2015-10-21 14:09 UTC (permalink / raw)
To: Ian Campbell; +Cc: Xen-devel, Wei Liu, Ian Jackson, Stefano Stabellini
On Wed, Oct 21, 2015 at 02:46:54PM +0100, Ian Campbell wrote:
> On Wed, 2015-10-21 at 13:10 +0100, Wei Liu wrote:
> > There is no need to explicitly ask for 700.
>
> Is the rationale for 0700 explicitly not that the files in here will
> contain possibly sensitive date from guest memory?
>
> i.e. the use of something other than the default is deliberate.
>
You're right. Please ignore this patch.
Wei.
> If you think that is wrong then I think the changelog should explain why.
>
>
> > Signed-off-by: Wei Liu <wei.liu2@citrix.com>
> > ---
> > tools/xenpaging/Makefile | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/tools/xenpaging/Makefile b/tools/xenpaging/Makefile
> > index 2407a30..4badaae 100644
> > --- a/tools/xenpaging/Makefile
> > +++ b/tools/xenpaging/Makefile
> > @@ -24,7 +24,7 @@ xenpaging: $(OBJS)
> > $(CC) $(LDFLAGS) -o $@ $^ $(LDLIBS) $(APPEND_LDFLAGS)
> >
> > install: all
> > - $(INSTALL_DIR) -m 0700 $(DESTDIR)$(XEN_PAGING_DIR)
> > + $(INSTALL_DIR) $(DESTDIR)$(XEN_PAGING_DIR)
> > $(INSTALL_DIR) $(DESTDIR)$(LIBEXEC_BIN)
> > $(INSTALL_PROG) $(IBINS) $(DESTDIR)$(LIBEXEC_BIN)
> >
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2015-10-21 14:09 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-10-21 12:10 [PATCH] tools/xenpaging: install directory with default permission Wei Liu
2015-10-21 13:46 ` Ian Campbell
2015-10-21 14:09 ` Wei Liu
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.