From: Joe Perches <joe@perches.com>
To: Dan Carpenter <dan.carpenter@oracle.com>
Cc: Kees Cook <keescook@chromium.org>,
Christoph Hellwig <hch@infradead.org>,
Julia Lawall <Julia.Lawall@lip6.fr>,
Jean-Christophe Plagniol-Villard <plagnioj@jcrosoft.com>,
kernel-janitors@vger.kernel.org,
Tomi Valkeinen <tomi.valkeinen@ti.com>,
linux-geode@lists.infradead.org, linux-fbdev@vger.kernel.org,
LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] video: constify geode ops structures
Date: Tue, 10 Nov 2015 22:39:55 +0000 [thread overview]
Message-ID: <1447195195.2701.103.camel@perches.com> (raw)
In-Reply-To: <20151110223400.GX18797@mwanda>
On Wed, 2015-11-11 at 01:34 +0300, Dan Carpenter wrote:
> On Tue, Nov 10, 2015 at 02:17:12PM -0800, Joe Perches wrote:
> > On Wed, 2015-11-11 at 01:02 +0300, Dan Carpenter wrote:
> > > On Tue, Nov 10, 2015 at 12:49:29PM -0800, Joe Perches wrote:
> > > > Is there a warning/info message produced by gcc and the
> > > > plug-in when a non-const declaration is converted to
> > > > const because of this attribute?
> > >
> > > I'm not sure I understand the question. What would the warning
> > > say?
> >
> > Perhaps something like:
> >
> > declaration of struct <foo> converted to const by
> > __attribute__((do_const))
>
> No one will ever think to turn on that output. By the time they think
> of turning it on, it means they have already figured out the issue.
Dubious assertion.
WARNING: multiple messages have this Message-ID (diff)
From: Joe Perches <joe@perches.com>
To: Dan Carpenter <dan.carpenter@oracle.com>
Cc: Kees Cook <keescook@chromium.org>,
Christoph Hellwig <hch@infradead.org>,
Julia Lawall <Julia.Lawall@lip6.fr>,
Jean-Christophe Plagniol-Villard <plagnioj@jcrosoft.com>,
kernel-janitors@vger.kernel.org,
Tomi Valkeinen <tomi.valkeinen@ti.com>,
linux-geode@lists.infradead.org, linux-fbdev@vger.kernel.org,
LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] video: constify geode ops structures
Date: Tue, 10 Nov 2015 14:39:55 -0800 [thread overview]
Message-ID: <1447195195.2701.103.camel@perches.com> (raw)
In-Reply-To: <20151110223400.GX18797@mwanda>
On Wed, 2015-11-11 at 01:34 +0300, Dan Carpenter wrote:
> On Tue, Nov 10, 2015 at 02:17:12PM -0800, Joe Perches wrote:
> > On Wed, 2015-11-11 at 01:02 +0300, Dan Carpenter wrote:
> > > On Tue, Nov 10, 2015 at 12:49:29PM -0800, Joe Perches wrote:
> > > > Is there a warning/info message produced by gcc and the
> > > > plug-in when a non-const declaration is converted to
> > > > const because of this attribute?
> > >
> > > I'm not sure I understand the question. What would the warning
> > > say?
> >
> > Perhaps something like:
> >
> > declaration of struct <foo> converted to const by
> > __attribute__((do_const))
>
> No one will ever think to turn on that output. By the time they think
> of turning it on, it means they have already figured out the issue.
Dubious assertion.
next prev parent reply other threads:[~2015-11-10 22:39 UTC|newest]
Thread overview: 60+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-11-08 21:34 [PATCH] video: constify geode ops structures Julia Lawall
2015-11-08 21:34 ` Julia Lawall
2015-11-08 22:16 ` Dan Carpenter
2015-11-08 22:16 ` Dan Carpenter
2015-11-08 22:24 ` Julia Lawall
2015-11-08 22:24 ` Julia Lawall
2015-11-09 5:42 ` [kernel-hardening] " Dan Carpenter
2015-11-09 5:42 ` Dan Carpenter
2015-11-09 5:42 ` Dan Carpenter
2015-11-09 6:09 ` [kernel-hardening] " Joe Perches
2015-11-09 6:09 ` Joe Perches
2015-11-09 6:09 ` Joe Perches
2015-11-09 6:39 ` [kernel-hardening] " Julia Lawall
2015-11-09 6:39 ` Julia Lawall
2015-11-09 6:39 ` Julia Lawall
2015-11-09 13:30 ` [kernel-hardening] " Dan Carpenter
2015-11-09 13:30 ` Dan Carpenter
2015-11-09 18:12 ` Julia Lawall
2015-11-09 18:12 ` Julia Lawall
2015-11-09 18:19 ` Joe Perches
2015-11-09 18:19 ` Joe Perches
2015-11-09 13:49 ` Dan Carpenter
2015-11-09 13:49 ` Dan Carpenter
2015-11-09 14:50 ` Julia Lawall
2015-11-09 14:50 ` Julia Lawall
2015-11-09 16:39 ` Dan Carpenter
2015-11-09 16:39 ` Dan Carpenter
2015-11-09 17:05 ` Emese Revfy
2015-11-09 17:05 ` Emese Revfy
2015-11-09 17:48 ` Julia Lawall
2015-11-09 17:48 ` Julia Lawall
2015-11-09 21:24 ` Kees Cook
2015-11-09 21:24 ` Kees Cook
2015-11-09 21:55 ` Julia Lawall
2015-11-09 21:55 ` Julia Lawall
2015-11-09 23:34 ` Kees Cook
2015-11-09 23:34 ` Kees Cook
2015-11-10 1:24 ` PaX Team
2015-11-10 1:24 ` PaX Team
2015-11-10 15:44 ` Julia Lawall
2015-11-10 15:44 ` Julia Lawall
2015-11-10 15:44 ` Julia Lawall
2015-11-09 21:20 ` Kees Cook
2015-11-09 21:20 ` Kees Cook
2015-11-10 6:38 ` Christoph Hellwig
2015-11-10 6:38 ` Christoph Hellwig
2015-11-10 20:34 ` Kees Cook
2015-11-10 20:34 ` Kees Cook
2015-11-10 20:49 ` Joe Perches
2015-11-10 20:49 ` Joe Perches
2015-11-10 22:02 ` Dan Carpenter
2015-11-10 22:02 ` Dan Carpenter
2015-11-10 22:17 ` Joe Perches
2015-11-10 22:17 ` Joe Perches
2015-11-10 22:34 ` Dan Carpenter
2015-11-10 22:34 ` Dan Carpenter
2015-11-10 22:39 ` Joe Perches [this message]
2015-11-10 22:39 ` Joe Perches
2015-11-24 11:28 ` Tomi Valkeinen
2015-11-24 11:28 ` Tomi Valkeinen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1447195195.2701.103.camel@perches.com \
--to=joe@perches.com \
--cc=Julia.Lawall@lip6.fr \
--cc=dan.carpenter@oracle.com \
--cc=hch@infradead.org \
--cc=keescook@chromium.org \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-fbdev@vger.kernel.org \
--cc=linux-geode@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=plagnioj@jcrosoft.com \
--cc=tomi.valkeinen@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.