From: Dan Carpenter <dan.carpenter@oracle.com>
To: Julia Lawall <julia.lawall@lip6.fr>
Cc: Joe Perches <joe@perches.com>,
kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org,
Kees Cook <keescook@chromium.org>,
kernel-hardening@lists.openwall.com
Subject: Re: [kernel-hardening] Re: [PATCH] video: constify geode ops structures
Date: Mon, 9 Nov 2015 19:39:10 +0300 [thread overview]
Message-ID: <20151109163910.GU18797@mwanda> (raw)
In-Reply-To: <alpine.DEB.2.10.1511091449560.3103@hadrien>
On Mon, Nov 09, 2015 at 02:50:47PM +0000, Julia Lawall wrote:
>
>
> On Mon, 9 Nov 2015, Dan Carpenter wrote:
>
> > Actually, it looks like Emese Revfy is going to merge the GCC plugin
> > constify stuff sooner rather than later so maybe adding all these consts
> > isn't going to be needed.
>
> Is there any advantage of const over the plugin? The consts are easy to
> add.
Less syntax. It's a whitelist instead of blacklist so we don't miss
anything.
>
> Does the plugin help for structures that have non-function fields?
Yeah. You can mark a struct as __do_const in the .h file and it will
make them all const automatically.
regards,
dan carpenter
WARNING: multiple messages have this Message-ID (diff)
From: Dan Carpenter <dan.carpenter@oracle.com>
To: Julia Lawall <julia.lawall@lip6.fr>
Cc: Joe Perches <joe@perches.com>,
kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org,
Kees Cook <keescook@chromium.org>,
kernel-hardening@lists.openwall.com
Subject: Re: [kernel-hardening] Re: [PATCH] video: constify geode ops structures
Date: Mon, 09 Nov 2015 16:39:10 +0000 [thread overview]
Message-ID: <20151109163910.GU18797@mwanda> (raw)
In-Reply-To: <alpine.DEB.2.10.1511091449560.3103@hadrien>
On Mon, Nov 09, 2015 at 02:50:47PM +0000, Julia Lawall wrote:
>
>
> On Mon, 9 Nov 2015, Dan Carpenter wrote:
>
> > Actually, it looks like Emese Revfy is going to merge the GCC plugin
> > constify stuff sooner rather than later so maybe adding all these consts
> > isn't going to be needed.
>
> Is there any advantage of const over the plugin? The consts are easy to
> add.
Less syntax. It's a whitelist instead of blacklist so we don't miss
anything.
>
> Does the plugin help for structures that have non-function fields?
Yeah. You can mark a struct as __do_const in the .h file and it will
make them all const automatically.
regards,
dan carpenter
next prev parent reply other threads:[~2015-11-09 16:39 UTC|newest]
Thread overview: 60+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-11-08 21:34 [PATCH] video: constify geode ops structures Julia Lawall
2015-11-08 21:34 ` Julia Lawall
2015-11-08 22:16 ` Dan Carpenter
2015-11-08 22:16 ` Dan Carpenter
2015-11-08 22:24 ` Julia Lawall
2015-11-08 22:24 ` Julia Lawall
2015-11-09 5:42 ` [kernel-hardening] " Dan Carpenter
2015-11-09 5:42 ` Dan Carpenter
2015-11-09 5:42 ` Dan Carpenter
2015-11-09 6:09 ` [kernel-hardening] " Joe Perches
2015-11-09 6:09 ` Joe Perches
2015-11-09 6:09 ` Joe Perches
2015-11-09 6:39 ` [kernel-hardening] " Julia Lawall
2015-11-09 6:39 ` Julia Lawall
2015-11-09 6:39 ` Julia Lawall
2015-11-09 13:30 ` [kernel-hardening] " Dan Carpenter
2015-11-09 13:30 ` Dan Carpenter
2015-11-09 18:12 ` Julia Lawall
2015-11-09 18:12 ` Julia Lawall
2015-11-09 18:19 ` Joe Perches
2015-11-09 18:19 ` Joe Perches
2015-11-09 13:49 ` Dan Carpenter
2015-11-09 13:49 ` Dan Carpenter
2015-11-09 14:50 ` Julia Lawall
2015-11-09 14:50 ` Julia Lawall
2015-11-09 16:39 ` Dan Carpenter [this message]
2015-11-09 16:39 ` Dan Carpenter
2015-11-09 17:05 ` Emese Revfy
2015-11-09 17:05 ` Emese Revfy
2015-11-09 17:48 ` Julia Lawall
2015-11-09 17:48 ` Julia Lawall
2015-11-09 21:24 ` Kees Cook
2015-11-09 21:24 ` Kees Cook
2015-11-09 21:55 ` Julia Lawall
2015-11-09 21:55 ` Julia Lawall
2015-11-09 23:34 ` Kees Cook
2015-11-09 23:34 ` Kees Cook
2015-11-10 1:24 ` PaX Team
2015-11-10 1:24 ` PaX Team
2015-11-10 15:44 ` Julia Lawall
2015-11-10 15:44 ` Julia Lawall
2015-11-10 15:44 ` Julia Lawall
2015-11-09 21:20 ` Kees Cook
2015-11-09 21:20 ` Kees Cook
2015-11-10 6:38 ` Christoph Hellwig
2015-11-10 6:38 ` Christoph Hellwig
2015-11-10 20:34 ` Kees Cook
2015-11-10 20:34 ` Kees Cook
2015-11-10 20:49 ` Joe Perches
2015-11-10 20:49 ` Joe Perches
2015-11-10 22:02 ` Dan Carpenter
2015-11-10 22:02 ` Dan Carpenter
2015-11-10 22:17 ` Joe Perches
2015-11-10 22:17 ` Joe Perches
2015-11-10 22:34 ` Dan Carpenter
2015-11-10 22:34 ` Dan Carpenter
2015-11-10 22:39 ` Joe Perches
2015-11-10 22:39 ` Joe Perches
2015-11-24 11:28 ` Tomi Valkeinen
2015-11-24 11:28 ` Tomi Valkeinen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20151109163910.GU18797@mwanda \
--to=dan.carpenter@oracle.com \
--cc=joe@perches.com \
--cc=julia.lawall@lip6.fr \
--cc=keescook@chromium.org \
--cc=kernel-hardening@lists.openwall.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.