All of lore.kernel.org
 help / color / mirror / Atom feed
From: Alexey Brodkin <Alexey.Brodkin@synopsys.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH v2] usb: add support for generic EHCI devices
Date: Fri, 20 Nov 2015 21:28:34 +0000	[thread overview]
Message-ID: <1448054913.2964.19.camel@synopsys.com> (raw)
In-Reply-To: <201511202148.05092.marex@denx.de>

Hi Marek,

On Fri, 2015-11-20 at 21:48 +0100, Marek Vasut wrote:
> On Wednesday, November 18, 2015 at 04:26:21 PM, Alexey Brodkin wrote:
> > This driver is meant to be used with any EHCI-compatible host
> > controller in case if there's no need for platform-specific
> > glue such as setup of controller or PHY's power mode via
> > GPIOs etc.
> > 
> > Signed-off-by: Alexey Brodkin <abrodkin@synopsys.com>
> > Reviewed-by: Simon Glass <sjg@chromium.org>
> > Reviewed-by: Marek Vasut <marex@denx.de>
> > Cc: Stephen Warren <swarren@nvidia.com>
> > ---
> > 
> > Changes compared to v1:
> >  * Updated commit message with removal of Synopsys board mention
> >  * Cleaned-up ehci_usb_remove()
> 
> [...]
> 
> > +static int ehci_usb_probe(struct udevice *dev)
> > +{
> > +	struct ehci_hccr *hccr = (struct ehci_hccr *)dev_get_addr(dev);
> > +	struct ehci_hcor *hcor;
> > +
> > +	hcor = (struct ehci_hcor *)((uint32_t)hccr +
> 
> This should be uintptr_t for the sake of 64bit systems, no ?

Hm, that's a good point!
Indeed I was only thinking about 32-bit systems that I work with.
So please do that change.

What's interesting most of other USB drivers do use "uint32_t" so
there's a room for improvement it seems :)

-Alexey

  reply	other threads:[~2015-11-20 21:28 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-11-18 15:26 [U-Boot] [PATCH v2] usb: add support for generic EHCI devices Alexey Brodkin
2015-11-20 20:28 ` Alexey Brodkin
2015-11-20 20:38 ` Simon Glass
2015-11-20 20:47   ` Marek Vasut
2015-11-20 20:48 ` Marek Vasut
2015-11-20 21:28   ` Alexey Brodkin [this message]
2015-11-20 22:32     ` Marek Vasut
2015-11-30 11:10   ` Alexey Brodkin
2015-11-30 12:34     ` Marek Vasut

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1448054913.2964.19.camel@synopsys.com \
    --to=alexey.brodkin@synopsys.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.