All of lore.kernel.org
 help / color / mirror / Atom feed
From: Imre Deak <imre.deak@intel.com>
To: Chris Wilson <chris@chris-wilson.co.uk>,
	Joonas Lahtinen <joonas.lahtinen@linux.intel.com>
Cc: intel-gfx@lists.freedesktop.org
Subject: Re: [PATCH 08/10] drm/i915: check that we hold an RPM wakelock ref before we put it
Date: Wed, 16 Dec 2015 14:49:57 +0200	[thread overview]
Message-ID: <1450270197.15887.7.camel@intel.com> (raw)
In-Reply-To: <20151216110756.GI6851@nuc-i3427.alporthouse.com>

On ke, 2015-12-16 at 11:07 +0000, Chris Wilson wrote:
> On Wed, Dec 16, 2015 at 01:00:38PM +0200, Joonas Lahtinen wrote:
> > On ti, 2015-12-15 at 20:10 +0200, Imre Deak wrote:
> > > v2-v3:
> > > - unchanged
> > > v4:
> > > - keep the corresponding check in the get helper (Chris)
> > 
> > This is put helper you patched, so I think the above message is
> > incorrect.
> 
> It is referring to a chunk no longer in the patch. :)

Yes, in v1 I removed an assert from intel_runtime_pm_get(), which was
reinstated in v4:
http://lists.freedesktop.org/archives/intel-gfx/2015-November/080048.html

> -Chris
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/intel-gfx

  reply	other threads:[~2015-12-16 12:49 UTC|newest]

Thread overview: 44+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-12-15 18:10 [PATCH v4 00/10] drm/i915: improve the RPM device suspended assert Imre Deak
2015-12-15 18:10 ` [PATCH 01/10] drm/i915: clarify comment about mandatory RPM put/get during driver load/unload Imre Deak
2015-12-16 10:44   ` Joonas Lahtinen
2015-12-15 18:10 ` [PATCH 02/10] drm/i915: disable power well support on platforms without runtime PM support Imre Deak
2015-12-15 20:57   ` Ville Syrjälä
2015-12-15 22:55     ` Imre Deak
2015-12-16 11:12     ` Daniel Vetter
2015-12-16 13:21       ` Imre Deak
2015-12-16 17:31         ` Ville Syrjälä
2015-12-16 18:13           ` Imre Deak
2015-12-15 18:10 ` [PATCH 03/10] drm/i915: refactor RPM disabling due to RC6 being disabled Imre Deak
2015-12-16 10:54   ` Joonas Lahtinen
2015-12-16 11:01     ` Joonas Lahtinen
2015-12-15 18:10 ` [PATCH 04/10] drm/i915: remove HAS_RUNTIME_PM check from RPM get/put/assert helpers Imre Deak
2015-12-16 10:56   ` Joonas Lahtinen
2015-12-16 13:49   ` [PATCH 4.1/10] drm/i915: get a permanent RPM reference on platforms w/o RPM support Imre Deak
2015-12-16 13:53     ` [PATCH v2 " Imre Deak
2015-12-16 17:26       ` Ville Syrjälä
2015-12-16 18:22         ` Imre Deak
2015-12-17 11:44       ` [PATCH v3.1/10] " Imre Deak
2015-12-17 11:48   ` [PATCH v5 04/10] drm/i915: remove HAS_RUNTIME_PM check from RPM get/put/assert helpers Imre Deak
2015-12-17 12:46     ` Joonas Lahtinen
2015-12-15 18:10 ` [PATCH 05/10] drm/i915: add assert_rpm_wakelock_held helper Imre Deak
2015-12-16 12:11   ` Chris Wilson
2015-12-16 12:54     ` Imre Deak
2015-12-16 13:02       ` Chris Wilson
2015-12-16 13:39         ` Joonas Lahtinen
2015-12-16 13:43           ` Imre Deak
2015-12-15 18:10 ` [PATCH 06/10] drm/i915: use assert_rpm_wakelock_held instead of opencoding it Imre Deak
2015-12-15 18:10 ` [PATCH 07/10] drm/i915: add support for checking if we hold an RPM reference Imre Deak
2015-12-15 21:07   ` Chris Wilson
2015-12-15 22:52     ` Imre Deak
2015-12-16  0:14       ` Chris Wilson
2015-12-16  0:52   ` [PATCH v5 " Imre Deak
2015-12-15 18:10 ` [PATCH 08/10] drm/i915: check that we hold an RPM wakelock ref before we put it Imre Deak
2015-12-16 11:00   ` Joonas Lahtinen
2015-12-16 11:07     ` Chris Wilson
2015-12-16 12:49       ` Imre Deak [this message]
2015-12-15 18:10 ` [PATCH 09/10] drm/i915: add support for checking RPM atomic sections Imre Deak
2015-12-16 11:06   ` Joonas Lahtinen
2015-12-16 11:18   ` Daniel Vetter
2015-12-16 22:53     ` Imre Deak
2015-12-15 18:10 ` [PATCH 10/10] drm/i915: check that we are in an RPM atomic section in GGTT PTE updaters Imre Deak
2015-12-17 14:44 ` [PATCH v4 00/10] drm/i915: improve the RPM device suspended assert Imre Deak

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1450270197.15887.7.camel@intel.com \
    --to=imre.deak@intel.com \
    --cc=chris@chris-wilson.co.uk \
    --cc=intel-gfx@lists.freedesktop.org \
    --cc=joonas.lahtinen@linux.intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.