From: Sergei Ianovich <ynvich@gmail.com>
To: Rob Herring <robh@kernel.org>
Cc: linux-kernel@vger.kernel.org,
Alexandre Belloni <alexandre.belloni@free-electrons.com>,
Pawel Moll <pawel.moll@arm.com>,
Mark Rutland <mark.rutland@arm.com>,
Ian Campbell <ijc+devicetree@hellion.org.uk>,
Kumar Gala <galak@codeaurora.org>,
Alessandro Zummo <a.zummo@towertech.it>,
"open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS"
<devicetree@vger.kernel.org>,
"open list:REAL TIME CLOCK (RTC) SUBSYSTEM"
<rtc-linux@googlegroups.com>
Subject: [rtc-linux] Re: [PATCH v5] rtc: support DS1302 RTC on ICP DAS LP-8x4x
Date: Sun, 20 Dec 2015 15:14:16 +0300 [thread overview]
Message-ID: <1450613656.15911.62.camel@gmail.com> (raw)
In-Reply-To: <20151220033815.GD9883@rob-hp-laptop>
T24gU2F0LCAyMDE1LTEyLTE5IGF0IDIxOjM4IC0wNjAwLCBSb2IgSGVycmluZyB3cm90ZToNCj4g
T24gVHVlLCBEZWMgMTUsIDIwMTUgYXQgMDg6NDU6MjNQTSArMDMwMCwgU2VyZ2VpIElhbm92aWNo
IHdyb3RlOg0KPiANCj4gTm90aGluZyBpbiB0aGlzIGlzIHNwZWNpZmljIHRvIElDUCwgc28gdGhl
IHN1YmplY3Qgc2hvdWxkIGJlIHVwZGF0ZWQuDQo+IA0KPiA+IFNpZ25lZC1vZmYtYnk6IFNlcmdl
aSBJYW5vdmljaCA8eW52aWNoQGdtYWlsLmNvbT4NCj4gPiBDQzogQWxleGFuZHJlIEJlbGxvbmkg
PGFsZXhhbmRyZS5iZWxsb25pQGZyZWUtZWxlY3Ryb25zLmNvbT4NCj4gPiAtLS0NCj4gPiDCoMKg
wqB2NC4udjUNCj4gPiDCoMKgwqAqIGRyb3AgVEhJU19NT0RVTEUgZnJvbSBzdHJ1Y3QgcGxhdGZv
cm0gZHJpdmVyDQo+ID4gwqDCoMKgKiB1c2UgImRhbGxhcyIgZm9yIHZlbmRvciBuYW1lIHBlciB2
ZW5kb3ItcHJlZml4ZXMudHh0DQo+ID4gDQo+ID4gwqDCoMKgdjMuLnY0DQo+ID4gwqDCoMKgKiBt
b3ZlIERUUyBiaW5kaW5ncyB0byBhIGRpZmZlcmVudCBwYXRjaA0KPiA+IA0KPiA+IMKgwqDCoHYy
Li52Mw0KPiA+IMKgwqDCoCogdXNlIHVzbGVlcF9yYW5nZSBpbnN0ZWFkIG9mIGN1c3RvbSBuc2xl
ZXANCj4gPiDCoMKgwqAqIG51bWJlciBjaGFuZ2UgKDA3LzE2IC0+IDA5LzIxKQ0KPiA+IA0KPiA+
IMKgwqDCoHYwLi52Mg0KPiA+IMKgwqDCoCogdXNlIGRldmljZSB0cmVlDQo+ID4gwqDCoMKgKiB1
c2UgZGV2bSBoZWxwZXJzIHdoZXJlIHBvc3NpYmxlDQo+ID4gDQo+ID4gwqAuLi4vZGV2aWNldHJl
ZS9iaW5kaW5ncy9ydGMvcnRjLWRzMTMwMi50eHTCoMKgwqDCoMKgwqDCoMKgwqB8wqDCoDE0ICsr
Kw0KPiA+IMKgZHJpdmVycy9ydGMvS2NvbmZpZ8KgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDC
oMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqB8wqDCoMKgMiArLQ0KPiA+IMKgZHJp
dmVycy9ydGMvcnRjLWRzMTMwMi5jwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKg
wqDCoMKgwqDCoMKgwqDCoMKgfCAxMDANCj4gPiArKysrKysrKysrKysrKysrKysrKy0NCj4gPiDC
oDMgZmlsZXMgY2hhbmdlZCwgMTEzIGluc2VydGlvbnMoKyksIDMgZGVsZXRpb25zKC0pDQo+ID4g
wqBjcmVhdGUgbW9kZSAxMDA2NDQgRG9jdW1lbnRhdGlvbi9kZXZpY2V0cmVlL2JpbmRpbmdzL3J0
Yy9ydGMtDQo+ID4gZHMxMzAyLnR4dA0KPiA+IA0KPiA+IGRpZmYgLS1naXQgYS9Eb2N1bWVudGF0
aW9uL2RldmljZXRyZWUvYmluZGluZ3MvcnRjL3J0Yy1kczEzMDIudHh0DQo+ID4gYi9Eb2N1bWVu
dGF0aW9uL2RldmljZXRyZWUvYmluZGluZ3MvcnRjL3J0Yy1kczEzMDIudHh0DQo+ID4gbmV3IGZp
bGUgbW9kZSAxMDA2NDQNCj4gPiBpbmRleCAwMDAwMDAwLi44MTA2MTNiDQo+ID4gLS0tIC9kZXYv
bnVsbA0KPiA+ICsrKyBiL0RvY3VtZW50YXRpb24vZGV2aWNldHJlZS9iaW5kaW5ncy9ydGMvcnRj
LWRzMTMwMi50eHQNCj4gPiBAQCAtMCwwICsxLDE0IEBADQo+ID4gKyogRGFsbGFzIFNlbWljb25k
dWN0b3IgRFMtMTMwMiBSVEMNCj4gPiArDQo+ID4gK1NpbXBsZSBkZXZpY2Ugd2hpY2ggY291bGQg
YmUgdXNlZCB0byBzdG9yZSBkYXRlL3RpbWUgYmV0d2Vlbg0KPiA+IHJlYm9vdHMuDQo+ID4gKw0K
PiA+ICtSZXF1aXJlZCBwcm9wZXJ0aWVzOg0KPiA+ICstIGNvbXBhdGlibGUgOiBTaG91bGQgYmUg
ImRhbGxhcyxydGMtZHMxMzAyIg0KPiA+ICstIHJlZyA6IFNob3VsZCBiZSBhZGRyZXNzIGFuZCBz
aXplIG9mIElPIG1lbW9yeSByZWdpb24NCj4gDQo+IFRoaXMgZGV2aWNlIGlzIGEgU1BJIChvciBT
UEkgbGlrZT8pIGludGVyZmFjZS4gU28geW91IGhhdmUgc29tZSBzb3J0DQo+IG9mIA0KPiBvZiBG
UEdBIGxvZ2ljIGluIGJldHdlZW4gdGhlIGNwdSBhbmQgZHMxMzAyLiBUaGUgRFQgc2hvdWxkIGhh
dmUgYSBub2RlDQo+IGZvciB0aGUgY29udHJvbGxlciBhbmQgdGhlbiB0aGUgZHMxMzAyIGFzIGEg
Y2hpbGQgb2YgaXQuIEEgZnVsbCBibG93biANCj4gU1BJIGRyaXZlciBtYXkgYmUgb3ZlcmtpbGwg
aGVyZSwgYnV0IHRoYXQncyBhIHNlcGFyYXRlIGRpc2N1c3Npb24gZnJvbQ0KPiB0aGUgRFQgYmlu
ZGluZy4NCg0KQmVsb3cgaXMgdGhlIHF1b3RlIGZyb20gdGhlIGFjdHVhbCBEVCBvZiBMUC04eDR4
Og0KPiDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoGZwZ2FANSB7DQo+IMKgwqDCoMKg
wqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoGNvbXBhdGlibGUgPSAic2lt
cGxlLWJ1cyI7DQo+IMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKg
wqDCoCNhZGRyZXNzLWNlbGxzID0gPDE+Ow0KPiDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKg
wqDCoMKgwqDCoMKgwqDCoMKgwqAjc2l6ZS1jZWxscyA9IDwxPjsNCj4gwqDCoMKgwqDCoMKgwqDC
oMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgcmFuZ2VzID0gPDAgNSAweDMwMDAwMDAg
MHgxMDAwMD47DQo+IMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKg
wqDCoGludGVycnVwdC1wYXJlbnQgPSA8JmZwZ2FpcnE+Ow0KPiANCj4gwqDCoMKgwqDCoMKgwqDC
oMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgcnRjQDkwMWMgew0KPiDCoMKgwqDCoMKg
wqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgY29t
cGF0aWJsZSA9ICJkYWxsYXMscnRjLWRzMTMwMiI7DQo+IMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDC
oMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqByZWcgPSA8MHg5MDFjIDB4
MT47DQo+IMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKg
wqDCoMKgwqDCoMKgwqBzdGF0dXMgPSAib2theSI7DQo+IMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDC
oMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoH07DQoNCllvdSBhcmUgcmlnaHQgYWJvdXQgdGhlIHRv
cG9sb2d5LiBkczEzMDIgaXMgYSBoYWxmLWR1cGxleCBTUEkgZGV2aWNlLg0KRG9lcyB0aGlzIG1l
YW4gSSBzaG91bGQgcmV3cml0ZSB0aGUgZHJpdmVyIHRvIGhhbmRsZSB0aGUgY2hpcCBhcyBhIHNs
YXZlDQpTUEkgZGV2aWNlLCBhbmQgdGhlbiBwcm92aWRlIGEgbWFzdGVyIFNQSSBmdW5jdGlvbmFs
aXR5IGF0IHRoZSBGUEdBPw0KDQotLSAKLS0gDQpZb3UgcmVjZWl2ZWQgdGhpcyBtZXNzYWdlIGJl
Y2F1c2UgeW91IGFyZSBzdWJzY3JpYmVkIHRvICJydGMtbGludXgiLg0KTWVtYmVyc2hpcCBvcHRp
b25zIGF0IGh0dHA6Ly9ncm91cHMuZ29vZ2xlLmNvbS9ncm91cC9ydGMtbGludXggLg0KUGxlYXNl
IHJlYWQgaHR0cDovL2dyb3Vwcy5nb29nbGUuY29tL2dyb3VwL3J0Yy1saW51eC93ZWIvY2hlY2ts
aXN0DQpiZWZvcmUgc3VibWl0dGluZyBhIGRyaXZlci4KLS0tIApZb3UgcmVjZWl2ZWQgdGhpcyBt
ZXNzYWdlIGJlY2F1c2UgeW91IGFyZSBzdWJzY3JpYmVkIHRvIHRoZSBHb29nbGUgR3JvdXBzICJy
dGMtbGludXgiIGdyb3VwLgpUbyB1bnN1YnNjcmliZSBmcm9tIHRoaXMgZ3JvdXAgYW5kIHN0b3Ag
cmVjZWl2aW5nIGVtYWlscyBmcm9tIGl0LCBzZW5kIGFuIGVtYWlsIHRvIHJ0Yy1saW51eCt1bnN1
YnNjcmliZUBnb29nbGVncm91cHMuY29tLgpGb3IgbW9yZSBvcHRpb25zLCB2aXNpdCBodHRwczov
L2dyb3Vwcy5nb29nbGUuY29tL2Qvb3B0b3V0Lgo=
WARNING: multiple messages have this Message-ID (diff)
From: Sergei Ianovich <ynvich@gmail.com>
To: Rob Herring <robh@kernel.org>
Cc: linux-kernel@vger.kernel.org,
Alexandre Belloni <alexandre.belloni@free-electrons.com>,
Pawel Moll <pawel.moll@arm.com>,
Mark Rutland <mark.rutland@arm.com>,
Ian Campbell <ijc+devicetree@hellion.org.uk>,
Kumar Gala <galak@codeaurora.org>,
Alessandro Zummo <a.zummo@towertech.it>,
"open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS"
<devicetree@vger.kernel.org>,
"open list:REAL TIME CLOCK (RTC) SUBSYSTEM"
<rtc-linux@googlegroups.com>
Subject: Re: [PATCH v5] rtc: support DS1302 RTC on ICP DAS LP-8x4x
Date: Sun, 20 Dec 2015 15:14:16 +0300 [thread overview]
Message-ID: <1450613656.15911.62.camel@gmail.com> (raw)
In-Reply-To: <20151220033815.GD9883@rob-hp-laptop>
On Sat, 2015-12-19 at 21:38 -0600, Rob Herring wrote:
> On Tue, Dec 15, 2015 at 08:45:23PM +0300, Sergei Ianovich wrote:
>
> Nothing in this is specific to ICP, so the subject should be updated.
>
> > Signed-off-by: Sergei Ianovich <ynvich@gmail.com>
> > CC: Alexandre Belloni <alexandre.belloni@free-electrons.com>
> > ---
> > v4..v5
> > * drop THIS_MODULE from struct platform driver
> > * use "dallas" for vendor name per vendor-prefixes.txt
> >
> > v3..v4
> > * move DTS bindings to a different patch
> >
> > v2..v3
> > * use usleep_range instead of custom nsleep
> > * number change (07/16 -> 09/21)
> >
> > v0..v2
> > * use device tree
> > * use devm helpers where possible
> >
> > .../devicetree/bindings/rtc/rtc-ds1302.txt | 14 +++
> > drivers/rtc/Kconfig | 2 +-
> > drivers/rtc/rtc-ds1302.c | 100
> > ++++++++++++++++++++-
> > 3 files changed, 113 insertions(+), 3 deletions(-)
> > create mode 100644 Documentation/devicetree/bindings/rtc/rtc-
> > ds1302.txt
> >
> > diff --git a/Documentation/devicetree/bindings/rtc/rtc-ds1302.txt
> > b/Documentation/devicetree/bindings/rtc/rtc-ds1302.txt
> > new file mode 100644
> > index 0000000..810613b
> > --- /dev/null
> > +++ b/Documentation/devicetree/bindings/rtc/rtc-ds1302.txt
> > @@ -0,0 +1,14 @@
> > +* Dallas Semiconductor DS-1302 RTC
> > +
> > +Simple device which could be used to store date/time between
> > reboots.
> > +
> > +Required properties:
> > +- compatible : Should be "dallas,rtc-ds1302"
> > +- reg : Should be address and size of IO memory region
>
> This device is a SPI (or SPI like?) interface. So you have some sort
> of
> of FPGA logic in between the cpu and ds1302. The DT should have a node
> for the controller and then the ds1302 as a child of it. A full blown
> SPI driver may be overkill here, but that's a separate discussion from
> the DT binding.
Below is the quote from the actual DT of LP-8x4x:
> fpga@5 {
> compatible = "simple-bus";
> #address-cells = <1>;
> #size-cells = <1>;
> ranges = <0 5 0x3000000 0x10000>;
> interrupt-parent = <&fpgairq>;
>
> rtc@901c {
> compatible = "dallas,rtc-ds1302";
> reg = <0x901c 0x1>;
> status = "okay";
> };
You are right about the topology. ds1302 is a half-duplex SPI device.
Does this mean I should rewrite the driver to handle the chip as a slave
SPI device, and then provide a master SPI functionality at the FPGA?
next prev parent reply other threads:[~2015-12-20 12:14 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <397668667-27328-3-git-send-email-ynvich@gmail.com>
2015-12-15 17:45 ` [rtc-linux] [PATCH v5] rtc: support DS1302 RTC on ICP DAS LP-8x4x Sergei Ianovich
2015-12-15 17:45 ` Sergei Ianovich
2015-12-15 17:45 ` Sergei Ianovich
2015-12-20 3:38 ` [rtc-linux] " Rob Herring
2015-12-20 3:38 ` Rob Herring
2015-12-20 12:14 ` Sergei Ianovich [this message]
2015-12-20 12:14 ` Sergei Ianovich
2015-12-22 18:16 ` [rtc-linux] " Rob Herring
2015-12-22 18:16 ` Rob Herring
2015-12-24 11:04 ` [rtc-linux] " Alexandre Belloni
2015-12-24 11:04 ` Alexandre Belloni
2015-12-24 11:04 ` Alexandre Belloni
2015-12-24 11:07 ` [rtc-linux] " Sergei Ianovich
2015-12-24 11:07 ` Sergei Ianovich
2016-02-22 1:41 ` [rtc-linux] [PATCH v6] rtc: rewrite DS1302 using SPI Sergei Ianovich
2016-02-22 1:41 ` Sergei Ianovich
2016-02-22 1:41 ` Sergei Ianovich
2016-02-22 18:45 ` [rtc-linux] " Rob Herring
2016-02-22 18:45 ` Rob Herring
2016-02-22 18:45 ` Rob Herring
2016-02-23 10:54 ` [PATCH v7] " Sergei Ianovich
2016-02-23 10:54 ` Sergei Ianovich
2016-02-23 23:29 ` Rob Herring
2016-02-23 23:29 ` Rob Herring
2016-03-15 0:18 ` Alexandre Belloni
2016-03-15 0:18 ` Alexandre Belloni
2016-03-18 10:38 ` Sergei Ianovich
2016-03-18 10:38 ` Sergei Ianovich
2016-03-28 20:57 ` Alexandre Belloni
2016-03-28 20:57 ` Alexandre Belloni
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1450613656.15911.62.camel@gmail.com \
--to=ynvich@gmail.com \
--cc=a.zummo@towertech.it \
--cc=alexandre.belloni@free-electrons.com \
--cc=devicetree@vger.kernel.org \
--cc=galak@codeaurora.org \
--cc=ijc+devicetree@hellion.org.uk \
--cc=linux-kernel@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=pawel.moll@arm.com \
--cc=robh@kernel.org \
--cc=rtc-linux@googlegroups.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.