All of lore.kernel.org
 help / color / mirror / Atom feed
From: Sergei Ianovich <ynvich@gmail.com>
To: Alexandre Belloni <alexandre.belloni@free-electrons.com>,
	Rob Herring <robh@kernel.org>
Cc: "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	Pawel Moll <pawel.moll@arm.com>,
	Mark Rutland <mark.rutland@arm.com>,
	Ian Campbell <ijc+devicetree@hellion.org.uk>,
	Kumar Gala <galak@codeaurora.org>,
	 Alessandro Zummo <a.zummo@towertech.it>,
	"open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS"
	<devicetree@vger.kernel.org>,
	"open list:REAL TIME CLOCK (RTC) SUBSYSTEM"
	<rtc-linux@googlegroups.com>
Subject: [rtc-linux] Re: [PATCH v5] rtc: support DS1302 RTC on ICP DAS LP-8x4x
Date: Thu, 24 Dec 2015 14:07:48 +0300	[thread overview]
Message-ID: <1450955268.15911.85.camel@gmail.com> (raw)
In-Reply-To: <20151224110453.GJ8623@piout.net>

On Thu, 2015-12-24 at 12:04 +0100, Alexandre Belloni wrote:
> On 22/12/2015 at 12:16:41 -0600, Rob Herring wrote :
> > Well, the binding should reflect that, whether the driver needs to
> > be
> > re-written is somewhat a separate question. That should probably
> > have
> > been done for the DS1302 driver originally and it is not too fair
> > for
> > the 2nd person to fix it. You could just have a single driver bound
> > to
> > the controller node which is aware of the DS1302 being the slave
> > device (ignoring that part of the DT for now).
> > 
> 
> I agree with Rob here. I won't require that you fix the driver but it
> would be better to have a proper DT binding from the beginning so that
> when the driver is fixed it will still work with the previous device
> trees.

No problem. I'll fix the driver. That's how it should be done.

What should be done with SECUREEDGE support?

-- 
-- 
You received this message because you are subscribed to "rtc-linux".
Membership options at http://groups.google.com/group/rtc-linux .
Please read http://groups.google.com/group/rtc-linux/web/checklist
before submitting a driver.
--- 
You received this message because you are subscribed to the Google Groups "rtc-linux" group.
To unsubscribe from this group and stop receiving emails from it, send an email to rtc-linux+unsubscribe@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.

WARNING: multiple messages have this Message-ID (diff)
From: Sergei Ianovich <ynvich@gmail.com>
To: Alexandre Belloni <alexandre.belloni@free-electrons.com>,
	Rob Herring <robh@kernel.org>
Cc: "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	Pawel Moll <pawel.moll@arm.com>,
	Mark Rutland <mark.rutland@arm.com>,
	Ian Campbell <ijc+devicetree@hellion.org.uk>,
	Kumar Gala <galak@codeaurora.org>,
	Alessandro Zummo <a.zummo@towertech.it>,
	"open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS"
	<devicetree@vger.kernel.org>,
	"open list:REAL TIME CLOCK (RTC) SUBSYSTEM"
	<rtc-linux@googlegroups.com>
Subject: Re: [PATCH v5] rtc: support DS1302 RTC on ICP DAS LP-8x4x
Date: Thu, 24 Dec 2015 14:07:48 +0300	[thread overview]
Message-ID: <1450955268.15911.85.camel@gmail.com> (raw)
In-Reply-To: <20151224110453.GJ8623@piout.net>

On Thu, 2015-12-24 at 12:04 +0100, Alexandre Belloni wrote:
> On 22/12/2015 at 12:16:41 -0600, Rob Herring wrote :
> > Well, the binding should reflect that, whether the driver needs to
> > be
> > re-written is somewhat a separate question. That should probably
> > have
> > been done for the DS1302 driver originally and it is not too fair
> > for
> > the 2nd person to fix it. You could just have a single driver bound
> > to
> > the controller node which is aware of the DS1302 being the slave
> > device (ignoring that part of the DT for now).
> > 
> 
> I agree with Rob here. I won't require that you fix the driver but it
> would be better to have a proper DT binding from the beginning so that
> when the driver is fixed it will still work with the previous device
> trees.

No problem. I'll fix the driver. That's how it should be done.

What should be done with SECUREEDGE support?

  reply	other threads:[~2015-12-24 11:07 UTC|newest]

Thread overview: 30+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <397668667-27328-3-git-send-email-ynvich@gmail.com>
2015-12-15 17:45 ` [rtc-linux] [PATCH v5] rtc: support DS1302 RTC on ICP DAS LP-8x4x Sergei Ianovich
2015-12-15 17:45   ` Sergei Ianovich
2015-12-15 17:45   ` Sergei Ianovich
2015-12-20  3:38   ` [rtc-linux] " Rob Herring
2015-12-20  3:38     ` Rob Herring
2015-12-20 12:14     ` [rtc-linux] " Sergei Ianovich
2015-12-20 12:14       ` Sergei Ianovich
2015-12-22 18:16       ` [rtc-linux] " Rob Herring
2015-12-22 18:16         ` Rob Herring
2015-12-24 11:04         ` [rtc-linux] " Alexandre Belloni
2015-12-24 11:04           ` Alexandre Belloni
2015-12-24 11:04           ` Alexandre Belloni
2015-12-24 11:07           ` Sergei Ianovich [this message]
2015-12-24 11:07             ` Sergei Ianovich
2016-02-22  1:41 ` [rtc-linux] [PATCH v6] rtc: rewrite DS1302 using SPI Sergei Ianovich
2016-02-22  1:41   ` Sergei Ianovich
2016-02-22  1:41   ` Sergei Ianovich
2016-02-22 18:45   ` [rtc-linux] " Rob Herring
2016-02-22 18:45     ` Rob Herring
2016-02-22 18:45     ` Rob Herring
2016-02-23 10:54   ` [PATCH v7] " Sergei Ianovich
2016-02-23 10:54     ` Sergei Ianovich
2016-02-23 23:29     ` Rob Herring
2016-02-23 23:29       ` Rob Herring
2016-03-15  0:18     ` Alexandre Belloni
2016-03-15  0:18       ` Alexandre Belloni
2016-03-18 10:38       ` Sergei Ianovich
2016-03-18 10:38         ` Sergei Ianovich
2016-03-28 20:57     ` Alexandre Belloni
2016-03-28 20:57       ` Alexandre Belloni

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1450955268.15911.85.camel@gmail.com \
    --to=ynvich@gmail.com \
    --cc=a.zummo@towertech.it \
    --cc=alexandre.belloni@free-electrons.com \
    --cc=devicetree@vger.kernel.org \
    --cc=galak@codeaurora.org \
    --cc=ijc+devicetree@hellion.org.uk \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mark.rutland@arm.com \
    --cc=pawel.moll@arm.com \
    --cc=robh@kernel.org \
    --cc=rtc-linux@googlegroups.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.