From: Joe Perches <joe@perches.com>
To: Toshi Kani <toshi.kani@hpe.com>, akpm@linux-foundation.org, bp@alien8.de
Cc: linux-arch@vger.kernel.org, linux-mm@kvack.org,
linux-kernel@vger.kernel.org, Andy Whitcroft <apw@canonical.com>
Subject: Re: [PATCH v2 15/16] checkpatch: Add warning on deprecated walk_iomem_res
Date: Fri, 25 Dec 2015 16:05:07 -0800 [thread overview]
Message-ID: <1451088307.12498.3.camel@perches.com> (raw)
In-Reply-To: <1451081365-15190-15-git-send-email-toshi.kani@hpe.com>
On Fri, 2015-12-25 at 15:09 -0700, Toshi Kani wrote:
> Use of walk_iomem_res() is deprecated in new code. Change
> checkpatch.pl to check new use of walk_iomem_res() and suggest
> to use walk_iomem_res_desc() instead.
[]
> diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl
[]
> @@ -3424,6 +3424,12 @@ sub process {
> }
> }
>
> +# check for uses of walk_iomem_res()
> + if ($line =~ /\bwalk_iomem_res\(/) {
> + WARN("walk_iomem_res",
> + "Use of walk_iomem_res is deprecated, please use walk_iomem_res_desc instead\n" . $herecurr)
> + }
> +
> # check for new typedefs, only function parameters and sparse annotations
> # make sense.
> if ($line =~ /\btypedef\s/ &&
There are 6 uses of this function in the entire kernel tree.
Why not just change them, remove the function and avoid this?
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
WARNING: multiple messages have this Message-ID (diff)
From: Joe Perches <joe@perches.com>
To: Toshi Kani <toshi.kani@hpe.com>, akpm@linux-foundation.org, bp@alien8.de
Cc: linux-arch@vger.kernel.org, linux-mm@kvack.org,
linux-kernel@vger.kernel.org, Andy Whitcroft <apw@canonical.com>
Subject: Re: [PATCH v2 15/16] checkpatch: Add warning on deprecated walk_iomem_res
Date: Fri, 25 Dec 2015 16:05:07 -0800 [thread overview]
Message-ID: <1451088307.12498.3.camel@perches.com> (raw)
Message-ID: <20151226000507.zISaADyhmqKlPQ6mwHUD6oWnANB5IQSMu3FZrY9JE6Q@z> (raw)
In-Reply-To: <1451081365-15190-15-git-send-email-toshi.kani@hpe.com>
On Fri, 2015-12-25 at 15:09 -0700, Toshi Kani wrote:
> Use of walk_iomem_res() is deprecated in new code. Change
> checkpatch.pl to check new use of walk_iomem_res() and suggest
> to use walk_iomem_res_desc() instead.
[]
> diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl
[]
> @@ -3424,6 +3424,12 @@ sub process {
> }
> }
>
> +# check for uses of walk_iomem_res()
> + if ($line =~ /\bwalk_iomem_res\(/) {
> + WARN("walk_iomem_res",
> + "Use of walk_iomem_res is deprecated, please use walk_iomem_res_desc instead\n" . $herecurr)
> + }
> +
> # check for new typedefs, only function parameters and sparse annotations
> # make sense.
> if ($line =~ /\btypedef\s/ &&
There are 6 uses of this function in the entire kernel tree.
Why not just change them, remove the function and avoid this?
WARNING: multiple messages have this Message-ID (diff)
From: Joe Perches <joe@perches.com>
To: Toshi Kani <toshi.kani@hpe.com>, akpm@linux-foundation.org, bp@alien8.de
Cc: linux-arch@vger.kernel.org, linux-mm@kvack.org,
linux-kernel@vger.kernel.org, Andy Whitcroft <apw@canonical.com>
Subject: Re: [PATCH v2 15/16] checkpatch: Add warning on deprecated walk_iomem_res
Date: Fri, 25 Dec 2015 16:05:07 -0800 [thread overview]
Message-ID: <1451088307.12498.3.camel@perches.com> (raw)
In-Reply-To: <1451081365-15190-15-git-send-email-toshi.kani@hpe.com>
On Fri, 2015-12-25 at 15:09 -0700, Toshi Kani wrote:
> Use of walk_iomem_res() is deprecated in new code. Change
> checkpatch.pl to check new use of walk_iomem_res() and suggest
> to use walk_iomem_res_desc() instead.
[]
> diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl
[]
> @@ -3424,6 +3424,12 @@ sub process {
> }
> }
>
> +# check for uses of walk_iomem_res()
> + if ($line =~ /\bwalk_iomem_res\(/) {
> + WARN("walk_iomem_res",
> + "Use of walk_iomem_res is deprecated, please use walk_iomem_res_desc instead\n" . $herecurr)
> + }
> +
> # check for new typedefs, only function parameters and sparse annotations
> # make sense.
> if ($line =~ /\btypedef\s/ &&
There are 6 uses of this function in the entire kernel tree.
Why not just change them, remove the function and avoid this?
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2015-12-26 0:05 UTC|newest]
Thread overview: 90+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-12-25 22:09 [PATCH v2 01/16] resource: Add System RAM resource type Toshi Kani
2015-12-25 22:09 ` Toshi Kani
2015-12-25 22:09 ` [PATCH v2 02/16] resource: make resource flags handled properly Toshi Kani
2015-12-25 22:09 ` Toshi Kani
2015-12-25 22:09 ` [PATCH v2 03/16] resource: Add I/O resource descriptor Toshi Kani
2015-12-25 22:09 ` Toshi Kani
2015-12-25 22:09 ` [PATCH v2 04/16] x86/e820: Set System RAM type and descriptor Toshi Kani
2015-12-25 22:09 ` Toshi Kani
2015-12-25 22:09 ` [PATCH v2 05/16] ia64: " Toshi Kani
2015-12-25 22:09 ` Toshi Kani
2015-12-25 22:09 ` Toshi Kani
2015-12-25 22:09 ` [PATCH v2 06/16] arch: Set IORESOURCE_SYSTEM_RAM to System RAM Toshi Kani
2015-12-25 22:09 ` Toshi Kani
2015-12-25 22:09 ` [PATCH v2 07/16] kexec: " Toshi Kani
2015-12-25 22:09 ` Toshi Kani
2015-12-25 22:09 ` [PATCH v2 08/16] xen, mm: " Toshi Kani
2015-12-25 22:09 ` Toshi Kani
2016-01-04 11:41 ` David Vrabel
2016-01-04 11:41 ` [Xen-devel] " David Vrabel
2016-01-04 11:41 ` David Vrabel
2016-01-04 11:41 ` David Vrabel
2015-12-25 22:09 ` Toshi Kani
2015-12-25 22:09 ` [PATCH v2 09/16] drivers: Initialize resource entry to zero Toshi Kani
2015-12-25 22:09 ` Toshi Kani
2015-12-25 22:09 ` Toshi Kani
2015-12-28 21:37 ` Simon Horman
2015-12-28 21:37 ` Simon Horman
2015-12-28 21:37 ` Simon Horman
2015-12-25 22:09 ` [PATCH v2 10/16] resource: Change walk_system_ram to use System RAM type Toshi Kani
2015-12-25 22:09 ` Toshi Kani
2015-12-25 22:09 ` [PATCH v2 11/16] arm/samsung: Change s3c_pm_run_res() " Toshi Kani
2015-12-25 22:09 ` Toshi Kani
2015-12-25 22:09 ` [PATCH v2 12/16] memremap: Change region_intersects() to take @flags and @desc Toshi Kani
2015-12-25 22:09 ` Toshi Kani
2015-12-25 22:09 ` [PATCH v2 13/16] resource: Add walk_iomem_res_desc() Toshi Kani
2015-12-25 22:09 ` Toshi Kani
2015-12-25 22:09 ` [PATCH v2 14/16] x86,nvdimm,kexec: Use walk_iomem_res_desc() for iomem search Toshi Kani
2015-12-25 22:09 ` Toshi Kani
2015-12-25 22:09 ` Toshi Kani
2015-12-26 10:38 ` Borislav Petkov
2015-12-26 10:38 ` Borislav Petkov
2015-12-27 0:31 ` [PATCH v2 14/16] x86, nvdimm, kexec: " Toshi Kani
2015-12-27 0:31 ` [PATCH v2 14/16] x86,nvdimm,kexec: " Toshi Kani
2015-12-27 0:31 ` Toshi Kani
2015-12-27 0:31 ` Toshi Kani
2015-12-27 2:12 ` [PATCH v2 14/16] x86, nvdimm, kexec: " Minfei Huang
2015-12-27 2:12 ` Minfei Huang
2015-12-27 2:12 ` Minfei Huang
2015-12-27 10:24 ` Borislav Petkov
2015-12-27 10:24 ` Borislav Petkov
2015-12-27 10:24 ` Borislav Petkov
2016-01-04 9:29 ` Dave Young
2016-01-04 9:29 ` Dave Young
2016-01-04 9:29 ` Dave Young
2016-01-04 12:26 ` Borislav Petkov
2016-01-04 12:26 ` Borislav Petkov
2016-01-04 12:26 ` Borislav Petkov
2016-01-04 17:57 ` Toshi Kani
2016-01-04 17:57 ` Toshi Kani
2016-01-04 17:57 ` Toshi Kani
2016-01-04 19:41 ` Borislav Petkov
2016-01-04 19:41 ` Borislav Petkov
2016-01-04 19:45 ` Toshi Kani
2016-01-04 19:45 ` Toshi Kani
2016-01-04 19:45 ` Toshi Kani
2016-01-05 5:20 ` Dave Young
2016-01-05 5:20 ` Dave Young
2016-01-05 5:20 ` Dave Young
2015-12-26 16:05 ` Minfei Huang
2015-12-26 16:05 ` [PATCH v2 14/16] x86,nvdimm,kexec: " Minfei Huang
2015-12-26 16:05 ` Minfei Huang
2015-12-27 0:39 ` [PATCH v2 14/16] x86, nvdimm, kexec: " Toshi Kani
2015-12-27 0:39 ` [PATCH v2 14/16] x86,nvdimm,kexec: " Toshi Kani
2015-12-27 0:39 ` Toshi Kani
2016-01-04 9:25 ` [PATCH v2 14/16] x86, nvdimm, kexec: " Dave Young
2016-01-04 9:25 ` [PATCH v2 14/16] x86,nvdimm,kexec: " Dave Young
2016-01-04 9:25 ` Dave Young
2016-01-04 11:04 ` [PATCH v2 14/16] x86, nvdimm, kexec: " Dave Young
2016-01-04 11:04 ` [PATCH v2 14/16] x86,nvdimm,kexec: " Dave Young
2016-01-04 11:04 ` Dave Young
2015-12-25 22:09 ` [PATCH v2 15/16] checkpatch: Add warning on deprecated walk_iomem_res Toshi Kani
2015-12-25 22:09 ` Toshi Kani
2015-12-26 0:05 ` Joe Perches [this message]
2015-12-26 0:05 ` Joe Perches
2015-12-26 0:05 ` Joe Perches
2015-12-27 0:52 ` Toshi Kani
2015-12-27 0:52 ` Toshi Kani
2015-12-25 22:09 ` [PATCH v2 16/16] ACPI/EINJ: Allow memory error injection to NVDIMM Toshi Kani
2015-12-25 22:09 ` Toshi Kani
2015-12-25 22:09 ` Toshi Kani
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1451088307.12498.3.camel@perches.com \
--to=joe@perches.com \
--cc=akpm@linux-foundation.org \
--cc=apw@canonical.com \
--cc=bp@alien8.de \
--cc=linux-arch@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=toshi.kani@hpe.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.