From: Toshi Kani <toshi.kani@hpe.com>
To: Minfei Huang <mhuang@redhat.com>
Cc: linux-arch@vger.kernel.org, linux-nvdimm@ml01.01.org,
x86@kernel.org, kexec@lists.infradead.org,
linux-kernel@vger.kernel.org, linux-mm@kvack.org, bp@alien8.de,
akpm@linux-foundation.org, Dave Young <dyoung@redhat.com>,
Dan Williams <dan.j.williams@intel.com>
Subject: Re: [PATCH v2 14/16] x86, nvdimm, kexec: Use walk_iomem_res_desc() for iomem search
Date: Sat, 26 Dec 2015 17:39:05 -0700 [thread overview]
Message-ID: <567F3329.2030808@hpe.com> (raw)
In-Reply-To: <20151226160522.GA28533@dhcp-128-25.nay.redhat.com>
On 12/26/2015 9:05 AM, Minfei Huang wrote:
> Ccing kexec maillist.
>
> On 12/25/15 at 03:09pm, Toshi Kani wrote:
>> diff --git a/kernel/kexec_file.c b/kernel/kexec_file.c
>> index c245085..e2bd737 100644
>> --- a/kernel/kexec_file.c
>> +++ b/kernel/kexec_file.c
>> @@ -522,10 +522,10 @@ int kexec_add_buffer(struct kimage *image, char *buffer, unsigned long bufsz,
>>
>> /* Walk the RAM ranges and allocate a suitable range for the buffer */
>> if (image->type == KEXEC_TYPE_CRASH)
>> - ret = walk_iomem_res("Crash kernel",
>> - IORESOURCE_SYSTEM_RAM | IORESOURCE_BUSY,
>> - crashk_res.start, crashk_res.end, kbuf,
>> - locate_mem_hole_callback);
>> + ret = walk_iomem_res_desc(IORES_DESC_CRASH_KERNEL,
>
> Since crashk_res's desc has been assigned to IORES_DESC_CRASH_KERNEL, it
> is better to use crashk_res.desc, instead of using
> IORES_DESC_CRASH_KERNEL directly.
Sounds good. I will change it to use crashk_res.desc.
Thanks,
-Toshi
_______________________________________________
kexec mailing list
kexec@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/kexec
WARNING: multiple messages have this Message-ID (diff)
From: Toshi Kani <toshi.kani@hpe.com>
To: Minfei Huang <mhuang@redhat.com>
Cc: akpm@linux-foundation.org, bp@alien8.de,
linux-arch@vger.kernel.org, linux-mm@kvack.org,
linux-kernel@vger.kernel.org,
Dan Williams <dan.j.williams@intel.com>,
Dave Young <dyoung@redhat.com>,
x86@kernel.org, linux-nvdimm@ml01.01.org,
kexec@lists.infradead.org
Subject: Re: [PATCH v2 14/16] x86,nvdimm,kexec: Use walk_iomem_res_desc() for iomem search
Date: Sat, 26 Dec 2015 17:39:05 -0700 [thread overview]
Message-ID: <567F3329.2030808@hpe.com> (raw)
In-Reply-To: <20151226160522.GA28533@dhcp-128-25.nay.redhat.com>
On 12/26/2015 9:05 AM, Minfei Huang wrote:
> Ccing kexec maillist.
>
> On 12/25/15 at 03:09pm, Toshi Kani wrote:
>> diff --git a/kernel/kexec_file.c b/kernel/kexec_file.c
>> index c245085..e2bd737 100644
>> --- a/kernel/kexec_file.c
>> +++ b/kernel/kexec_file.c
>> @@ -522,10 +522,10 @@ int kexec_add_buffer(struct kimage *image, char *buffer, unsigned long bufsz,
>>
>> /* Walk the RAM ranges and allocate a suitable range for the buffer */
>> if (image->type == KEXEC_TYPE_CRASH)
>> - ret = walk_iomem_res("Crash kernel",
>> - IORESOURCE_SYSTEM_RAM | IORESOURCE_BUSY,
>> - crashk_res.start, crashk_res.end, kbuf,
>> - locate_mem_hole_callback);
>> + ret = walk_iomem_res_desc(IORES_DESC_CRASH_KERNEL,
>
> Since crashk_res's desc has been assigned to IORES_DESC_CRASH_KERNEL, it
> is better to use crashk_res.desc, instead of using
> IORES_DESC_CRASH_KERNEL directly.
Sounds good. I will change it to use crashk_res.desc.
Thanks,
-Toshi
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
WARNING: multiple messages have this Message-ID (diff)
From: Toshi Kani <toshi.kani@hpe.com>
To: Minfei Huang <mhuang@redhat.com>
Cc: akpm@linux-foundation.org, bp@alien8.de,
linux-arch@vger.kernel.org, linux-mm@kvack.org,
linux-kernel@vger.kernel.org,
Dan Williams <dan.j.williams@intel.com>,
Dave Young <dyoung@redhat.com>,
x86@kernel.org, linux-nvdimm@ml01.01.org,
kexec@lists.infradead.org
Subject: Re: [PATCH v2 14/16] x86,nvdimm,kexec: Use walk_iomem_res_desc() for iomem search
Date: Sat, 26 Dec 2015 17:39:05 -0700 [thread overview]
Message-ID: <567F3329.2030808@hpe.com> (raw)
Message-ID: <20151227003905.R9REN54ZsfeKz4hdRY7-hQ857oR4RlKUJPmp_vmdI7Y@z> (raw)
In-Reply-To: <20151226160522.GA28533@dhcp-128-25.nay.redhat.com>
On 12/26/2015 9:05 AM, Minfei Huang wrote:
> Ccing kexec maillist.
>
> On 12/25/15 at 03:09pm, Toshi Kani wrote:
>> diff --git a/kernel/kexec_file.c b/kernel/kexec_file.c
>> index c245085..e2bd737 100644
>> --- a/kernel/kexec_file.c
>> +++ b/kernel/kexec_file.c
>> @@ -522,10 +522,10 @@ int kexec_add_buffer(struct kimage *image, char *buffer, unsigned long bufsz,
>>
>> /* Walk the RAM ranges and allocate a suitable range for the buffer */
>> if (image->type == KEXEC_TYPE_CRASH)
>> - ret = walk_iomem_res("Crash kernel",
>> - IORESOURCE_SYSTEM_RAM | IORESOURCE_BUSY,
>> - crashk_res.start, crashk_res.end, kbuf,
>> - locate_mem_hole_callback);
>> + ret = walk_iomem_res_desc(IORES_DESC_CRASH_KERNEL,
>
> Since crashk_res's desc has been assigned to IORES_DESC_CRASH_KERNEL, it
> is better to use crashk_res.desc, instead of using
> IORES_DESC_CRASH_KERNEL directly.
Sounds good. I will change it to use crashk_res.desc.
Thanks,
-Toshi
next prev parent reply other threads:[~2015-12-27 0:39 UTC|newest]
Thread overview: 90+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-12-25 22:09 [PATCH v2 01/16] resource: Add System RAM resource type Toshi Kani
2015-12-25 22:09 ` Toshi Kani
2015-12-25 22:09 ` [PATCH v2 02/16] resource: make resource flags handled properly Toshi Kani
2015-12-25 22:09 ` Toshi Kani
2015-12-25 22:09 ` [PATCH v2 03/16] resource: Add I/O resource descriptor Toshi Kani
2015-12-25 22:09 ` Toshi Kani
2015-12-25 22:09 ` [PATCH v2 04/16] x86/e820: Set System RAM type and descriptor Toshi Kani
2015-12-25 22:09 ` Toshi Kani
2015-12-25 22:09 ` [PATCH v2 05/16] ia64: " Toshi Kani
2015-12-25 22:09 ` Toshi Kani
2015-12-25 22:09 ` Toshi Kani
2015-12-25 22:09 ` [PATCH v2 06/16] arch: Set IORESOURCE_SYSTEM_RAM to System RAM Toshi Kani
2015-12-25 22:09 ` Toshi Kani
2015-12-25 22:09 ` [PATCH v2 07/16] kexec: " Toshi Kani
2015-12-25 22:09 ` Toshi Kani
2015-12-25 22:09 ` [PATCH v2 08/16] xen, mm: " Toshi Kani
2015-12-25 22:09 ` Toshi Kani
2016-01-04 11:41 ` [Xen-devel] " David Vrabel
2016-01-04 11:41 ` David Vrabel
2016-01-04 11:41 ` David Vrabel
2016-01-04 11:41 ` David Vrabel
2015-12-25 22:09 ` Toshi Kani
2015-12-25 22:09 ` [PATCH v2 09/16] drivers: Initialize resource entry to zero Toshi Kani
2015-12-25 22:09 ` Toshi Kani
2015-12-25 22:09 ` Toshi Kani
2015-12-28 21:37 ` Simon Horman
2015-12-28 21:37 ` Simon Horman
2015-12-28 21:37 ` Simon Horman
2015-12-25 22:09 ` [PATCH v2 10/16] resource: Change walk_system_ram to use System RAM type Toshi Kani
2015-12-25 22:09 ` Toshi Kani
2015-12-25 22:09 ` [PATCH v2 11/16] arm/samsung: Change s3c_pm_run_res() " Toshi Kani
2015-12-25 22:09 ` Toshi Kani
2015-12-25 22:09 ` [PATCH v2 12/16] memremap: Change region_intersects() to take @flags and @desc Toshi Kani
2015-12-25 22:09 ` Toshi Kani
2015-12-25 22:09 ` [PATCH v2 13/16] resource: Add walk_iomem_res_desc() Toshi Kani
2015-12-25 22:09 ` Toshi Kani
2015-12-25 22:09 ` [PATCH v2 14/16] x86,nvdimm,kexec: Use walk_iomem_res_desc() for iomem search Toshi Kani
2015-12-25 22:09 ` Toshi Kani
2015-12-25 22:09 ` Toshi Kani
2015-12-26 10:38 ` Borislav Petkov
2015-12-26 10:38 ` Borislav Petkov
2015-12-27 0:31 ` [PATCH v2 14/16] x86, nvdimm, kexec: " Toshi Kani
2015-12-27 0:31 ` [PATCH v2 14/16] x86,nvdimm,kexec: " Toshi Kani
2015-12-27 0:31 ` Toshi Kani
2015-12-27 0:31 ` Toshi Kani
2015-12-27 2:12 ` [PATCH v2 14/16] x86, nvdimm, kexec: " Minfei Huang
2015-12-27 2:12 ` Minfei Huang
2015-12-27 2:12 ` Minfei Huang
2015-12-27 10:24 ` Borislav Petkov
2015-12-27 10:24 ` Borislav Petkov
2015-12-27 10:24 ` Borislav Petkov
2016-01-04 9:29 ` Dave Young
2016-01-04 9:29 ` Dave Young
2016-01-04 9:29 ` Dave Young
2016-01-04 12:26 ` Borislav Petkov
2016-01-04 12:26 ` Borislav Petkov
2016-01-04 12:26 ` Borislav Petkov
2016-01-04 17:57 ` Toshi Kani
2016-01-04 17:57 ` Toshi Kani
2016-01-04 17:57 ` Toshi Kani
2016-01-04 19:41 ` Borislav Petkov
2016-01-04 19:41 ` Borislav Petkov
2016-01-04 19:45 ` Toshi Kani
2016-01-04 19:45 ` Toshi Kani
2016-01-04 19:45 ` Toshi Kani
2016-01-05 5:20 ` Dave Young
2016-01-05 5:20 ` Dave Young
2016-01-05 5:20 ` Dave Young
2015-12-26 16:05 ` Minfei Huang
2015-12-26 16:05 ` [PATCH v2 14/16] x86,nvdimm,kexec: " Minfei Huang
2015-12-26 16:05 ` Minfei Huang
2015-12-27 0:39 ` Toshi Kani [this message]
2015-12-27 0:39 ` Toshi Kani
2015-12-27 0:39 ` Toshi Kani
2016-01-04 9:25 ` [PATCH v2 14/16] x86, nvdimm, kexec: " Dave Young
2016-01-04 9:25 ` [PATCH v2 14/16] x86,nvdimm,kexec: " Dave Young
2016-01-04 9:25 ` Dave Young
2016-01-04 11:04 ` [PATCH v2 14/16] x86, nvdimm, kexec: " Dave Young
2016-01-04 11:04 ` [PATCH v2 14/16] x86,nvdimm,kexec: " Dave Young
2016-01-04 11:04 ` Dave Young
2015-12-25 22:09 ` [PATCH v2 15/16] checkpatch: Add warning on deprecated walk_iomem_res Toshi Kani
2015-12-25 22:09 ` Toshi Kani
2015-12-26 0:05 ` Joe Perches
2015-12-26 0:05 ` Joe Perches
2015-12-26 0:05 ` Joe Perches
2015-12-27 0:52 ` Toshi Kani
2015-12-27 0:52 ` Toshi Kani
2015-12-25 22:09 ` [PATCH v2 16/16] ACPI/EINJ: Allow memory error injection to NVDIMM Toshi Kani
2015-12-25 22:09 ` Toshi Kani
2015-12-25 22:09 ` Toshi Kani
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=567F3329.2030808@hpe.com \
--to=toshi.kani@hpe.com \
--cc=akpm@linux-foundation.org \
--cc=bp@alien8.de \
--cc=dan.j.williams@intel.com \
--cc=dyoung@redhat.com \
--cc=kexec@lists.infradead.org \
--cc=linux-arch@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=linux-nvdimm@ml01.01.org \
--cc=mhuang@redhat.com \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.