* [meta-oe][kirkstone][PATCH] rocksdb: remove rocksdb_static from default PACKAGECONFIG
@ 2026-04-15 18:20 Zahir Hussain
2026-04-15 18:27 ` [oe] " Gyorgy Sarvari
0 siblings, 1 reply; 7+ messages in thread
From: Zahir Hussain @ 2026-04-15 18:20 UTC (permalink / raw)
To: openembedded-devel, zahir.basha; +Cc: mail2szahir
From: Zahir Hussain <zahir.basha@kpit.com>
In our previous commit
https://git.openembedded.org/meta-openembedded/commit/?h=kirkstone&id=33822593e5aed47f619a385579a47c366859408a
While adding the packageconfig knob for static library generation,
rocksdb_static was mistakenly included in the default PACKAGECONFIG list.
Remove it from the defaults so that the static library is not built
unless explicitly enabled by the user.
Signed-off-by: Zahir Hussain <zahir.basha@kpit.com>
---
meta-oe/recipes-dbs/rocksdb/rocksdb_6.20.3.bb | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/meta-oe/recipes-dbs/rocksdb/rocksdb_6.20.3.bb b/meta-oe/recipes-dbs/rocksdb/rocksdb_6.20.3.bb
index 7bfe157c1f..7e39928bec 100644
--- a/meta-oe/recipes-dbs/rocksdb/rocksdb_6.20.3.bb
+++ b/meta-oe/recipes-dbs/rocksdb/rocksdb_6.20.3.bb
@@ -31,7 +31,7 @@ S = "${WORKDIR}/git"
inherit cmake ptest
-PACKAGECONFIG ??= "bzip2 zlib lz4 gflagsi rocksdb_static"
+PACKAGECONFIG ??= "bzip2 zlib lz4 gflags"
PACKAGECONFIG[bzip2] = "-DWITH_BZ2=ON,-DWITH_BZ2=OFF,bzip2"
PACKAGECONFIG[lz4] = "-DWITH_LZ4=ON,-DWITH_LZ4=OFF,lz4"
PACKAGECONFIG[zlib] = "-DWITH_ZLIB=ON,-DWITH_ZLIB=OFF,zlib"
--
2.34.1
^ permalink raw reply related [flat|nested] 7+ messages in thread
* Re: [oe] [meta-oe][kirkstone][PATCH] rocksdb: remove rocksdb_static from default PACKAGECONFIG
2026-04-15 18:20 [meta-oe][kirkstone][PATCH] rocksdb: remove rocksdb_static from default PACKAGECONFIG Zahir Hussain
@ 2026-04-15 18:27 ` Gyorgy Sarvari
2026-04-16 19:10 ` aszh07
0 siblings, 1 reply; 7+ messages in thread
From: Gyorgy Sarvari @ 2026-04-15 18:27 UTC (permalink / raw)
To: mail2szahir, openembedded-devel, zahir.basha
On 4/15/26 20:20, aszh07 via lists.openembedded.org wrote:
> From: Zahir Hussain <zahir.basha@kpit.com>
>
> In our previous commit
> https://git.openembedded.org/meta-openembedded/commit/?h=kirkstone&id=33822593e5aed47f619a385579a47c366859408a
>
> While adding the packageconfig knob for static library generation,
> rocksdb_static was mistakenly included in the default PACKAGECONFIG list.
That was left there intentionally. We discussed that we (well, at least
I) don't want to change the default behavior of the recipe so close to
the end of the branch's supported lifetime.
>
> Remove it from the defaults so that the static library is not built
> unless explicitly enabled by the user.
>
> Signed-off-by: Zahir Hussain <zahir.basha@kpit.com>
> ---
> meta-oe/recipes-dbs/rocksdb/rocksdb_6.20.3.bb | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/meta-oe/recipes-dbs/rocksdb/rocksdb_6.20.3.bb b/meta-oe/recipes-dbs/rocksdb/rocksdb_6.20.3.bb
> index 7bfe157c1f..7e39928bec 100644
> --- a/meta-oe/recipes-dbs/rocksdb/rocksdb_6.20.3.bb
> +++ b/meta-oe/recipes-dbs/rocksdb/rocksdb_6.20.3.bb
> @@ -31,7 +31,7 @@ S = "${WORKDIR}/git"
>
> inherit cmake ptest
>
> -PACKAGECONFIG ??= "bzip2 zlib lz4 gflagsi rocksdb_static"
> +PACKAGECONFIG ??= "bzip2 zlib lz4 gflags"
> PACKAGECONFIG[bzip2] = "-DWITH_BZ2=ON,-DWITH_BZ2=OFF,bzip2"
> PACKAGECONFIG[lz4] = "-DWITH_LZ4=ON,-DWITH_LZ4=OFF,lz4"
> PACKAGECONFIG[zlib] = "-DWITH_ZLIB=ON,-DWITH_ZLIB=OFF,zlib"
>
>
>
> -=-=-=-=-=-=-=-=-=-=-=-
> Links: You receive all messages sent to this group.
> View/Reply Online (#126370): https://lists.openembedded.org/g/openembedded-devel/message/126370
> Mute This Topic: https://lists.openembedded.org/mt/118845876/6084445
> Group Owner: openembedded-devel+owner@lists.openembedded.org
> Unsubscribe: https://lists.openembedded.org/g/openembedded-devel/unsub [skandigraun@gmail.com]
> -=-=-=-=-=-=-=-=-=-=-=-
>
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [meta-oe][kirkstone][PATCH] rocksdb: remove rocksdb_static from default PACKAGECONFIG
2026-04-15 18:27 ` [oe] " Gyorgy Sarvari
@ 2026-04-16 19:10 ` aszh07
2026-04-16 19:23 ` [oe] " Gyorgy Sarvari
0 siblings, 1 reply; 7+ messages in thread
From: aszh07 @ 2026-04-16 19:10 UTC (permalink / raw)
To: openembedded-devel
[-- Attachment #1: Type: text/plain, Size: 287 bytes --]
On Wed, Apr 15, 2026 at 11:57 PM, Gyorgy Sarvari wrote:
>
> PACKAGECONFIG ??= "bzip2 zlib lz4 gflagsi rocksdb_static"
Just a heads-up—I spotted a typo in the PACKAGECONFIG string. It says gflagsi instead of gflags.
will you correct the typo or can i send the patch for this?
[-- Attachment #2: Type: text/html, Size: 340 bytes --]
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [oe] [meta-oe][kirkstone][PATCH] rocksdb: remove rocksdb_static from default PACKAGECONFIG
2026-04-16 19:10 ` aszh07
@ 2026-04-16 19:23 ` Gyorgy Sarvari
2026-04-17 10:12 ` aszh07
0 siblings, 1 reply; 7+ messages in thread
From: Gyorgy Sarvari @ 2026-04-16 19:23 UTC (permalink / raw)
To: mail2szahir, openembedded-devel
On 4/16/26 21:10, aszh07 via lists.openembedded.org wrote:
> On Wed, Apr 15, 2026 at 11:57 PM, Gyorgy Sarvari wrote:
>
> PACKAGECONFIG ??= "bzip2 zlib lz4 gflagsi rocksdb_static"
>
>
> Just a heads-up—I spotted a typo in the PACKAGECONFIG string. It says
> gflagsi instead of gflags.
> will you correct the typo or can i send the patch for this?
>
>
Please send a patch. Thanks
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [meta-oe][kirkstone][PATCH] rocksdb: remove rocksdb_static from default PACKAGECONFIG
2026-04-16 19:23 ` [oe] " Gyorgy Sarvari
@ 2026-04-17 10:12 ` aszh07
2026-04-27 10:20 ` aszh07
0 siblings, 1 reply; 7+ messages in thread
From: aszh07 @ 2026-04-17 10:12 UTC (permalink / raw)
To: openembedded-devel
[-- Attachment #1: Type: text/plain, Size: 109 bytes --]
Please find the patch in the below link
https://lists.openembedded.org/g/openembedded-devel/message/126431
[-- Attachment #2: Type: text/html, Size: 124 bytes --]
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [meta-oe][kirkstone][PATCH] rocksdb: remove rocksdb_static from default PACKAGECONFIG
2026-04-17 10:12 ` aszh07
@ 2026-04-27 10:20 ` aszh07
2026-04-27 11:42 ` [oe] " Gyorgy Sarvari
0 siblings, 1 reply; 7+ messages in thread
From: aszh07 @ 2026-04-27 10:20 UTC (permalink / raw)
To: openembedded-devel
[-- Attachment #1: Type: text/plain, Size: 133 bytes --]
Hi Gyorgy,
May i know, what is the staus now for this patch?
https://lists.openembedded.org/g/openembedded-devel/message/126431
[-- Attachment #2: Type: text/html, Size: 844 bytes --]
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [oe] [meta-oe][kirkstone][PATCH] rocksdb: remove rocksdb_static from default PACKAGECONFIG
2026-04-27 10:20 ` aszh07
@ 2026-04-27 11:42 ` Gyorgy Sarvari
0 siblings, 0 replies; 7+ messages in thread
From: Gyorgy Sarvari @ 2026-04-27 11:42 UTC (permalink / raw)
To: mail2szahir, openembedded-devel
On 4/27/26 12:20, aszh07 via lists.openembedded.org wrote:
> Hi Gyorgy,
>
> May i know, what is the staus now for this patch?
> https://lists.openembedded.org/g/openembedded-devel/message/126431
>
>
It is queued up for the final PR:
https://git.openembedded.org/meta-openembedded-contrib/commit/?h=stable/kirkstone-nut&id=9dc7ca5feb00e7971a0cf95b90dbc0b75987121b
> -=-=-=-=-=-=-=-=-=-=-=-
> Links: You receive all messages sent to this group.
> View/Reply Online (#126638): https://lists.openembedded.org/g/openembedded-devel/message/126638
> Mute This Topic: https://lists.openembedded.org/mt/118845876/6084445
> Group Owner: openembedded-devel+owner@lists.openembedded.org
> Unsubscribe: https://lists.openembedded.org/g/openembedded-devel/unsub [skandigraun@gmail.com]
> -=-=-=-=-=-=-=-=-=-=-=-
>
^ permalink raw reply [flat|nested] 7+ messages in thread
end of thread, other threads:[~2026-04-27 11:42 UTC | newest]
Thread overview: 7+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-04-15 18:20 [meta-oe][kirkstone][PATCH] rocksdb: remove rocksdb_static from default PACKAGECONFIG Zahir Hussain
2026-04-15 18:27 ` [oe] " Gyorgy Sarvari
2026-04-16 19:10 ` aszh07
2026-04-16 19:23 ` [oe] " Gyorgy Sarvari
2026-04-17 10:12 ` aszh07
2026-04-27 10:20 ` aszh07
2026-04-27 11:42 ` [oe] " Gyorgy Sarvari
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.