* [PATCH] cooker: Drop useless parsing exception
@ 2016-01-04 17:32 Richard Purdie
0 siblings, 0 replies; only message in thread
From: Richard Purdie @ 2016-01-04 17:32 UTC (permalink / raw)
To: bitbake-devel
The SyntaxError exception simply shows the recipe that failed to parse
which is pretty useless without the actual exception. We could make it
print more info, however we can just use one of the more generic handlers
instead and remove this one.
For a python indentation error, this leads to a much more readable error
message.
Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
diff --git a/bitbake/lib/bb/cooker.py b/bitbake/lib/bb/cooker.py
index 4df8881..5ceb198 100644
--- a/bitbake/lib/bb/cooker.py
+++ b/bitbake/lib/bb/cooker.py
@@ -2125,11 +2125,6 @@ class CookerParser(object):
logger.error('ExpansionError during parsing %s: %s', value.recipe, str(exc))
self.shutdown(clean=False)
return False
- except SyntaxError as exc:
- self.error += 1
- logger.error('Unable to parse %s', exc.recipe)
- self.shutdown(clean=False)
- return False
except Exception as exc:
self.error += 1
etype, value, tb = sys.exc_info()
^ permalink raw reply related [flat|nested] only message in thread
only message in thread, other threads:[~2016-01-04 17:32 UTC | newest]
Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-01-04 17:32 [PATCH] cooker: Drop useless parsing exception Richard Purdie
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.