From: "Hervé Poussineau" <hpoussin@reactos.org>
To: qemu-devel@nongnu.org
Cc: "Paolo Bonzini" <pbonzini@redhat.com>,
"Leon Alrae" <leon.alrae@imgtec.com>,
"Hervé Poussineau" <hpoussin@reactos.org>,
"Aurelien Jarno" <aurelien@aurel32.net>,
"Michael S. Tsirkin" <mst@redhat.com>
Subject: [Qemu-devel] [PATCH v2 12/19] magnum: disable floppy DMA for now
Date: Sun, 10 Jan 2016 16:24:51 +0100 [thread overview]
Message-ID: <1452439498-21098-13-git-send-email-hpoussin@reactos.org> (raw)
In-Reply-To: <1452439498-21098-1-git-send-email-hpoussin@reactos.org>
Floppy uses the DMA controller in rc4030 chipset, and not the i8259 from the ISA bus.
It's better to disable DMA than to call the wrong DMA controller.
Signed-off-by: Hervé Poussineau <hpoussin@reactos.org>
---
hw/mips/mips_jazz.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/hw/mips/mips_jazz.c b/hw/mips/mips_jazz.c
index 64a0de2..37ab71a 100644
--- a/hw/mips/mips_jazz.c
+++ b/hw/mips/mips_jazz.c
@@ -296,7 +296,8 @@ static void mips_jazz_init(MachineState *machine,
for (n = 0; n < MAX_FD; n++) {
fds[n] = drive_get(IF_FLOPPY, 0, n);
}
- fdctrl_init_sysbus(qdev_get_gpio_in(rc4030, 1), 0, 0x80003000, fds);
+ /* FIXME: we should enable DMA with a custom IsaDma device */
+ fdctrl_init_sysbus(qdev_get_gpio_in(rc4030, 1), -1, 0x80003000, fds);
/* Real time clock */
rtc_init(isa_bus, 1980, NULL);
--
2.1.4
next prev parent reply other threads:[~2016-01-10 15:25 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-01-10 15:24 [Qemu-devel] [PATCH v2 00/19] ISA DMA controllers cleanup (i8257, i82374) Hervé Poussineau
2016-01-10 15:24 ` [Qemu-devel] [PATCH v2 01/19] i82374: device only existed as ISA device, so simplify device Hervé Poussineau
2016-01-10 15:24 ` [Qemu-devel] [PATCH v2 02/19] i8257: pass ISA bus to DMA_init() function Hervé Poussineau
2016-01-10 15:24 ` [Qemu-devel] [PATCH v2 03/19] i8257: rename struct dma_cont to I8257State Hervé Poussineau
2016-01-10 15:24 ` [Qemu-devel] [PATCH v2 04/19] i8257: rename struct dma_regs to I8257Regs Hervé Poussineau
2016-01-10 15:24 ` [Qemu-devel] [PATCH v2 05/19] i8257: rename functions to start with i8257_ prefix Hervé Poussineau
2016-01-10 15:24 ` [Qemu-devel] [PATCH v2 06/19] i8257: make the DMA running method per controller Hervé Poussineau
2016-01-10 15:24 ` [Qemu-devel] [PATCH v2 07/19] i8257: add missing const Hervé Poussineau
2016-01-10 15:24 ` [Qemu-devel] [PATCH v2 08/19] i8257: QOM'ify Hervé Poussineau
2016-01-10 15:24 ` [Qemu-devel] [PATCH v2 09/19] i8257: move state definition to new independent header Hervé Poussineau
2016-01-10 15:24 ` [Qemu-devel] [PATCH v2 10/19] isa: add an ISA DMA interface, and store it within the ISA bus Hervé Poussineau
2016-01-10 15:24 ` [Qemu-devel] [PATCH v2 11/19] i8257: implement the IsaDma interface Hervé Poussineau
2016-01-10 15:24 ` Hervé Poussineau [this message]
2016-01-10 15:24 ` [Qemu-devel] [PATCH v2 13/19] sparc: disable floppy DMA Hervé Poussineau
2016-01-10 15:24 ` [Qemu-devel] [PATCH v2 14/19] sparc64: " Hervé Poussineau
2016-01-10 15:24 ` [Qemu-devel] [PATCH v2 15/19] fdc: use IsaDma interface instead of global DMA_* functions Hervé Poussineau
2016-01-10 15:24 ` [Qemu-devel] [PATCH v2 16/19] cs4231a: " Hervé Poussineau
2016-01-10 15:24 ` [Qemu-devel] [PATCH v2 17/19] gus: " Hervé Poussineau
2016-01-10 15:24 ` [Qemu-devel] [PATCH v2 18/19] sb16: " Hervé Poussineau
2016-01-10 15:24 ` [Qemu-devel] [PATCH v2 19/19] dma: remove now useless " Hervé Poussineau
2016-01-20 20:31 ` [Qemu-devel] [PATCH v2 00/19] ISA DMA controllers cleanup (i8257, i82374) Hervé Poussineau
2016-01-21 10:21 ` Paolo Bonzini
2016-01-21 15:56 ` John Snow
2016-01-26 20:26 ` John Snow
2016-01-26 21:14 ` Hervé Poussineau
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1452439498-21098-13-git-send-email-hpoussin@reactos.org \
--to=hpoussin@reactos.org \
--cc=aurelien@aurel32.net \
--cc=leon.alrae@imgtec.com \
--cc=mst@redhat.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.