All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Hervé Poussineau" <hpoussin@reactos.org>
To: qemu-devel@nongnu.org
Cc: "Paolo Bonzini" <pbonzini@redhat.com>,
	"Hervé Poussineau" <hpoussin@reactos.org>,
	"Michael S. Tsirkin" <mst@redhat.com>
Subject: [Qemu-devel] [PATCH v2 04/19] i8257: rename struct dma_regs to I8257Regs
Date: Sun, 10 Jan 2016 16:24:43 +0100	[thread overview]
Message-ID: <1452439498-21098-5-git-send-email-hpoussin@reactos.org> (raw)
In-Reply-To: <1452439498-21098-1-git-send-email-hpoussin@reactos.org>

Signed-off-by: Hervé Poussineau <hpoussin@reactos.org>
---
 hw/dma/i8257.c | 40 ++++++++++++++++++++--------------------
 1 file changed, 20 insertions(+), 20 deletions(-)

diff --git a/hw/dma/i8257.c b/hw/dma/i8257.c
index f4fcf39..e0713a5 100644
--- a/hw/dma/i8257.c
+++ b/hw/dma/i8257.c
@@ -37,7 +37,7 @@
 #define ldebug(...)
 #endif
 
-struct dma_regs {
+typedef struct I8257Regs {
     int now[2];
     uint16_t base[2];
     uint8_t mode;
@@ -47,7 +47,7 @@ struct dma_regs {
     uint8_t eop;
     DMA_transfer_handler transfer_handler;
     void *opaque;
-};
+} I8257Regs;
 
 #define ADDR 0
 #define COUNT 1
@@ -58,7 +58,7 @@ typedef struct I8257State {
     uint8_t mask;
     uint8_t flip_flop;
     int dshift;
-    struct dma_regs regs[4];
+    I8257Regs regs[4];
     MemoryRegion channel_io;
     MemoryRegion cont_io;
 } I8257State;
@@ -138,7 +138,7 @@ static uint32_t read_pageh (void *opaque, uint32_t nport)
 
 static inline void init_chan(I8257State *d, int ichan)
 {
-    struct dma_regs *r;
+    I8257Regs *r;
 
     r = d->regs + ichan;
     r->now[ADDR] = r->base[ADDR] << d->dshift;
@@ -158,7 +158,7 @@ static uint64_t read_chan(void *opaque, hwaddr nport, unsigned size)
 {
     I8257State *d = opaque;
     int ichan, nreg, iport, ff, val, dir;
-    struct dma_regs *r;
+    I8257Regs *r;
 
     iport = (nport >> d->dshift) & 0x0f;
     ichan = iport >> 1;
@@ -181,7 +181,7 @@ static void write_chan(void *opaque, hwaddr nport, uint64_t data,
 {
     I8257State *d = opaque;
     int iport, ichan, nreg;
-    struct dma_regs *r;
+    I8257Regs *r;
 
     iport = (nport >> d->dshift) & 0x0f;
     ichan = iport >> 1;
@@ -337,7 +337,7 @@ void DMA_release_DREQ (int nchan)
 static void channel_run (int ncont, int ichan)
 {
     int n;
-    struct dma_regs *r = &dma_controllers[ncont].regs[ichan];
+    I8257Regs *r = &dma_controllers[ncont].regs[ichan];
 #ifdef DEBUG_DMA
     int dir, opmode;
 
@@ -408,7 +408,7 @@ void DMA_register_channel (int nchan,
                            DMA_transfer_handler transfer_handler,
                            void *opaque)
 {
-    struct dma_regs *r;
+    I8257Regs *r;
     int ichan, ncont;
 
     ncont = nchan > 3;
@@ -421,7 +421,7 @@ void DMA_register_channel (int nchan,
 
 int DMA_read_memory (int nchan, void *buf, int pos, int len)
 {
-    struct dma_regs *r = &dma_controllers[nchan > 3].regs[nchan & 3];
+    I8257Regs *r = &dma_controllers[nchan > 3].regs[nchan & 3];
     hwaddr addr = ((r->pageh & 0x7f) << 24) | (r->page << 16) | r->now[ADDR];
 
     if (r->mode & 0x20) {
@@ -443,7 +443,7 @@ int DMA_read_memory (int nchan, void *buf, int pos, int len)
 
 int DMA_write_memory (int nchan, void *buf, int pos, int len)
 {
-    struct dma_regs *r = &dma_controllers[nchan > 3].regs[nchan & 3];
+    I8257Regs *r = &dma_controllers[nchan > 3].regs[nchan & 3];
     hwaddr addr = ((r->pageh & 0x7f) << 24) | (r->page << 16) | r->now[ADDR];
 
     if (r->mode & 0x20) {
@@ -552,18 +552,18 @@ static void dma_init2(I8257State *d, int base, int dshift,
     }
 }
 
-static const VMStateDescription vmstate_dma_regs = {
+static const VMStateDescription vmstate_i8257_regs = {
     .name = "dma_regs",
     .version_id = 1,
     .minimum_version_id = 1,
     .fields = (VMStateField[]) {
-        VMSTATE_INT32_ARRAY(now, struct dma_regs, 2),
-        VMSTATE_UINT16_ARRAY(base, struct dma_regs, 2),
-        VMSTATE_UINT8(mode, struct dma_regs),
-        VMSTATE_UINT8(page, struct dma_regs),
-        VMSTATE_UINT8(pageh, struct dma_regs),
-        VMSTATE_UINT8(dack, struct dma_regs),
-        VMSTATE_UINT8(eop, struct dma_regs),
+        VMSTATE_INT32_ARRAY(now, I8257Regs, 2),
+        VMSTATE_UINT16_ARRAY(base, I8257Regs, 2),
+        VMSTATE_UINT8(mode, I8257Regs),
+        VMSTATE_UINT8(page, I8257Regs),
+        VMSTATE_UINT8(pageh, I8257Regs),
+        VMSTATE_UINT8(dack, I8257Regs),
+        VMSTATE_UINT8(eop, I8257Regs),
         VMSTATE_END_OF_LIST()
     }
 };
@@ -585,8 +585,8 @@ static const VMStateDescription vmstate_dma = {
         VMSTATE_UINT8(mask, I8257State),
         VMSTATE_UINT8(flip_flop, I8257State),
         VMSTATE_INT32(dshift, I8257State),
-        VMSTATE_STRUCT_ARRAY(regs, I8257State, 4, 1, vmstate_dma_regs,
-                             struct dma_regs),
+        VMSTATE_STRUCT_ARRAY(regs, I8257State, 4, 1, vmstate_i8257_regs,
+                             I8257Regs),
         VMSTATE_END_OF_LIST()
     }
 };
-- 
2.1.4

  parent reply	other threads:[~2016-01-10 15:25 UTC|newest]

Thread overview: 25+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-01-10 15:24 [Qemu-devel] [PATCH v2 00/19] ISA DMA controllers cleanup (i8257, i82374) Hervé Poussineau
2016-01-10 15:24 ` [Qemu-devel] [PATCH v2 01/19] i82374: device only existed as ISA device, so simplify device Hervé Poussineau
2016-01-10 15:24 ` [Qemu-devel] [PATCH v2 02/19] i8257: pass ISA bus to DMA_init() function Hervé Poussineau
2016-01-10 15:24 ` [Qemu-devel] [PATCH v2 03/19] i8257: rename struct dma_cont to I8257State Hervé Poussineau
2016-01-10 15:24 ` Hervé Poussineau [this message]
2016-01-10 15:24 ` [Qemu-devel] [PATCH v2 05/19] i8257: rename functions to start with i8257_ prefix Hervé Poussineau
2016-01-10 15:24 ` [Qemu-devel] [PATCH v2 06/19] i8257: make the DMA running method per controller Hervé Poussineau
2016-01-10 15:24 ` [Qemu-devel] [PATCH v2 07/19] i8257: add missing const Hervé Poussineau
2016-01-10 15:24 ` [Qemu-devel] [PATCH v2 08/19] i8257: QOM'ify Hervé Poussineau
2016-01-10 15:24 ` [Qemu-devel] [PATCH v2 09/19] i8257: move state definition to new independent header Hervé Poussineau
2016-01-10 15:24 ` [Qemu-devel] [PATCH v2 10/19] isa: add an ISA DMA interface, and store it within the ISA bus Hervé Poussineau
2016-01-10 15:24 ` [Qemu-devel] [PATCH v2 11/19] i8257: implement the IsaDma interface Hervé Poussineau
2016-01-10 15:24 ` [Qemu-devel] [PATCH v2 12/19] magnum: disable floppy DMA for now Hervé Poussineau
2016-01-10 15:24 ` [Qemu-devel] [PATCH v2 13/19] sparc: disable floppy DMA Hervé Poussineau
2016-01-10 15:24 ` [Qemu-devel] [PATCH v2 14/19] sparc64: " Hervé Poussineau
2016-01-10 15:24 ` [Qemu-devel] [PATCH v2 15/19] fdc: use IsaDma interface instead of global DMA_* functions Hervé Poussineau
2016-01-10 15:24 ` [Qemu-devel] [PATCH v2 16/19] cs4231a: " Hervé Poussineau
2016-01-10 15:24 ` [Qemu-devel] [PATCH v2 17/19] gus: " Hervé Poussineau
2016-01-10 15:24 ` [Qemu-devel] [PATCH v2 18/19] sb16: " Hervé Poussineau
2016-01-10 15:24 ` [Qemu-devel] [PATCH v2 19/19] dma: remove now useless " Hervé Poussineau
2016-01-20 20:31 ` [Qemu-devel] [PATCH v2 00/19] ISA DMA controllers cleanup (i8257, i82374) Hervé Poussineau
2016-01-21 10:21   ` Paolo Bonzini
2016-01-21 15:56     ` John Snow
2016-01-26 20:26 ` John Snow
2016-01-26 21:14   ` Hervé Poussineau

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1452439498-21098-5-git-send-email-hpoussin@reactos.org \
    --to=hpoussin@reactos.org \
    --cc=mst@redhat.com \
    --cc=pbonzini@redhat.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.