All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Hervé Poussineau" <hpoussin@reactos.org>
To: qemu-devel@nongnu.org
Cc: "Paolo Bonzini" <pbonzini@redhat.com>,
	"Hervé Poussineau" <hpoussin@reactos.org>,
	"Gerd Hoffmann" <kraxel@redhat.com>,
	"Michael S. Tsirkin" <mst@redhat.com>
Subject: [Qemu-devel] [PATCH v2 18/19] sb16: use IsaDma interface instead of global DMA_* functions
Date: Sun, 10 Jan 2016 16:24:57 +0100	[thread overview]
Message-ID: <1452439498-21098-19-git-send-email-hpoussin@reactos.org> (raw)
In-Reply-To: <1452439498-21098-1-git-send-email-hpoussin@reactos.org>

Signed-off-by: Hervé Poussineau <hpoussin@reactos.org>
---
 hw/audio/sb16.c | 23 ++++++++++++++++++-----
 1 file changed, 18 insertions(+), 5 deletions(-)

diff --git a/hw/audio/sb16.c b/hw/audio/sb16.c
index 995435f..9973e77 100644
--- a/hw/audio/sb16.c
+++ b/hw/audio/sb16.c
@@ -55,6 +55,8 @@ typedef struct SB16State {
     uint32_t hdma;
     uint32_t port;
     uint32_t ver;
+    IsaDma *isa_dma;
+    IsaDma *isa_hdma;
 
     int in_index;
     int out_data_len;
@@ -165,16 +167,18 @@ static void speaker (SB16State *s, int on)
 static void control (SB16State *s, int hold)
 {
     int dma = s->use_hdma ? s->hdma : s->dma;
+    IsaDma *isa_dma = s->use_hdma ? s->isa_hdma : s->isa_dma;
+    IsaDmaClass *k = ISADMA_GET_CLASS(isa_dma);
     s->dma_running = hold;
 
     ldebug ("hold %d high %d dma %d\n", hold, s->use_hdma, dma);
 
     if (hold) {
-        DMA_hold_DREQ (dma);
+        k->hold_DREQ(isa_dma, dma);
         AUD_set_active_out (s->voice, 1);
     }
     else {
-        DMA_release_DREQ (dma);
+        k->release_DREQ(isa_dma, dma);
         AUD_set_active_out (s->voice, 0);
     }
 }
@@ -1136,6 +1140,8 @@ static uint32_t mixer_read(void *opaque, uint32_t nport)
 static int write_audio (SB16State *s, int nchan, int dma_pos,
                         int dma_len, int len)
 {
+    IsaDma *isa_dma = nchan == s->dma ? s->isa_dma : s->isa_hdma;
+    IsaDmaClass *k = ISADMA_GET_CLASS(isa_dma);
     int temp, net;
     uint8_t tmpbuf[4096];
 
@@ -1152,7 +1158,7 @@ static int write_audio (SB16State *s, int nchan, int dma_pos,
             to_copy = sizeof (tmpbuf);
         }
 
-        copied = DMA_read_memory (nchan, tmpbuf, dma_pos, to_copy);
+        copied = k->read_memory(isa_dma, nchan, tmpbuf, dma_pos, to_copy);
         copied = AUD_write (s->voice, tmpbuf, copied);
 
         temp -= copied;
@@ -1354,6 +1360,7 @@ static void sb16_realizefn (DeviceState *dev, Error **errp)
 {
     ISADevice *isadev = ISA_DEVICE (dev);
     SB16State *s = SB16 (dev);
+    IsaDmaClass *k;
 
     isa_init_irq (isadev, &s->pic, s->irq);
 
@@ -1372,8 +1379,14 @@ static void sb16_realizefn (DeviceState *dev, Error **errp)
 
     isa_register_portio_list (isadev, s->port, sb16_ioport_list, s, "sb16");
 
-    DMA_register_channel (s->hdma, SB_read_DMA, s);
-    DMA_register_channel (s->dma, SB_read_DMA, s);
+    s->isa_hdma = isa_get_dma(isa_bus_from_device(isadev), s->hdma);
+    k = ISADMA_GET_CLASS(s->isa_hdma);
+    k->register_channel(s->isa_hdma, s->hdma, SB_read_DMA, s);
+
+    s->isa_dma = isa_get_dma(isa_bus_from_device(isadev), s->dma);
+    k = ISADMA_GET_CLASS(s->isa_dma);
+    k->register_channel(s->isa_dma, s->dma, SB_read_DMA, s);
+
     s->can_write = 1;
 
     AUD_register_card ("sb16", &s->card);
-- 
2.1.4

  parent reply	other threads:[~2016-01-10 15:25 UTC|newest]

Thread overview: 25+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-01-10 15:24 [Qemu-devel] [PATCH v2 00/19] ISA DMA controllers cleanup (i8257, i82374) Hervé Poussineau
2016-01-10 15:24 ` [Qemu-devel] [PATCH v2 01/19] i82374: device only existed as ISA device, so simplify device Hervé Poussineau
2016-01-10 15:24 ` [Qemu-devel] [PATCH v2 02/19] i8257: pass ISA bus to DMA_init() function Hervé Poussineau
2016-01-10 15:24 ` [Qemu-devel] [PATCH v2 03/19] i8257: rename struct dma_cont to I8257State Hervé Poussineau
2016-01-10 15:24 ` [Qemu-devel] [PATCH v2 04/19] i8257: rename struct dma_regs to I8257Regs Hervé Poussineau
2016-01-10 15:24 ` [Qemu-devel] [PATCH v2 05/19] i8257: rename functions to start with i8257_ prefix Hervé Poussineau
2016-01-10 15:24 ` [Qemu-devel] [PATCH v2 06/19] i8257: make the DMA running method per controller Hervé Poussineau
2016-01-10 15:24 ` [Qemu-devel] [PATCH v2 07/19] i8257: add missing const Hervé Poussineau
2016-01-10 15:24 ` [Qemu-devel] [PATCH v2 08/19] i8257: QOM'ify Hervé Poussineau
2016-01-10 15:24 ` [Qemu-devel] [PATCH v2 09/19] i8257: move state definition to new independent header Hervé Poussineau
2016-01-10 15:24 ` [Qemu-devel] [PATCH v2 10/19] isa: add an ISA DMA interface, and store it within the ISA bus Hervé Poussineau
2016-01-10 15:24 ` [Qemu-devel] [PATCH v2 11/19] i8257: implement the IsaDma interface Hervé Poussineau
2016-01-10 15:24 ` [Qemu-devel] [PATCH v2 12/19] magnum: disable floppy DMA for now Hervé Poussineau
2016-01-10 15:24 ` [Qemu-devel] [PATCH v2 13/19] sparc: disable floppy DMA Hervé Poussineau
2016-01-10 15:24 ` [Qemu-devel] [PATCH v2 14/19] sparc64: " Hervé Poussineau
2016-01-10 15:24 ` [Qemu-devel] [PATCH v2 15/19] fdc: use IsaDma interface instead of global DMA_* functions Hervé Poussineau
2016-01-10 15:24 ` [Qemu-devel] [PATCH v2 16/19] cs4231a: " Hervé Poussineau
2016-01-10 15:24 ` [Qemu-devel] [PATCH v2 17/19] gus: " Hervé Poussineau
2016-01-10 15:24 ` Hervé Poussineau [this message]
2016-01-10 15:24 ` [Qemu-devel] [PATCH v2 19/19] dma: remove now useless " Hervé Poussineau
2016-01-20 20:31 ` [Qemu-devel] [PATCH v2 00/19] ISA DMA controllers cleanup (i8257, i82374) Hervé Poussineau
2016-01-21 10:21   ` Paolo Bonzini
2016-01-21 15:56     ` John Snow
2016-01-26 20:26 ` John Snow
2016-01-26 21:14   ` Hervé Poussineau

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1452439498-21098-19-git-send-email-hpoussin@reactos.org \
    --to=hpoussin@reactos.org \
    --cc=kraxel@redhat.com \
    --cc=mst@redhat.com \
    --cc=pbonzini@redhat.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.