All of lore.kernel.org
 help / color / mirror / Atom feed
From: Lucas Stach <dev@lynxeye.de>
To: Joshua Clayton <stillcompiling@gmail.com>,
	Thierry Reding <thierry.reding@gmail.com>,
	David Airlie <airlied@linux.ie>
Cc: linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org
Subject: Re: [PATCH] drm/panel: simple: Add support for Sharp LQ101K1LY04
Date: Tue, 12 Jan 2016 19:45:30 +0100	[thread overview]
Message-ID: <1452624330.2628.3.camel@lynxeye.de> (raw)
In-Reply-To: <1452614746-7841-1-git-send-email-stillcompiling@gmail.com>

Hi Joshua,

Am Dienstag, den 12.01.2016, 08:05 -0800 schrieb Joshua Clayton:
> Sharp LQ101K1LY04 is a 10 inch WXGA (1280x800) lvds panel
> 

> ---
>  drivers/gpu/drm/panel/panel-simple.c | 26 ++++++++++++++++++++++++++

Missing documentation for the DT binding.

>  1 file changed, 26 insertions(+)
> 
> diff --git a/drivers/gpu/drm/panel/panel-simple.c
> b/drivers/gpu/drm/panel/panel-simple.c
> index f97b73e..9207b5d 100644
> --- a/drivers/gpu/drm/panel/panel-simple.c
> +++ b/drivers/gpu/drm/panel/panel-simple.c
> @@ -708,6 +708,29 @@ static const struct panel_desc
> giantplus_gpg482739qs5 = {
>  	.bus_format = MEDIA_BUS_FMT_RGB888_1X24,
>  };
>  
> +static const struct display_timing sharp_lq101k1ly04_timing = {
> +	.pixelclock = { 60000000, 65000000, 80000000 },
> +	.hactive = { 1280, 1280, 1280 },
> +	.hfront_porch = { 20, 20, 20 },
> +	.hback_porch = { 20, 20, 20 },
> +	.hsync_len = { 10, 10, 10 },
> +	.vactive = { 800, 800, 800 },
> +	.vfront_porch = { 4, 4, 4 },
> +	.vback_porch = { 4, 4, 4 },
> +	.vsync_len = { 4, 4, 4 },
> +	.flags = DISPLAY_FLAGS_PIXDATA_POSEDGE,
> +};
> +static const struct panel_desc sharp_lq101k1ly04 = {
> +	.timings = &sharp_lq101k1ly04_timing,
> +	.num_timings = 1,
> +	.bpc = 8,
> +	.size = {
> +		.width = 217,
> +		.height = 136,
> +	},
> +	.bus_format = MEDIA_BUS_FMT_RGB888_1X7X4_JEIDA,
> +};
> +
This hunk isn't added at the correct place. Please keep the
alphabetical sorting.

>  static const struct display_timing hannstar_hsd070pww1_timing = {
>  	.pixelclock = { 64300000, 71100000, 82000000 },
>  	.hactive = { 1280, 1280, 1280 },
> @@ -1146,6 +1169,9 @@ static const struct of_device_id
> platform_of_match[] = {
>  		.compatible = "hannstar,hsd070pww1",
>  		.data = &hannstar_hsd070pww1,
>  	}, {
> +		.compatible = "sharp,lq101k1ly04",
> +		.data = &sharp_lq101k1ly04,
> +	}, {

Wrong insertion place again.

>  		.compatible = "hannstar,hsd100pxn1",
>  		.data = &hannstar_hsd100pxn1,
>  	}, {
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/dri-devel

WARNING: multiple messages have this Message-ID (diff)
From: Lucas Stach <dev@lynxeye.de>
To: Joshua Clayton <stillcompiling@gmail.com>,
	Thierry Reding <thierry.reding@gmail.com>,
	David Airlie <airlied@linux.ie>
Cc: linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org
Subject: Re: [PATCH] drm/panel: simple: Add support for Sharp LQ101K1LY04
Date: Tue, 12 Jan 2016 19:45:30 +0100	[thread overview]
Message-ID: <1452624330.2628.3.camel@lynxeye.de> (raw)
In-Reply-To: <1452614746-7841-1-git-send-email-stillcompiling@gmail.com>

Hi Joshua,

Am Dienstag, den 12.01.2016, 08:05 -0800 schrieb Joshua Clayton:
> Sharp LQ101K1LY04 is a 10 inch WXGA (1280x800) lvds panel
> 

> ---
>  drivers/gpu/drm/panel/panel-simple.c | 26 ++++++++++++++++++++++++++

Missing documentation for the DT binding.

>  1 file changed, 26 insertions(+)
> 
> diff --git a/drivers/gpu/drm/panel/panel-simple.c
> b/drivers/gpu/drm/panel/panel-simple.c
> index f97b73e..9207b5d 100644
> --- a/drivers/gpu/drm/panel/panel-simple.c
> +++ b/drivers/gpu/drm/panel/panel-simple.c
> @@ -708,6 +708,29 @@ static const struct panel_desc
> giantplus_gpg482739qs5 = {
>  	.bus_format = MEDIA_BUS_FMT_RGB888_1X24,
>  };
>  
> +static const struct display_timing sharp_lq101k1ly04_timing = {
> +	.pixelclock = { 60000000, 65000000, 80000000 },
> +	.hactive = { 1280, 1280, 1280 },
> +	.hfront_porch = { 20, 20, 20 },
> +	.hback_porch = { 20, 20, 20 },
> +	.hsync_len = { 10, 10, 10 },
> +	.vactive = { 800, 800, 800 },
> +	.vfront_porch = { 4, 4, 4 },
> +	.vback_porch = { 4, 4, 4 },
> +	.vsync_len = { 4, 4, 4 },
> +	.flags = DISPLAY_FLAGS_PIXDATA_POSEDGE,
> +};
> +static const struct panel_desc sharp_lq101k1ly04 = {
> +	.timings = &sharp_lq101k1ly04_timing,
> +	.num_timings = 1,
> +	.bpc = 8,
> +	.size = {
> +		.width = 217,
> +		.height = 136,
> +	},
> +	.bus_format = MEDIA_BUS_FMT_RGB888_1X7X4_JEIDA,
> +};
> +
This hunk isn't added at the correct place. Please keep the
alphabetical sorting.

>  static const struct display_timing hannstar_hsd070pww1_timing = {
>  	.pixelclock = { 64300000, 71100000, 82000000 },
>  	.hactive = { 1280, 1280, 1280 },
> @@ -1146,6 +1169,9 @@ static const struct of_device_id
> platform_of_match[] = {
>  		.compatible = "hannstar,hsd070pww1",
>  		.data = &hannstar_hsd070pww1,
>  	}, {
> +		.compatible = "sharp,lq101k1ly04",
> +		.data = &sharp_lq101k1ly04,
> +	}, {

Wrong insertion place again.

>  		.compatible = "hannstar,hsd100pxn1",
>  		.data = &hannstar_hsd100pxn1,
>  	}, {

  parent reply	other threads:[~2016-01-12 18:45 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-01-12 16:05 [PATCH] drm/panel: simple: Add support for Sharp LQ101K1LY04 Joshua Clayton
2016-01-12 17:41 ` Joshua Clayton
2016-01-12 18:45 ` Lucas Stach [this message]
2016-01-12 18:45   ` Lucas Stach
2016-01-12 20:40   ` Joshua Clayton

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1452624330.2628.3.camel@lynxeye.de \
    --to=dev@lynxeye.de \
    --cc=airlied@linux.ie \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=stillcompiling@gmail.com \
    --cc=thierry.reding@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.